From 8255bac32e06eee9c19adfcb5788c44dc347eb69 Mon Sep 17 00:00:00 2001 From: Dmitry Brant Date: Fri, 26 May 2017 15:15:21 -0400 Subject: [PATCH] Don't store Activity instance in adapter. --- .../commons/contributions/ContributionsActivity.java | 2 +- .../contributions/ContributionsListAdapter.java | 10 ++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java index b23bf7fbb..e1d39db06 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java @@ -227,7 +227,7 @@ public class ContributionsActivity @Override public void onLoadFinished(Loader cursorLoader, Cursor cursor) { if(contributionsList.getAdapter() == null) { - contributionsList.setAdapter(new ContributionsListAdapter(this, cursor, 0)); + contributionsList.setAdapter(new ContributionsListAdapter(getApplicationContext(), cursor, 0)); } else { ((CursorAdapter)contributionsList.getAdapter()).swapCursor(cursor); } diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListAdapter.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListAdapter.java index 08ed3198c..d34d74a5a 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListAdapter.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListAdapter.java @@ -1,25 +1,23 @@ package fr.free.nrw.commons.contributions; -import android.app.Activity; import android.content.Context; import android.database.Cursor; import android.support.v4.widget.CursorAdapter; +import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; import fr.free.nrw.commons.R; class ContributionsListAdapter extends CursorAdapter { - private Activity activity; - public ContributionsListAdapter(Activity activity, Cursor c, int flags) { - super(activity, c, flags); - this.activity = activity; + public ContributionsListAdapter(Context context, Cursor c, int flags) { + super(context, c, flags); } @Override public View newView(Context context, Cursor cursor, ViewGroup viewGroup) { - View parent = activity.getLayoutInflater().inflate(R.layout.layout_contribution, viewGroup, false); + View parent = LayoutInflater.from(context).inflate(R.layout.layout_contribution, viewGroup, false); parent.setTag(new ContributionViewHolder(parent)); return parent; }