mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

#3579 p18Value causes NPE in WikidataEditService createClaimWithLogging - add null check (#3580)

Browse source
This commit is contained in:
Seán Mac Gillicuddy 2020-03-24 14:59:44 +00:00 • committed by GitHub
parent 8cb4e28a97
commit 7ed911808d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/fr/free/nrw/commons/wikidata/WikidataEditService.java
View file

@ -50,7 +50,7 @@ public class WikidataEditService {
* @param fileName name of the file we will upload * @param fileName name of the file we will upload
* @param p18Value pic attribute of Wikidata item * @param p18Value pic attribute of Wikidata item
*/ */
public void createClaimWithLogging(String wikidataEntityId, String wikiItemName, String fileName, @NonNull String p18Value) { public void createClaimWithLogging(String wikidataEntityId, String wikiItemName, String fileName, String p18Value) {
if (wikidataEntityId == null) { if (wikidataEntityId == null) {
Timber.d("Skipping creation of claim as Wikidata entity ID is null"); Timber.d("Skipping creation of claim as Wikidata entity ID is null");
return; return;
@ -66,7 +66,7 @@ public class WikidataEditService {
return; return;
} }
if (!p18Value.trim().isEmpty()) { if (p18Value != null && !p18Value.trim().isEmpty()) {
Timber.d("Skipping creation of claim as p18Value is not empty, we won't override existing image"); Timber.d("Skipping creation of claim as p18Value is not empty, we won't override existing image");
return; return;
} }