From 7ed911808d89e8fba4189ed7e442d2a195d76741 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Se=C3=A1n=20Mac=20Gillicuddy?= Date: Tue, 24 Mar 2020 14:59:44 +0000 Subject: [PATCH] #3579 p18Value causes NPE in WikidataEditService createClaimWithLogging - add null check (#3580) --- .../fr/free/nrw/commons/wikidata/WikidataEditService.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/wikidata/WikidataEditService.java b/app/src/main/java/fr/free/nrw/commons/wikidata/WikidataEditService.java index eb7ff5ae2..25cc020fb 100644 --- a/app/src/main/java/fr/free/nrw/commons/wikidata/WikidataEditService.java +++ b/app/src/main/java/fr/free/nrw/commons/wikidata/WikidataEditService.java @@ -50,7 +50,7 @@ public class WikidataEditService { * @param fileName name of the file we will upload * @param p18Value pic attribute of Wikidata item */ - public void createClaimWithLogging(String wikidataEntityId, String wikiItemName, String fileName, @NonNull String p18Value) { + public void createClaimWithLogging(String wikidataEntityId, String wikiItemName, String fileName, String p18Value) { if (wikidataEntityId == null) { Timber.d("Skipping creation of claim as Wikidata entity ID is null"); return; @@ -66,7 +66,7 @@ public class WikidataEditService { return; } - if (!p18Value.trim().isEmpty()) { + if (p18Value != null && !p18Value.trim().isEmpty()) { Timber.d("Skipping creation of claim as p18Value is not empty, we won't override existing image"); return; }