mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 21:03:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixes #3197 Replace hardcoded dimensions with dimen resource values (#3402)

Browse source
This commit is contained in:
Yash Khare 2020-02-12 09:56:33 +05:30 • committed by GitHub
parent 9b3f3e9d3c
commit 69e7161c61
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
125 changed files with 542 additions and 506 deletions
Download patch file Download diff file Expand all files Collapse all files

24
app/src/main/res/layout-land/activity_login.xml
View file

@ -9,7 +9,7 @@
android:layout_height="match_parent"
android:orientation="vertical">
<FrameLayout
android:layout_width="400sp"
android:layout_width="@dimen/landscape_width"
android:layout_height="wrap_content"
android:layout_gravity="center"
android:layout_marginTop="@dimen/small_gap">
@ -23,8 +23,8 @@
android:layout_marginRight="@dimen/standard_gap"
android:layout_marginStart="@dimen/standard_gap"
android:layout_marginTop="@dimen/large_gap"
app:cardCornerRadius="4dp"
app:cardElevation="4dp">
app:cardCornerRadius="@dimen/tiny_margin"
app:cardElevation="@dimen/tiny_margin">
<RelativeLayout
android:layout_width="match_parent"
@ -170,7 +170,7 @@
<Button
android:id="@+id/sign_up_button"
style="@style/Widget.AppCompat.Button.Borderless.Colored"
android:layout_width="0dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="wrap_content"
android:layout_gravity="center_horizontal"
android:layout_marginEnd="@dimen/small_gap"
@ -181,7 +181,7 @@
<Button
android:id="@+id/login_button"
style="@style/Widget.AppCompat.Button.Colored"
android:layout_width="0dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="wrap_content"
android:layout_marginLeft="@dimen/small_gap"
android:layout_marginStart="@dimen/small_gap"
@ -216,19 +216,19 @@
</androidx.cardview.widget.CardView>
<androidx.appcompat.widget.AppCompatImageView
android:layout_width="64dp"
android:layout_height="64dp"
android:layout_width="@dimen/gigantic_gap"
android:layout_height="@dimen/gigantic_gap"
android:layout_gravity="center_horizontal"
android:elevation="8dp"
android:elevation="@dimen/activity_margin_horizontal"
app:srcCompat="@drawable/blue_rinse_circle"
tools:ignore="UnusedAttribute" />
<androidx.appcompat.widget.AppCompatImageView
android:layout_width="42dp"
android:layout_height="42dp"
android:layout_width="@dimen/dimen_42"
android:layout_height="@dimen/dimen_42"
android:layout_gravity="center_horizontal"
android:layout_marginTop="8dp"
android:elevation="8dp"
android:layout_marginTop="@dimen/activity_margin_horizontal"
android:elevation="@dimen/activity_margin_horizontal"
app:srcCompat="@drawable/commons_logo"
tools:ignore="UnusedAttribute" />

4
app/src/main/res/layout-land/welcome_do_upload.xml
View file

@ -8,7 +8,7 @@
android:paddingRight="@dimen/huge_gap">
<ImageView
android:layout_width="0dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="wrap_content"
android:layout_marginRight="@dimen/large_gap"
android:layout_weight="0.5"
@ -17,7 +17,7 @@
android:src="@drawable/welcome_do_upload" />
<LinearLayout
android:layout_width="0dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="wrap_content"
android:layout_weight="0.5"
android:orientation="vertical">

4
app/src/main/res/layout-land/welcome_dont_upload.xml
View file

@ -8,7 +8,7 @@
android:paddingRight="@dimen/huge_gap">
<ImageView
android:layout_width="0dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="wrap_content"
android:layout_marginRight="@dimen/large_gap"
android:layout_weight="0.5"
@ -17,7 +17,7 @@
android:src="@drawable/welcome_dont_upload" />
<LinearLayout
android:layout_width="0dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="wrap_content"
android:layout_weight="0.5"
android:orientation="vertical">

4
app/src/main/res/layout-land/welcome_image_example.xml
View file

@ -8,7 +8,7 @@
android:paddingRight="@dimen/huge_gap">
<ImageView
android:layout_width="0dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="wrap_content"
android:layout_marginRight="@dimen/large_gap"
android:layout_weight="0.5"
@ -17,7 +17,7 @@
android:src="@drawable/welcome_image_example" />
<LinearLayout
android:layout_width="0dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="wrap_content"
android:layout_weight="0.5"
android:orientation="vertical">

4
app/src/main/res/layout-land/welcome_wikipedia.xml
View file

@ -8,7 +8,7 @@
android:paddingRight="@dimen/huge_gap">
<ImageView
android:layout_width="0dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="wrap_content"
android:layout_marginRight="@dimen/large_gap"
android:layout_weight="0.5"
@ -17,7 +17,7 @@
android:src="@drawable/welcome_wikipedia" />
<LinearLayout
android:layout_width="0dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="wrap_content"
android:layout_weight="0.5"
android:orientation="vertical">