From 69e7161c61472ee4a175db9672c0086545b37d81 Mon Sep 17 00:00:00 2001 From: Yash Khare Date: Wed, 12 Feb 2020 09:56:33 +0530 Subject: [PATCH] Fixes #3197 Replace hardcoded dimensions with dimen resource values (#3402) --- .../main/res/drawable/bg_delete_button.xml | 4 +- .../main/res/drawable/ic_action_website.xml | 4 +- .../main/res/drawable/ic_add_white_24dp.xml | 4 +- .../main/res/drawable/ic_check_black_24dp.xml | 4 +- .../res/drawable/ic_check_box_black_24dp.xml | 4 +- .../ic_check_box_outline_blank_black_24dp.xml | 4 +- .../main/res/drawable/ic_clear_black_24dp.xml | 4 +- .../res/drawable/ic_commons_icon_vector.xml | 4 +- .../drawable/ic_custom_bookmark_marker.xml | 2 +- .../drawable/ic_custom_greyed_out_marker.xml | 2 +- .../res/drawable/ic_custom_map_marker.xml | 2 +- .../drawable/ic_custom_map_marker_green.xml | 2 +- .../drawable/ic_custom_map_marker_grey.xml | 2 +- .../res/drawable/ic_directions_black_24dp.xml | 4 +- .../main/res/drawable/ic_done_black_24dp.xml | 4 +- .../res/drawable/ic_download_white_24dp.xml | 4 +- .../main/res/drawable/ic_edit_black_24dp.xml | 4 +- .../drawable/ic_error_outline_black_24dp.xml | 4 +- .../main/res/drawable/ic_error_red_24dp.xml | 4 +- .../drawable/ic_exit_to_app_black_24dp.xml | 4 +- .../drawable/ic_expand_less_black_24dp.xml | 4 +- app/src/main/res/drawable/ic_explore_24dp.xml | 4 +- .../res/drawable/ic_feedback_black_24dp.xml | 4 +- .../main/res/drawable/ic_help_black_24dp.xml | 4 +- .../main/res/drawable/ic_home_black_24dp.xml | 4 +- .../main/res/drawable/ic_image_black_24dp.xml | 4 +- .../ic_indeterminate_check_box_black_24dp.xml | 4 +- .../res/drawable/ic_info_outline_24dp.xml | 4 +- .../main/res/drawable/ic_list_white_24dp.xml | 4 +- .../res/drawable/ic_location_white_24dp.xml | 4 +- .../main/res/drawable/ic_map_white_24dp.xml | 4 +- .../res/drawable/ic_message_black_24dp.xml | 4 +- .../res/drawable/ic_more_vert_white_24dp.xml | 4 +- .../drawable/ic_my_location_black_24dp.xml | 4 +- .../ic_notifications_off_black_24dp.xml | 4 +- .../drawable/ic_notifications_white_24dp.xml | 4 +- app/src/main/res/drawable/ic_overflow.xml | 4 +- .../drawable/ic_photo_camera_white_24dp.xml | 4 +- .../main/res/drawable/ic_photo_white_24dp.xml | 4 +- .../res/drawable/ic_refresh_white_24dp.xml | 4 +- .../drawable/ic_round_star_border_24px.xml | 4 +- .../drawable/ic_round_star_filled_24px.xml | 4 +- .../main/res/drawable/ic_save_white_24dp.xml | 4 +- .../main/res/drawable/ic_send_white_24dp.xml | 4 +- .../res/drawable/ic_settings_black_24dp.xml | 4 +- .../main/res/drawable/ic_share_black_24dp.xml | 4 +- app/src/main/res/drawable/ic_thanks.xml | 4 +- .../res/drawable/ic_wikidata_logo_24dp.xml | 4 +- .../res/drawable/ic_wikipedia_logo_24dp.xml | 4 +- .../main/res/drawable/notification_badge.xml | 4 +- .../main/res/drawable/round_icon_airport.xml | 4 +- .../main/res/drawable/round_icon_bridge.xml | 4 +- .../main/res/drawable/round_icon_church.xml | 4 +- app/src/main/res/drawable/round_icon_city.xml | 4 +- .../main/res/drawable/round_icon_forest.xml | 4 +- .../res/drawable/round_icon_gatehouse.xml | 4 +- .../drawable/round_icon_generic_building.xml | 4 +- .../main/res/drawable/round_icon_house.xml | 4 +- .../main/res/drawable/round_icon_island.xml | 4 +- .../res/drawable/round_icon_milestone.xml | 4 +- .../main/res/drawable/round_icon_mountain.xml | 4 +- .../main/res/drawable/round_icon_ocean.xml | 4 +- app/src/main/res/drawable/round_icon_park.xml | 4 +- .../drawable/round_icon_railway_station.xml | 4 +- .../main/res/drawable/round_icon_river.xml | 4 +- app/src/main/res/drawable/round_icon_road.xml | 4 +- .../main/res/drawable/round_icon_school.xml | 4 +- .../main/res/drawable/round_icon_unknown.xml | 4 +- .../res/drawable/round_icon_waterfall.xml | 4 +- .../main/res/drawable/thumbnail_selected.xml | 10 +- .../main/res/layout-land/activity_login.xml | 24 ++--- .../res/layout-land/welcome_do_upload.xml | 4 +- .../res/layout-land/welcome_dont_upload.xml | 4 +- .../res/layout-land/welcome_image_example.xml | 4 +- .../res/layout-land/welcome_wikipedia.xml | 4 +- app/src/main/res/layout-v21/drawer_view.xml | 2 +- .../main/res/layout-xlarge/activity_login.xml | 24 ++--- .../main/res/layout/activity_achievements.xml | 100 +++++++++--------- .../main/res/layout/activity_bookmarks.xml | 8 +- app/src/main/res/layout/activity_login.xml | 22 ++-- .../main/res/layout/activity_notification.xml | 6 +- app/src/main/res/layout/activity_quiz.xml | 10 +- .../main/res/layout/activity_quiz_result.xml | 10 +- app/src/main/res/layout/activity_review.xml | 18 ++-- app/src/main/res/layout/activity_upload.xml | 18 ++-- app/src/main/res/layout/activity_welcome.xml | 2 +- .../main/res/layout/bottom_sheet_details.xml | 64 +++++------ .../res/layout/custom_nearby_tab_layout.xml | 8 +- app/src/main/res/layout/drawer_header.xml | 16 +-- app/src/main/res/layout/drawer_view.xml | 2 +- app/src/main/res/layout/filter_chip_view.xml | 4 +- .../res/layout/filter_search_view_layout.xml | 4 +- .../layout/fragment_bookmarks_pictures.xml | 2 +- .../main/res/layout/fragment_browse_image.xml | 4 +- .../res/layout/fragment_category_images.xml | 2 +- .../res/layout/fragment_contributions.xml | 4 +- .../layout/fragment_contributions_list.xml | 10 +- .../res/layout/fragment_media_license.xml | 14 +-- .../res/layout/fragment_nearby_parent.xml | 32 +++--- .../main/res/layout/fragment_review_image.xml | 16 +-- .../res/layout/fragment_search_history.xml | 10 +- .../layout/fragment_similar_image_dialog.xml | 22 ++-- .../fragment_upload_media_detail_fragment.xml | 24 ++--- .../main/res/layout/image_alert_layout.xml | 4 +- app/src/main/res/layout/item_notification.xml | 24 ++--- app/src/main/res/layout/item_place.xml | 10 +- .../main/res/layout/item_upload_thumbnail.xml | 12 +-- app/src/main/res/layout/layout_campagin.xml | 26 ++--- .../res/layout/layout_category_images.xml | 6 +- .../main/res/layout/layout_contribution.xml | 16 +-- app/src/main/res/layout/nearby_card_view.xml | 32 +++--- .../main/res/layout/nearby_filter_list.xml | 8 +- .../res/layout/nearby_permission_dialog.xml | 8 +- app/src/main/res/layout/nearby_row_button.xml | 32 +++--- .../res/layout/nearby_search_list_item.xml | 2 +- .../layout/nearby_search_list_item_dark.xml | 2 +- app/src/main/res/layout/notification_icon.xml | 6 +- .../main/res/layout/pic_of_day_app_widget.xml | 16 +-- app/src/main/res/layout/question_layout.xml | 4 +- .../main/res/layout/row_item_description.xml | 4 +- .../res/layout/row_item_languages_spinner.xml | 10 +- .../res/layout/upload_categories_fragment.xml | 10 +- app/src/main/res/layout/welcome_bullet.xml | 2 +- app/src/main/res/layout/welcome_final.xml | 4 +- app/src/main/res/values/dimens.xml | 36 +++++++ 125 files changed, 542 insertions(+), 506 deletions(-) diff --git a/app/src/main/res/drawable/bg_delete_button.xml b/app/src/main/res/drawable/bg_delete_button.xml index 199940e1b..819986f5b 100644 --- a/app/src/main/res/drawable/bg_delete_button.xml +++ b/app/src/main/res/drawable/bg_delete_button.xml @@ -11,7 +11,7 @@ + android:radius="@dimen/progressbar_stroke" /> @@ -25,7 +25,7 @@ + android:radius="@dimen/progressbar_stroke" /> diff --git a/app/src/main/res/drawable/ic_action_website.xml b/app/src/main/res/drawable/ic_action_website.xml index bad3beb94..7a5a425cc 100644 --- a/app/src/main/res/drawable/ic_action_website.xml +++ b/app/src/main/res/drawable/ic_action_website.xml @@ -1,9 +1,9 @@ + android:width="@dimen/half_standard_height" xmlns:android="http://schemas.android.com/apk/res/android"> diff --git a/app/src/main/res/drawable/ic_commons_icon_vector.xml b/app/src/main/res/drawable/ic_commons_icon_vector.xml index 5af95beec..3b7d76947 100644 --- a/app/src/main/res/drawable/ic_commons_icon_vector.xml +++ b/app/src/main/res/drawable/ic_commons_icon_vector.xml @@ -1,8 +1,8 @@ diff --git a/app/src/main/res/drawable/ic_custom_bookmark_marker.xml b/app/src/main/res/drawable/ic_custom_bookmark_marker.xml index c615405c2..6edbfe427 100644 --- a/app/src/main/res/drawable/ic_custom_bookmark_marker.xml +++ b/app/src/main/res/drawable/ic_custom_bookmark_marker.xml @@ -1,5 +1,5 @@ diff --git a/app/src/main/res/drawable/ic_custom_greyed_out_marker.xml b/app/src/main/res/drawable/ic_custom_greyed_out_marker.xml index d9a960a23..70521cbe9 100644 --- a/app/src/main/res/drawable/ic_custom_greyed_out_marker.xml +++ b/app/src/main/res/drawable/ic_custom_greyed_out_marker.xml @@ -1,5 +1,5 @@ diff --git a/app/src/main/res/drawable/ic_custom_map_marker.xml b/app/src/main/res/drawable/ic_custom_map_marker.xml index 01b540076..54a9ac5f8 100644 --- a/app/src/main/res/drawable/ic_custom_map_marker.xml +++ b/app/src/main/res/drawable/ic_custom_map_marker.xml @@ -1,5 +1,5 @@ diff --git a/app/src/main/res/drawable/ic_custom_map_marker_green.xml b/app/src/main/res/drawable/ic_custom_map_marker_green.xml index 1d33fa712..6c7eb95fe 100644 --- a/app/src/main/res/drawable/ic_custom_map_marker_green.xml +++ b/app/src/main/res/drawable/ic_custom_map_marker_green.xml @@ -1,5 +1,5 @@ diff --git a/app/src/main/res/drawable/ic_custom_map_marker_grey.xml b/app/src/main/res/drawable/ic_custom_map_marker_grey.xml index e3ca5674a..e5c5588a4 100644 --- a/app/src/main/res/drawable/ic_custom_map_marker_grey.xml +++ b/app/src/main/res/drawable/ic_custom_map_marker_grey.xml @@ -1,5 +1,5 @@ diff --git a/app/src/main/res/drawable/ic_directions_black_24dp.xml b/app/src/main/res/drawable/ic_directions_black_24dp.xml index fe95ed7b1..0924d9e52 100644 --- a/app/src/main/res/drawable/ic_directions_black_24dp.xml +++ b/app/src/main/res/drawable/ic_directions_black_24dp.xml @@ -1,6 +1,6 @@ + android:width="@dimen/half_standard_height" xmlns:android="http://schemas.android.com/apk/res/android"> diff --git a/app/src/main/res/drawable/ic_download_white_24dp.xml b/app/src/main/res/drawable/ic_download_white_24dp.xml index b8e836142..ae4b97919 100644 --- a/app/src/main/res/drawable/ic_download_white_24dp.xml +++ b/app/src/main/res/drawable/ic_download_white_24dp.xml @@ -1,5 +1,5 @@ - + android:width="@dimen/half_standard_height" xmlns:android="http://schemas.android.com/apk/res/android"> diff --git a/app/src/main/res/drawable/ic_edit_black_24dp.xml b/app/src/main/res/drawable/ic_edit_black_24dp.xml index 2ab2fb753..0aefb9b8b 100644 --- a/app/src/main/res/drawable/ic_edit_black_24dp.xml +++ b/app/src/main/res/drawable/ic_edit_black_24dp.xml @@ -1,6 +1,6 @@ + android:width="@dimen/half_standard_height" xmlns:android="http://schemas.android.com/apk/res/android"> diff --git a/app/src/main/res/drawable/ic_exit_to_app_black_24dp.xml b/app/src/main/res/drawable/ic_exit_to_app_black_24dp.xml index 6f40d7725..21ec591fc 100644 --- a/app/src/main/res/drawable/ic_exit_to_app_black_24dp.xml +++ b/app/src/main/res/drawable/ic_exit_to_app_black_24dp.xml @@ -1,6 +1,6 @@ + android:width="@dimen/half_standard_height" xmlns:android="http://schemas.android.com/apk/res/android"> diff --git a/app/src/main/res/drawable/ic_map_white_24dp.xml b/app/src/main/res/drawable/ic_map_white_24dp.xml index 4cb341e6e..cbe78954b 100644 --- a/app/src/main/res/drawable/ic_map_white_24dp.xml +++ b/app/src/main/res/drawable/ic_map_white_24dp.xml @@ -1,6 +1,6 @@ + android:width="@dimen/half_standard_height" xmlns:android="http://schemas.android.com/apk/res/android"> diff --git a/app/src/main/res/drawable/ic_notifications_white_24dp.xml b/app/src/main/res/drawable/ic_notifications_white_24dp.xml index 120895c4f..48ea46fc1 100644 --- a/app/src/main/res/drawable/ic_notifications_white_24dp.xml +++ b/app/src/main/res/drawable/ic_notifications_white_24dp.xml @@ -1,6 +1,6 @@ - + android:width="@dimen/half_standard_height" xmlns:android="http://schemas.android.com/apk/res/android"> diff --git a/app/src/main/res/drawable/ic_overflow.xml b/app/src/main/res/drawable/ic_overflow.xml index c3f27d467..e97372a90 100644 --- a/app/src/main/res/drawable/ic_overflow.xml +++ b/app/src/main/res/drawable/ic_overflow.xml @@ -1,6 +1,6 @@ diff --git a/app/src/main/res/drawable/ic_photo_camera_white_24dp.xml b/app/src/main/res/drawable/ic_photo_camera_white_24dp.xml index 4fa7158a0..0882cd5b1 100644 --- a/app/src/main/res/drawable/ic_photo_camera_white_24dp.xml +++ b/app/src/main/res/drawable/ic_photo_camera_white_24dp.xml @@ -1,6 +1,6 @@ diff --git a/app/src/main/res/drawable/ic_round_star_border_24px.xml b/app/src/main/res/drawable/ic_round_star_border_24px.xml index d01dfa7fa..234b1dc7f 100644 --- a/app/src/main/res/drawable/ic_round_star_border_24px.xml +++ b/app/src/main/res/drawable/ic_round_star_border_24px.xml @@ -1,6 +1,6 @@ diff --git a/app/src/main/res/drawable/ic_settings_black_24dp.xml b/app/src/main/res/drawable/ic_settings_black_24dp.xml index ace746c40..d19715e50 100644 --- a/app/src/main/res/drawable/ic_settings_black_24dp.xml +++ b/app/src/main/res/drawable/ic_settings_black_24dp.xml @@ -1,6 +1,6 @@ + android:width="@dimen/half_standard_height" xmlns:android="http://schemas.android.com/apk/res/android"> diff --git a/app/src/main/res/drawable/ic_thanks.xml b/app/src/main/res/drawable/ic_thanks.xml index 480b45c1b..1ddaa940e 100644 --- a/app/src/main/res/drawable/ic_thanks.xml +++ b/app/src/main/res/drawable/ic_thanks.xml @@ -1,4 +1,4 @@ - + diff --git a/app/src/main/res/drawable/ic_wikidata_logo_24dp.xml b/app/src/main/res/drawable/ic_wikidata_logo_24dp.xml index f92da86c3..a3e73d8b1 100644 --- a/app/src/main/res/drawable/ic_wikidata_logo_24dp.xml +++ b/app/src/main/res/drawable/ic_wikidata_logo_24dp.xml @@ -1,7 +1,7 @@ - diff --git a/app/src/main/res/drawable/ic_wikipedia_logo_24dp.xml b/app/src/main/res/drawable/ic_wikipedia_logo_24dp.xml index 9056d87fa..2d081a667 100644 --- a/app/src/main/res/drawable/ic_wikipedia_logo_24dp.xml +++ b/app/src/main/res/drawable/ic_wikipedia_logo_24dp.xml @@ -1,7 +1,7 @@ - diff --git a/app/src/main/res/drawable/notification_badge.xml b/app/src/main/res/drawable/notification_badge.xml index babec7015..74233e848 100644 --- a/app/src/main/res/drawable/notification_badge.xml +++ b/app/src/main/res/drawable/notification_badge.xml @@ -5,6 +5,6 @@ + android:width="@dimen/medium_width" + android:height="@dimen/medium_height" /> \ No newline at end of file diff --git a/app/src/main/res/drawable/round_icon_airport.xml b/app/src/main/res/drawable/round_icon_airport.xml index 4a24f240b..4e58305b3 100644 --- a/app/src/main/res/drawable/round_icon_airport.xml +++ b/app/src/main/res/drawable/round_icon_airport.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_bridge.xml b/app/src/main/res/drawable/round_icon_bridge.xml index efe428b80..660f3cda1 100644 --- a/app/src/main/res/drawable/round_icon_bridge.xml +++ b/app/src/main/res/drawable/round_icon_bridge.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_church.xml b/app/src/main/res/drawable/round_icon_church.xml index c27a52669..fbbe9d147 100644 --- a/app/src/main/res/drawable/round_icon_church.xml +++ b/app/src/main/res/drawable/round_icon_church.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_city.xml b/app/src/main/res/drawable/round_icon_city.xml index ce4cc5c44..26ab9fd1a 100644 --- a/app/src/main/res/drawable/round_icon_city.xml +++ b/app/src/main/res/drawable/round_icon_city.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_forest.xml b/app/src/main/res/drawable/round_icon_forest.xml index c04d643ab..96511ccde 100644 --- a/app/src/main/res/drawable/round_icon_forest.xml +++ b/app/src/main/res/drawable/round_icon_forest.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_gatehouse.xml b/app/src/main/res/drawable/round_icon_gatehouse.xml index 7d04491fa..fb3e4bee2 100644 --- a/app/src/main/res/drawable/round_icon_gatehouse.xml +++ b/app/src/main/res/drawable/round_icon_gatehouse.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_generic_building.xml b/app/src/main/res/drawable/round_icon_generic_building.xml index 9e8f13593..44345e6e0 100644 --- a/app/src/main/res/drawable/round_icon_generic_building.xml +++ b/app/src/main/res/drawable/round_icon_generic_building.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_house.xml b/app/src/main/res/drawable/round_icon_house.xml index e69e05eba..d210e89df 100644 --- a/app/src/main/res/drawable/round_icon_house.xml +++ b/app/src/main/res/drawable/round_icon_house.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_island.xml b/app/src/main/res/drawable/round_icon_island.xml index 940ccd9d4..4157b163c 100644 --- a/app/src/main/res/drawable/round_icon_island.xml +++ b/app/src/main/res/drawable/round_icon_island.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_milestone.xml b/app/src/main/res/drawable/round_icon_milestone.xml index 23eb5142b..23923c0f3 100644 --- a/app/src/main/res/drawable/round_icon_milestone.xml +++ b/app/src/main/res/drawable/round_icon_milestone.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_mountain.xml b/app/src/main/res/drawable/round_icon_mountain.xml index 46c9999a0..911c2f53a 100644 --- a/app/src/main/res/drawable/round_icon_mountain.xml +++ b/app/src/main/res/drawable/round_icon_mountain.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_ocean.xml b/app/src/main/res/drawable/round_icon_ocean.xml index 7f62065aa..78df5f170 100644 --- a/app/src/main/res/drawable/round_icon_ocean.xml +++ b/app/src/main/res/drawable/round_icon_ocean.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_park.xml b/app/src/main/res/drawable/round_icon_park.xml index ed19fe8de..7e0cb01e7 100644 --- a/app/src/main/res/drawable/round_icon_park.xml +++ b/app/src/main/res/drawable/round_icon_park.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_railway_station.xml b/app/src/main/res/drawable/round_icon_railway_station.xml index 5a0520432..8732e27ef 100644 --- a/app/src/main/res/drawable/round_icon_railway_station.xml +++ b/app/src/main/res/drawable/round_icon_railway_station.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_river.xml b/app/src/main/res/drawable/round_icon_river.xml index 27dbaab62..dae050dfa 100644 --- a/app/src/main/res/drawable/round_icon_river.xml +++ b/app/src/main/res/drawable/round_icon_river.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_road.xml b/app/src/main/res/drawable/round_icon_road.xml index 4c5cb98ef..e65158d2b 100644 --- a/app/src/main/res/drawable/round_icon_road.xml +++ b/app/src/main/res/drawable/round_icon_road.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_school.xml b/app/src/main/res/drawable/round_icon_school.xml index 303610416..a4f9f1339 100644 --- a/app/src/main/res/drawable/round_icon_school.xml +++ b/app/src/main/res/drawable/round_icon_school.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_unknown.xml b/app/src/main/res/drawable/round_icon_unknown.xml index 33905d93b..774403976 100644 --- a/app/src/main/res/drawable/round_icon_unknown.xml +++ b/app/src/main/res/drawable/round_icon_unknown.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/round_icon_waterfall.xml b/app/src/main/res/drawable/round_icon_waterfall.xml index a02541583..ade5598d0 100644 --- a/app/src/main/res/drawable/round_icon_waterfall.xml +++ b/app/src/main/res/drawable/round_icon_waterfall.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/drawable/thumbnail_selected.xml b/app/src/main/res/drawable/thumbnail_selected.xml index ac6ec9335..19ab17e54 100644 --- a/app/src/main/res/drawable/thumbnail_selected.xml +++ b/app/src/main/res/drawable/thumbnail_selected.xml @@ -1,11 +1,11 @@ + android:width="@dimen/miniscule_margin"/> + android:bottom="@dimen/miniscule_margin" + android:left="@dimen/miniscule_margin" + android:right="@dimen/miniscule_margin" + android:top="@dimen/miniscule_margin"/> \ No newline at end of file diff --git a/app/src/main/res/layout-land/activity_login.xml b/app/src/main/res/layout-land/activity_login.xml index f322e4ce4..de281c1f5 100644 --- a/app/src/main/res/layout-land/activity_login.xml +++ b/app/src/main/res/layout-land/activity_login.xml @@ -9,7 +9,7 @@ android:layout_height="match_parent" android:orientation="vertical"> @@ -23,8 +23,8 @@ android:layout_marginRight="@dimen/standard_gap" android:layout_marginStart="@dimen/standard_gap" android:layout_marginTop="@dimen/large_gap" - app:cardCornerRadius="4dp" - app:cardElevation="4dp"> + app:cardCornerRadius="@dimen/tiny_margin" + app:cardElevation="@dimen/tiny_margin"> diff --git a/app/src/main/res/layout-land/welcome_do_upload.xml b/app/src/main/res/layout-land/welcome_do_upload.xml index 0ec9bc8b3..ede0396df 100644 --- a/app/src/main/res/layout-land/welcome_do_upload.xml +++ b/app/src/main/res/layout-land/welcome_do_upload.xml @@ -8,7 +8,7 @@ android:paddingRight="@dimen/huge_gap"> diff --git a/app/src/main/res/layout-land/welcome_dont_upload.xml b/app/src/main/res/layout-land/welcome_dont_upload.xml index 037950491..5d6053833 100644 --- a/app/src/main/res/layout-land/welcome_dont_upload.xml +++ b/app/src/main/res/layout-land/welcome_dont_upload.xml @@ -8,7 +8,7 @@ android:paddingRight="@dimen/huge_gap"> diff --git a/app/src/main/res/layout-land/welcome_image_example.xml b/app/src/main/res/layout-land/welcome_image_example.xml index 82a8ae29c..9662588d1 100644 --- a/app/src/main/res/layout-land/welcome_image_example.xml +++ b/app/src/main/res/layout-land/welcome_image_example.xml @@ -8,7 +8,7 @@ android:paddingRight="@dimen/huge_gap"> diff --git a/app/src/main/res/layout-land/welcome_wikipedia.xml b/app/src/main/res/layout-land/welcome_wikipedia.xml index 6104bb6e3..b6d64473e 100644 --- a/app/src/main/res/layout-land/welcome_wikipedia.xml +++ b/app/src/main/res/layout-land/welcome_wikipedia.xml @@ -8,7 +8,7 @@ android:paddingRight="@dimen/huge_gap"> diff --git a/app/src/main/res/layout-v21/drawer_view.xml b/app/src/main/res/layout-v21/drawer_view.xml index 1850f9a8e..952408da5 100644 --- a/app/src/main/res/layout-v21/drawer_view.xml +++ b/app/src/main/res/layout-v21/drawer_view.xml @@ -5,6 +5,6 @@ android:layout_width="wrap_content" android:layout_height="match_parent" android:layout_gravity="start" - android:elevation="2dp" + android:elevation="@dimen/miniscule_margin" app:headerLayout="@layout/drawer_header" app:menu="@menu/drawer" /> \ No newline at end of file diff --git a/app/src/main/res/layout-xlarge/activity_login.xml b/app/src/main/res/layout-xlarge/activity_login.xml index 0a445c80e..b491de5c2 100644 --- a/app/src/main/res/layout-xlarge/activity_login.xml +++ b/app/src/main/res/layout-xlarge/activity_login.xml @@ -10,7 +10,7 @@ android:orientation="vertical"> @@ -24,8 +24,8 @@ android:layout_marginRight="@dimen/standard_gap" android:layout_marginStart="@dimen/standard_gap" android:layout_marginTop="@dimen/large_gap" - app:cardCornerRadius="4dp" - app:cardElevation="4dp"> + app:cardCornerRadius="@dimen/tiny_margin" + app:cardElevation="@dimen/tiny_margin"> diff --git a/app/src/main/res/layout/activity_achievements.xml b/app/src/main/res/layout/activity_achievements.xml index b81831e96..01bc98bbd 100644 --- a/app/src/main/res/layout/activity_achievements.xml +++ b/app/src/main/res/layout/activity_achievements.xml @@ -110,32 +110,32 @@ android:text="@string/images_uploaded" /> + android:layout_marginLeft="@dimen/activity_margin_horizontal" + android:layout_marginStart="@dimen/activity_margin_horizontal"/> @@ -146,7 +146,7 @@ android:id="@+id/layout_image_reverts" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_marginTop="4dp" + android:layout_marginTop="@dimen/tiny_margin" android:layout_below="@+id/layout_image_uploaded" android:layout_marginEnd="@dimen/activity_margin_horizontal" android:layout_marginLeft="@dimen/activity_margin_horizontal" @@ -163,9 +163,9 @@ android:text="@string/image_reverts" /> + android:layout_marginLeft="@dimen/activity_margin_horizontal" + android:layout_marginStart="@dimen/activity_margin_horizontal"/> @@ -209,7 +209,7 @@ android:id="@+id/layout_image_used_by_wiki" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_marginTop="4dp" + android:layout_marginTop="@dimen/tiny_margin" android:layout_below="@+id/layout_image_reverts" android:layout_marginBottom="@dimen/activity_margin_vertical" android:layout_marginEnd="@dimen/activity_margin_horizontal" @@ -228,28 +228,28 @@ android:text="@string/images_used_by_wiki" /> + android:layout_marginLeft="@dimen/activity_margin_horizontal" + android:layout_marginStart="@dimen/activity_margin_horizontal"/> + android:layout_marginRight="@dimen/half_standard_height" /> @@ -389,10 +389,10 @@ android:text="@string/statistics_featured" /> + android:layout_marginEnd="@dimen/half_standard_height" + android:layout_marginRight="@dimen/half_standard_height" /> @@ -456,10 +456,10 @@ android:text="@string/statistics_thanks" /> + android:layout_marginEnd="@dimen/half_standard_height" + android:layout_marginRight="@dimen/half_standard_height" /> diff --git a/app/src/main/res/layout/activity_bookmarks.xml b/app/src/main/res/layout/activity_bookmarks.xml index 028c43c91..a52af68e1 100644 --- a/app/src/main/res/layout/activity_bookmarks.xml +++ b/app/src/main/res/layout/activity_bookmarks.xml @@ -24,8 +24,8 @@ + app:cardCornerRadius="@dimen/tiny_margin" + app:cardElevation="@dimen/tiny_margin"> diff --git a/app/src/main/res/layout/activity_notification.xml b/app/src/main/res/layout/activity_notification.xml index e6c07f8de..ccde97f83 100644 --- a/app/src/main/res/layout/activity_notification.xml +++ b/app/src/main/res/layout/activity_notification.xml @@ -41,8 +41,8 @@ + android:textSize="@dimen/subheading_text_size" /> diff --git a/app/src/main/res/layout/activity_quiz.xml b/app/src/main/res/layout/activity_quiz.xml index eeda3bf66..e27fcdc71 100644 --- a/app/src/main/res/layout/activity_quiz.xml +++ b/app/src/main/res/layout/activity_quiz.xml @@ -16,11 +16,11 @@ @@ -73,7 +73,7 @@