mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 12:23:58 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixes #3197 Replace hardcoded dimensions with dimen resource values (#3402)

Browse source
This commit is contained in:
Yash Khare 2020-02-12 09:56:33 +05:30 • committed by GitHub
parent 9b3f3e9d3c
commit 69e7161c61
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
125 changed files with 542 additions and 506 deletions
Download patch file Download diff file Expand all files Collapse all files

16
app/src/main/res/layout/layout_contribution.xml
View file

@ -5,8 +5,8 @@
android:orientation="vertical"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:padding="2dp"
android:paddingBottom="0dp">
android:padding="@dimen/miniscule_margin"
android:paddingBottom="@dimen/dimen_0">
<TextView
android:id="@+id/contributionSequenceNumber"
@ -21,7 +21,7 @@
<com.facebook.drawee.view.SimpleDraweeView
android:id="@+id/contributionImage"
android:layout_width="match_parent"
android:layout_height="240dp"
android:layout_height="@dimen/very_large_height"
app:actualImageScaleType="centerCrop"
fresco:placeholderImage="@drawable/ic_image_black_24dp"
/>
@ -35,7 +35,7 @@
>
<LinearLayout
android:layout_width="0dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="wrap_content"
android:layout_gravity="center|bottom"
android:orientation="vertical"
@ -75,7 +75,7 @@
<LinearLayout
android:id="@+id/failed_image_options"
android:layout_width="0dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="wrap_content"
android:orientation="horizontal"
android:layout_weight="2"
@ -90,8 +90,8 @@
android:src="@drawable/ic_cancel_white"
android:text="@string/menu_cancel_upload"
android:background="@android:color/transparent"
android:padding="8dp"
android:layout_marginRight="5dp"
android:padding="@dimen/activity_margin_horizontal"
android:layout_marginRight="@dimen/tiny_padding"
/>
<ImageButton
@ -101,7 +101,7 @@
android:src="@drawable/ic_retry_white"
android:text="@string/menu_retry_upload"
android:background="@android:color/transparent"
android:padding="8dp"
android:padding="@dimen/activity_margin_horizontal"
/>
</LinearLayout>