mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-29 13:53:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixes #3197 Replace hardcoded dimensions with dimen resource values (#3402)

Browse source
This commit is contained in:
Yash Khare 2020-02-12 09:56:33 +05:30 • committed by GitHub
parent 9b3f3e9d3c
commit 69e7161c61
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
125 changed files with 542 additions and 506 deletions
Download patch file Download diff file Expand all files Collapse all files

24
app/src/main/res/layout/item_notification.xml
View file

@ -5,15 +5,15 @@
xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/notification_view"
android:foreground="?selectableItemBackground"
android:minHeight="72dp">
android:minHeight="@dimen/large_height">
<androidx.appcompat.widget.AppCompatImageView
android:id="@+id/icon"
android:layout_width="40dp"
android:layout_height="40dp"
android:layout_marginLeft="16dp"
android:layout_marginStart="16dp"
android:layout_marginTop="16dp"
android:layout_width="@dimen/dimen_40"
android:layout_height="@dimen/dimen_40"
android:layout_marginLeft="@dimen/standard_gap"
android:layout_marginStart="@dimen/standard_gap"
android:layout_marginTop="@dimen/standard_gap"
android:scaleType="centerCrop"
app:srcCompat="@drawable/ic_message_black_24dp"
app:tint="@color/primaryDarkColor"
@ -25,9 +25,9 @@
android:layout_height="wrap_content"
android:layout_alignParentEnd="true"
android:layout_alignParentRight="true"
android:layout_marginLeft="16dp"
android:layout_marginRight="16dp"
android:layout_marginTop="16dp"
android:layout_marginLeft="@dimen/standard_gap"
android:layout_marginRight="@dimen/standard_gap"
android:layout_marginTop="@dimen/standard_gap"
android:textAppearance="@style/TextAppearance.AppCompat.Caption"
/>
@ -36,8 +36,8 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_alignTop="@id/time"
android:layout_marginLeft="16dp"
android:layout_marginStart="16dp"
android:layout_marginLeft="@dimen/standard_gap"
android:layout_marginStart="@dimen/standard_gap"
android:layout_toEndOf="@id/icon"
android:layout_toLeftOf="@id/time"
android:layout_toRightOf="@id/icon"
@ -45,6 +45,6 @@
android:ellipsize="end"
android:layout_alignParentTop="true"
android:textAppearance="@style/TextAppearance.AppCompat.Body2"
android:padding="12dp"
android:padding="@dimen/medium_height"
/>
</RelativeLayout>