mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-29 13:53:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixes #3197 Replace hardcoded dimensions with dimen resource values (#3402)

Browse source
This commit is contained in:
Yash Khare 2020-02-12 09:56:33 +05:30 • committed by GitHub
parent 9b3f3e9d3c
commit 69e7161c61
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
125 changed files with 542 additions and 506 deletions
Download patch file Download diff file Expand all files Collapse all files

16
app/src/main/res/layout/fragment_review_image.xml
View file

@ -3,7 +3,7 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
xmlns:tools="http://schemas.android.com/tools"
android:paddingBottom="10dp"
android:paddingBottom="@dimen/dimen_10"
android:orientation="vertical"
>
@ -15,7 +15,7 @@
<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:paddingTop="6dp"
android:paddingTop="@dimen/dimen_6"
android:orientation="vertical">
<TextView
@ -32,7 +32,7 @@
android:id="@+id/tv_review_question_context"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginBottom="15dp"
android:layout_marginBottom="@dimen/filter_padding"
android:gravity="center_vertical"
tools:text="testing2"
android:textAlignment="center"
@ -47,13 +47,13 @@
android:layout_height="70dp"
android:layout_alignParentBottom="true"
android:orientation="horizontal"
android:padding="2dp"
android:padding="@dimen/miniscule_margin"
android:weightSum="2">
<Button
android:id="@+id/button_yes"
android:layout_width="0dp"
android:layout_height="48dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="@dimen/fragment_height"
android:layout_weight="1"
android:layout_margin="@dimen/activity_margin_horizontal"
android:background="@android:color/transparent"
@ -67,8 +67,8 @@
<Button
android:textAllCaps="true"
android:id="@+id/button_no"
android:layout_width="0dp"
android:layout_height="48dp"
android:layout_width="@dimen/dimen_0"
android:layout_height="@dimen/fragment_height"
android:layout_weight="1"
android:enabled="false"
android:alpha="0.5"