Fixes #3197 Replace hardcoded dimensions with dimen resource values (#3402)

This commit is contained in:
Yash Khare 2020-02-12 09:56:33 +05:30 committed by GitHub
parent 9b3f3e9d3c
commit 69e7161c61
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
125 changed files with 542 additions and 506 deletions

View file

@ -3,7 +3,7 @@
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_marginBottom="8dp"
android:layout_marginBottom="@dimen/activity_margin_horizontal"
android:padding="@dimen/standard_gap"
>
<LinearLayout
@ -16,7 +16,7 @@
android:id="@+id/tv_title"
android:textStyle="bold"
android:layout_width="wrap_content"
android:layout_height="24dp"
android:layout_height="@dimen/half_standard_height"
android:layout_marginEnd="@dimen/standard_gap"
android:layout_marginRight="@dimen/standard_gap"
android:gravity="center_vertical"
@ -26,7 +26,7 @@
<TextView
android:id="@+id/tv_subtitle"
android:layout_width="wrap_content"
android:layout_height="24dp"
android:layout_height="@dimen/half_standard_height"
android:layout_marginTop="@dimen/tiny_gap"
android:gravity="center_vertical"
android:text="@string/upload_flow_all_images_in_set"
@ -38,7 +38,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/standard_gap"
android:padding="0dp"
android:padding="@dimen/dimen_0"
tools:visibility="visible"/>
<TextView
@ -68,14 +68,14 @@
<View
android:id="@+id/button_divider"
android:layout_width="match_parent"
android:layout_height="1dp"
android:layout_marginTop="16dp"
android:layout_height="@dimen/tiny_height"
android:layout_marginTop="@dimen/standard_gap"
android:background="@color/divider_grey"/>
<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:padding="16dp"
android:padding="@dimen/standard_gap"
android:orientation="horizontal"
>
<androidx.appcompat.widget.AppCompatButton