mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixes #3575 (#3602)

Browse source 
* Donot show random colors as placeholders for contributions items
* Theme contributionsItem background as mainBackground from attributes
This commit is contained in:
Ashish Kumar 2020-03-30 15:12:47 +05:30 • committed by GitHub
parent 3d1ffbb4bc
commit 6416314dda
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.java
View file

@ -50,8 +50,6 @@ public class ContributionViewHolder extends RecyclerView.ViewHolder {
public void init(int position, Contribution contribution) { public void init(int position, Contribution contribution) {
this.contribution = contribution; this.contribution = contribution;
this.position = position; this.position = position;
imageView.getHierarchy().setPlaceholderImage(new ColorDrawable(
Color.argb(100, random.nextInt(256), random.nextInt(256), random.nextInt(256))));
String imageSource = chooseImageSource(contribution.thumbUrl, contribution.getLocalUri()); String imageSource = chooseImageSource(contribution.thumbUrl, contribution.getLocalUri());
if (!TextUtils.isEmpty(imageSource)) { if (!TextUtils.isEmpty(imageSource)) {
final ImageRequest imageRequest = final ImageRequest imageRequest =

1
app/src/main/res/layout/layout_contribution.xml
View file

@ -23,6 +23,7 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="@dimen/very_large_height" android:layout_height="@dimen/very_large_height"
app:actualImageScaleType="centerCrop" app:actualImageScaleType="centerCrop"
android:background="?attr/mainBackground"
fresco:placeholderImage="@drawable/ic_image_black_24dp" fresco:placeholderImage="@drawable/ic_image_black_24dp"
/> />