From 6416314dda2a675ec3a2ea7be527df139d70d4f9 Mon Sep 17 00:00:00 2001 From: Ashish Kumar Date: Mon, 30 Mar 2020 15:12:47 +0530 Subject: [PATCH] Fixes #3575 (#3602) * Donot show random colors as placeholders for contributions items * Theme contributionsItem background as mainBackground from attributes --- .../free/nrw/commons/contributions/ContributionViewHolder.java | 2 -- app/src/main/res/layout/layout_contribution.xml | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.java index eae00b916..457c31fa5 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.java @@ -50,8 +50,6 @@ public class ContributionViewHolder extends RecyclerView.ViewHolder { public void init(int position, Contribution contribution) { this.contribution = contribution; this.position = position; - imageView.getHierarchy().setPlaceholderImage(new ColorDrawable( - Color.argb(100, random.nextInt(256), random.nextInt(256), random.nextInt(256)))); String imageSource = chooseImageSource(contribution.thumbUrl, contribution.getLocalUri()); if (!TextUtils.isEmpty(imageSource)) { final ImageRequest imageRequest = diff --git a/app/src/main/res/layout/layout_contribution.xml b/app/src/main/res/layout/layout_contribution.xml index 49d1cb8e5..ae92d7db0 100644 --- a/app/src/main/res/layout/layout_contribution.xml +++ b/app/src/main/res/layout/layout_contribution.xml @@ -23,6 +23,7 @@ android:layout_width="match_parent" android:layout_height="@dimen/very_large_height" app:actualImageScaleType="centerCrop" + android:background="?attr/mainBackground" fresco:placeholderImage="@drawable/ic_image_black_24dp" />