mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Find location to insert permission check

Browse source
This commit is contained in:
misaochan 2016-07-15 00:24:53 +12:00
parent 281012c6eb
commit 54428316a6
2 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java
View file

@ -85,7 +85,6 @@ public class ContributionController {
try { try {
activity.startActivity(shareIntent); activity.startActivity(shareIntent);
} catch (SecurityException e) { } catch (SecurityException e) {
//FIXME: Add permission request here. Only startActivity if permission has been granted.
Log.e("ContributionController", "Security Exception", e); Log.e("ContributionController", "Security Exception", e);
} }
} }

2
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java
View file

@ -94,6 +94,8 @@ public class ContributionsListFragment extends Fragment {
public boolean onOptionsItemSelected(MenuItem item) { public boolean onOptionsItemSelected(MenuItem item) {
switch(item.getItemId()) { switch(item.getItemId()) {
case R.id.menu_from_gallery: case R.id.menu_from_gallery:
//FIXME: Add permission request here. Only startActivity if permission has been granted
//Gallery crashes before reach ShareActivity screen so must implement check here
controller.startGalleryPick(); controller.startGalleryPick();
return true; return true;
case R.id.menu_from_camera: case R.id.menu_from_camera: