diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java index c62b74c56..58871d2cc 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java @@ -85,7 +85,6 @@ public class ContributionController { try { activity.startActivity(shareIntent); } catch (SecurityException e) { - //FIXME: Add permission request here. Only startActivity if permission has been granted. Log.e("ContributionController", "Security Exception", e); } } diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java index 7ebbc0201..eebf6dd6f 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java @@ -94,6 +94,8 @@ public class ContributionsListFragment extends Fragment { public boolean onOptionsItemSelected(MenuItem item) { switch(item.getItemId()) { case R.id.menu_from_gallery: + //FIXME: Add permission request here. Only startActivity if permission has been granted + //Gallery crashes before reach ShareActivity screen so must implement check here controller.startGalleryPick(); return true; case R.id.menu_from_camera: