mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #1211 from tshradheya/1195-give-toast-message

Browse source 
Give toast when trying to upload image without giving a Title #1195
This commit is contained in:
Vivek Maskara 2018-03-03 19:23:10 +05:30 • committed by GitHub
commit 4c3513b442
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java
View file

@ -28,6 +28,7 @@ import android.widget.Button;
import android.widget.EditText; import android.widget.EditText;
import android.widget.Spinner; import android.widget.Spinner;
import android.widget.TextView; import android.widget.TextView;
import android.widget.Toast;
import java.util.ArrayList; import java.util.ArrayList;
@ -65,9 +66,6 @@ public class SingleUploadFragment extends CommonsDaggerSupportFragment {
@Override @Override
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) { public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
inflater.inflate(R.menu.activity_share, menu); inflater.inflate(R.menu.activity_share, menu);
if (titleEdit != null) {
menu.findItem(R.id.menu_upload_single).setEnabled(titleEdit.getText().length() != 0);
}
} }
@Override @Override
@ -76,6 +74,11 @@ public class SingleUploadFragment extends CommonsDaggerSupportFragment {
//What happens when the 'submit' icon is tapped //What happens when the 'submit' icon is tapped
case R.id.menu_upload_single: case R.id.menu_upload_single:
if (titleEdit.getText().toString().isEmpty()) {
Toast.makeText(getContext(), R.string.add_title_toast, Toast.LENGTH_LONG).show();
return false;
}
String title = titleEdit.getText().toString(); String title = titleEdit.getText().toString();
String desc = descEdit.getText().toString(); String desc = descEdit.getText().toString();

2
app/src/main/res/menu/activity_share.xml
View file

@ -3,6 +3,6 @@
<item android:id="@+id/menu_upload_single" <item android:id="@+id/menu_upload_single"
android:title="@string/menu_upload_single" android:title="@string/menu_upload_single"
android:icon="@drawable/ic_send_white_24dp" android:icon="@drawable/ic_send_white_24dp"
android:enabled="false" android:enabled="true"
app:showAsAction="always" /> app:showAsAction="always" />
</menu> </menu>

1
app/src/main/res/values/strings.xml
View file

@ -38,6 +38,7 @@
<string name="menu_share">Share</string> <string name="menu_share">Share</string>
<string name="menu_open_in_browser">View in Browser</string> <string name="menu_open_in_browser">View in Browser</string>
<string name="share_title_hint">Title</string> <string name="share_title_hint">Title</string>
<string name="add_title_toast">Please give a Title to proceed</string>
<string name="share_description_hint">Description</string> <string name="share_description_hint">Description</string>
<string name="login_failed_network">Unable to login - network failure</string> <string name="login_failed_network">Unable to login - network failure</string>
<string name="login_failed_username">Unable to login - please check your username</string> <string name="login_failed_username">Unable to login - please check your username</string>