From 4037972e95ecfe990caf0d9c7e2c6480a4adde30 Mon Sep 17 00:00:00 2001 From: Shradheya Thakre Date: Mon, 26 Feb 2018 14:11:51 +0800 Subject: [PATCH 1/3] Added Toast message content --- app/src/main/res/values/strings.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 3c9c67947..bc6dfcee0 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -36,6 +36,7 @@ Share View in Browser Title + Please give a Title to proceed Description Unable to login - network failure Unable to login - please check your username From 8ce0a6d6d48fa2f5542ad52c7faab49ab8fd2257 Mon Sep 17 00:00:00 2001 From: Shradheya Thakre Date: Mon, 26 Feb 2018 14:12:49 +0800 Subject: [PATCH 2/3] Enables submit button by default --- app/src/main/res/menu/activity_share.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/res/menu/activity_share.xml b/app/src/main/res/menu/activity_share.xml index 67b23a77e..99290b787 100644 --- a/app/src/main/res/menu/activity_share.xml +++ b/app/src/main/res/menu/activity_share.xml @@ -3,6 +3,6 @@ From 6a052318780a9fb170a8bbe0aa05b79f3b5c01c8 Mon Sep 17 00:00:00 2001 From: Shradheya Thakre Date: Mon, 26 Feb 2018 14:13:31 +0800 Subject: [PATCH 3/3] Logic to show toast on click --- .../fr/free/nrw/commons/upload/SingleUploadFragment.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java b/app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java index be2401b5c..78e0bddc0 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java @@ -25,6 +25,7 @@ import android.widget.Button; import android.widget.EditText; import android.widget.Spinner; import android.widget.TextView; +import android.widget.Toast; import java.util.ArrayList; @@ -62,9 +63,6 @@ public class SingleUploadFragment extends CommonsDaggerSupportFragment { @Override public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) { inflater.inflate(R.menu.activity_share, menu); - if (titleEdit != null) { - menu.findItem(R.id.menu_upload_single).setEnabled(titleEdit.getText().length() != 0); - } } @Override @@ -73,6 +71,11 @@ public class SingleUploadFragment extends CommonsDaggerSupportFragment { //What happens when the 'submit' icon is tapped case R.id.menu_upload_single: + if (titleEdit.getText().toString().isEmpty()) { + Toast.makeText(getContext(), R.string.add_title_toast, Toast.LENGTH_LONG).show(); + return false; + } + String title = titleEdit.getText().toString(); String desc = descEdit.getText().toString();