mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

review: show author name in the Thanks toast

Browse source 
The thank would be sent to a particular user in the context of their
contribution. So, the user's name is also an important information
to be shown.

Highlight the same in the toast.
This commit is contained in:
Kaartic Sivaraam 2023-04-16 22:55:08 +05:30
parent 013809f46a
commit 2c17853dad
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/fr/free/nrw/commons/review/ReviewController.java
View file

@ -146,7 +146,7 @@ public class ReviewController {
.getInstance(context) .getInstance(context)
.getCommonsApplicationComponent() .getCommonsApplicationComponent()
.inject(this); .inject(this);
ViewUtil.showShortToast(context, context.getString(R.string.send_thank_toast, media.getDisplayTitle())); ViewUtil.showShortToast(context, context.getString(R.string.send_thank_toast, media.getAuthor(), media.getDisplayTitle()));
if (firstRevision == null) { if (firstRevision == null) {
return; return;
@ -166,7 +166,7 @@ public class ReviewController {
final String title; final String title;
if (result) { if (result) {
title = context.getString(R.string.send_thank_success_title); title = context.getString(R.string.send_thank_success_title);
message = context.getString(R.string.send_thank_success_message, media.getDisplayTitle()); message = context.getString(R.string.send_thank_success_message, media.getAuthor(), media.getDisplayTitle());
} else { } else {
title = context.getString(R.string.send_thank_failure_title); title = context.getString(R.string.send_thank_failure_title);
message = context.getString(R.string.send_thank_failure_message, media.getDisplayTitle()); message = context.getString(R.string.send_thank_failure_message, media.getDisplayTitle());

4
app/src/main/res/values/strings.xml
View file

@ -455,11 +455,11 @@ Upload your first media by tapping on the add button.</string>
<string name="check_category_toast">Requesting category check for %1$s</string> <string name="check_category_toast">Requesting category check for %1$s</string>
<string name="nominate_for_deletion_done">Done</string> <string name="nominate_for_deletion_done">Done</string>
<string name="send_thank_success_title">Sending Thanks: Success</string> <string name="send_thank_success_title">Sending Thanks: Success</string>
<string name="send_thank_success_message">Successfully sent thanks to %1$s</string> <string name="send_thank_success_message">Successfully sent thanks to %1$s for %2$s</string>
<string name="send_thank_failure_message">Failed to send thanks %1$s</string> <string name="send_thank_failure_message">Failed to send thanks %1$s</string>
<string name="send_thank_failure_title">Sending Thanks: Failure</string> <string name="send_thank_failure_title">Sending Thanks: Failure</string>
<string name="send_thank_toast">Sending Thanks for %1$s</string> <string name="send_thank_toast">Sending thanks to %1$s for %2$s</string>
<string name="review_copyright">Does this follow the rules of copyright?</string> <string name="review_copyright">Does this follow the rules of copyright?</string>
<string name="review_category">Is this correctly categorized?</string> <string name="review_category">Is this correctly categorized?</string>
<string name="review_spam">Is this in-scope?</string> <string name="review_spam">Is this in-scope?</string>