From 2c17853dadb5a42a153261424363d70334e55491 Mon Sep 17 00:00:00 2001 From: Kaartic Sivaraam Date: Sun, 16 Apr 2023 22:55:08 +0530 Subject: [PATCH] review: show author name in the Thanks toast The thank would be sent to a particular user in the context of their contribution. So, the user's name is also an important information to be shown. Highlight the same in the toast. --- .../java/fr/free/nrw/commons/review/ReviewController.java | 4 ++-- app/src/main/res/values/strings.xml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/review/ReviewController.java b/app/src/main/java/fr/free/nrw/commons/review/ReviewController.java index 1efef7aa8..34abee429 100644 --- a/app/src/main/java/fr/free/nrw/commons/review/ReviewController.java +++ b/app/src/main/java/fr/free/nrw/commons/review/ReviewController.java @@ -146,7 +146,7 @@ public class ReviewController { .getInstance(context) .getCommonsApplicationComponent() .inject(this); - ViewUtil.showShortToast(context, context.getString(R.string.send_thank_toast, media.getDisplayTitle())); + ViewUtil.showShortToast(context, context.getString(R.string.send_thank_toast, media.getAuthor(), media.getDisplayTitle())); if (firstRevision == null) { return; @@ -166,7 +166,7 @@ public class ReviewController { final String title; if (result) { title = context.getString(R.string.send_thank_success_title); - message = context.getString(R.string.send_thank_success_message, media.getDisplayTitle()); + message = context.getString(R.string.send_thank_success_message, media.getAuthor(), media.getDisplayTitle()); } else { title = context.getString(R.string.send_thank_failure_title); message = context.getString(R.string.send_thank_failure_message, media.getDisplayTitle()); diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 1dd7c149b..a116ea233 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -455,11 +455,11 @@ Upload your first media by tapping on the add button. Requesting category check for %1$s Done Sending Thanks: Success - Successfully sent thanks to %1$s + Successfully sent thanks to %1$s for %2$s Failed to send thanks %1$s Sending Thanks: Failure - Sending Thanks for %1$s + Sending thanks to %1$s for %2$s Does this follow the rules of copyright? Is this correctly categorized? Is this in-scope?