mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix NullPointer when clicking on image in MediaDetailFragment (#3730) (#3738)

Browse source 
Uri.parse would throw NullPointerException if the image in MediaDetailFragment was clicked before the image URL is available
This commit is contained in:
Vaibhav 2020-05-08 09:37:00 +05:30 • committed by GitHub
parent dc6a3e507b
commit 11ff5fb055
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java
View file

@ -222,10 +222,12 @@ public class MediaDetailFragment extends CommonsDaggerSupportFragment {
@OnClick(R.id.mediaDetailImageViewSpacer) @OnClick(R.id.mediaDetailImageViewSpacer)
public void launchZoomActivity(View view) { public void launchZoomActivity(View view) {
Context ctx = view.getContext(); if (media.getImageUrl() != null) {
ctx.startActivity( Context ctx = view.getContext();
new Intent(ctx,ZoomableActivity.class).setData(Uri.parse(media.getImageUrl())) ctx.startActivity(
); new Intent(ctx, ZoomableActivity.class).setData(Uri.parse(media.getImageUrl()))
);
}
} }
@Override @Override