From 11ff5fb055dca0a059b621ad3521071b0375c37f Mon Sep 17 00:00:00 2001 From: Vaibhav Date: Fri, 8 May 2020 09:37:00 +0530 Subject: [PATCH] Fix NullPointer when clicking on image in MediaDetailFragment (#3730) (#3738) Uri.parse would throw NullPointerException if the image in MediaDetailFragment was clicked before the image URL is available --- .../fr/free/nrw/commons/media/MediaDetailFragment.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java index a3e22f3b7..2e4d1cde3 100644 --- a/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java @@ -222,10 +222,12 @@ public class MediaDetailFragment extends CommonsDaggerSupportFragment { @OnClick(R.id.mediaDetailImageViewSpacer) public void launchZoomActivity(View view) { - Context ctx = view.getContext(); - ctx.startActivity( - new Intent(ctx,ZoomableActivity.class).setData(Uri.parse(media.getImageUrl())) - ); + if (media.getImageUrl() != null) { + Context ctx = view.getContext(); + ctx.startActivity( + new Intent(ctx, ZoomableActivity.class).setData(Uri.parse(media.getImageUrl())) + ); + } } @Override