mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Extract hardcoded strings to make them localizable

Browse source
This commit is contained in:
Mikel 2017-07-15 09:20:36 +02:00
parent 0da51457d0
commit 0b901deb01
2 changed files with 15 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

19
app/src/main/res/layout/fragment_media_detail.xml
View file

@ -1,6 +1,7 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android" <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:orientation="vertical" android:orientation="vertical"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"
@ -130,26 +131,29 @@
android:background="?attr/subBackground" android:background="?attr/subBackground"
android:padding="16dp" android:padding="16dp"
> >
<TextView <TextView
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:text="@string/media_detail_license"
android:textColor="@android:color/white" android:textColor="@android:color/white"
android:text="License"
android:textSize="16sp" android:textSize="16sp"
android:textStyle="bold" android:textStyle="bold"
android:paddingBottom="6dp" android:paddingBottom="6dp"
/> />
<TextView <TextView
android:id="@+id/mediaDetailLicense"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:text="License link"
android:id="@+id/mediaDetailLicense"
android:layout_gravity="left|start" android:layout_gravity="left|start"
android:background="?attr/subBackground" android:background="?attr/subBackground"
android:foreground="?attr/selectableItemBackground"
android:text="@string/media_detail_license"
android:textColor="@android:color/white" android:textColor="@android:color/white"
android:textSize="14sp" android:textSize="14sp"
android:padding="12dp" android:padding="12dp"
/> tools:text="License link" />
</LinearLayout> </LinearLayout>
<LinearLayout <LinearLayout
@ -163,7 +167,7 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:textColor="@android:color/white" android:textColor="@android:color/white"
android:text="Coordinates" android:text="@string/media_detail_coordinates"
android:textSize="16sp" android:textSize="16sp"
android:textStyle="bold" android:textStyle="bold"
android:paddingBottom="6dp" android:paddingBottom="6dp"
@ -171,13 +175,14 @@
<TextView <TextView
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:text="License link" android:text="@string/media_detail_coordinates"
android:id="@+id/mediaDetailCoordinates" android:id="@+id/mediaDetailCoordinates"
android:layout_gravity="left|start" android:layout_gravity="start"
android:background="?attr/subBackground" android:background="?attr/subBackground"
android:textColor="@android:color/white" android:textColor="@android:color/white"
android:textSize="14sp" android:textSize="14sp"
android:padding="12dp" android:padding="12dp"
tools:text="Coordinates link"
/> />
</LinearLayout> </LinearLayout>

4
app/src/main/res/values/strings.xml
View file

@ -152,7 +152,9 @@ Tap this message (or hit back) to skip this step.</string>
<string name="media_detail_media_title">Title of the media</string> <string name="media_detail_media_title">Title of the media</string>
<string name="media_detail_description">Description</string> <string name="media_detail_description">Description</string>
<string name="media_detail_description_explanation">Description of the media goes here. This can potentially be fairly long, and will need to wrap across multiple lines. We hope it looks nice though.</string> <string name="media_detail_description_explanation">Description of the media goes here. This can potentially be fairly long, and will need to wrap across multiple lines. We hope it looks nice though.</string>
<string name="media_detail_uploaded_date">Uploaded date</string>> <string name="media_detail_uploaded_date">Uploaded date</string>
<string name="media_detail_license">License</string>
<string name="media_detail_coordinates">Coordinates</string>
<string name="become_a_tester_title">Become a Beta Tester</string> <string name="become_a_tester_title">Become a Beta Tester</string>
<string name="become_a_tester_description">Opt-in to our beta channel on Google Play and get early access to new features and bug fixes</string> <string name="become_a_tester_description">Opt-in to our beta channel on Google Play and get early access to new features and bug fixes</string>
<string name="beta_opt_in_link">https://play.google.com/apps/testing/fr.free.nrw.commons</string> <string name="beta_opt_in_link">https://play.google.com/apps/testing/fr.free.nrw.commons</string>