From 0b901deb01a6942d735a38136968bcd1bc29bbbf Mon Sep 17 00:00:00 2001
From: Mikel <mikel.paskual@gmail.com>
Date: Sat, 15 Jul 2017 09:20:36 +0200
Subject: [PATCH] Extract hardcoded strings to make them localizable

---
 .../main/res/layout/fragment_media_detail.xml | 19 ++++++++++++-------
 app/src/main/res/values/strings.xml           |  4 +++-
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/app/src/main/res/layout/fragment_media_detail.xml b/app/src/main/res/layout/fragment_media_detail.xml
index 8cfa45d17..cf031990f 100644
--- a/app/src/main/res/layout/fragment_media_detail.xml
+++ b/app/src/main/res/layout/fragment_media_detail.xml
@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
+    xmlns:tools="http://schemas.android.com/tools"
     android:orientation="vertical"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
@@ -130,26 +131,29 @@
                     android:background="?attr/subBackground"
                     android:padding="16dp"
                     >
+
                     <TextView
                         android:layout_width="match_parent"
                         android:layout_height="wrap_content"
+                        android:text="@string/media_detail_license"
                         android:textColor="@android:color/white"
-                        android:text="License"
                         android:textSize="16sp"
                         android:textStyle="bold"
                         android:paddingBottom="6dp"
                         />
+
                     <TextView
+                        android:id="@+id/mediaDetailLicense"
                         android:layout_width="match_parent"
                         android:layout_height="wrap_content"
-                        android:text="License link"
-                        android:id="@+id/mediaDetailLicense"
                         android:layout_gravity="left|start"
                         android:background="?attr/subBackground"
+                        android:foreground="?attr/selectableItemBackground"
+                        android:text="@string/media_detail_license"
                         android:textColor="@android:color/white"
                         android:textSize="14sp"
                         android:padding="12dp"
-                        />
+                        tools:text="License link" />
                 </LinearLayout>
 
                 <LinearLayout
@@ -163,7 +167,7 @@
                         android:layout_width="match_parent"
                         android:layout_height="wrap_content"
                         android:textColor="@android:color/white"
-                        android:text="Coordinates"
+                        android:text="@string/media_detail_coordinates"
                         android:textSize="16sp"
                         android:textStyle="bold"
                         android:paddingBottom="6dp"
@@ -171,13 +175,14 @@
                     <TextView
                         android:layout_width="match_parent"
                         android:layout_height="wrap_content"
-                        android:text="License link"
+                        android:text="@string/media_detail_coordinates"
                         android:id="@+id/mediaDetailCoordinates"
-                        android:layout_gravity="left|start"
+                        android:layout_gravity="start"
                         android:background="?attr/subBackground"
                         android:textColor="@android:color/white"
                         android:textSize="14sp"
                         android:padding="12dp"
+                        tools:text="Coordinates link"
                         />
                 </LinearLayout>
 
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index d1867f3f8..722939204 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -152,7 +152,9 @@ Tap this message (or hit back) to skip this step.</string>
   <string name="media_detail_media_title">Title of the media</string>
   <string name="media_detail_description">Description</string>
   <string name="media_detail_description_explanation">Description of the media goes here. This can potentially be fairly long, and will need to wrap across multiple lines. We hope it looks nice though.</string>
-  <string name="media_detail_uploaded_date">Uploaded date</string>>
+  <string name="media_detail_uploaded_date">Uploaded date</string>
+  <string name="media_detail_license">License</string>
+  <string name="media_detail_coordinates">Coordinates</string>
   <string name="become_a_tester_title">Become a Beta Tester</string>
   <string name="become_a_tester_description">Opt-in to our beta channel on Google Play and get early access to new features and bug fixes</string>
   <string name="beta_opt_in_link">https://play.google.com/apps/testing/fr.free.nrw.commons</string>