From 2bd4181c52649484e10fa5b39f4996a27eaa8d4b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=E2=84=93e=20Hensel?= Date: Wed, 10 Sep 2025 02:25:13 +1000 Subject: [PATCH 01/13] Add icon for `tower:construction=dish` (#1716) --- data/fields/tower/construction.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/data/fields/tower/construction.json b/data/fields/tower/construction.json index 3c36b99b..e4bd6665 100644 --- a/data/fields/tower/construction.json +++ b/data/fields/tower/construction.json @@ -7,6 +7,7 @@ "freestanding": "roentgen-tube", "guyed_lattice": "roentgen-lattice_guyed", "guyed_tube": "roentgen-tube_guyed", - "lattice": "roentgen-lattice" + "lattice": "roentgen-lattice", + "dish": "fas-satellite-dish" } } From 188a1a1d9f6d149aee05fa4ff2ce28ecce5ed4eb Mon Sep 17 00:00:00 2001 From: Cedric Date: Sun, 14 Sep 2025 17:23:22 +0200 Subject: [PATCH 02/13] Add `groundwater` option to `water_source` field (#1561) --- data/fields/water_source.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/data/fields/water_source.json b/data/fields/water_source.json index cea55812..b0da623c 100644 --- a/data/fields/water_source.json +++ b/data/fields/water_source.json @@ -8,7 +8,8 @@ "water_tank": "Water Tank", "pond": "Pond", "river": "River", - "stream": "Stream" + "stream": "Stream", + "groundwater": "Groundwater" } } } From 4402ffa9b2a97d26c83f2b4e4531d4e4ae4be0b8 Mon Sep 17 00:00:00 2001 From: Dimitar <19364673+Dimitar5555@users.noreply.github.com> Date: Sun, 14 Sep 2025 18:58:31 +0300 Subject: [PATCH 03/13] Add option strings for `house=*` field and disable Taginfo suggestions (#1412) --- data/fields/house.json | 35 ++++++++++++++++++- data/presets/building/house.json | 4 +-- data/presets/building/house/_detached.json | 4 +++ .../building/house/_semi-detached.json | 4 +++ data/presets/building/house/_terrace.json | 4 +++ data/presets/building/house/terraced.json | 4 +++ 6 files changed, 52 insertions(+), 3 deletions(-) diff --git a/data/fields/house.json b/data/fields/house.json index 4507d5e2..e7fc4f6b 100644 --- a/data/fields/house.json +++ b/data/fields/house.json @@ -1,5 +1,38 @@ { "key": "house", "type": "combo", - "label": "House Type" + "label": "House Type", + "strings": { + "options": { + "bungalow": { + "title": "Bungalow", + "description": "A small house with a single storey" + }, + "detached": { + "title": "Detached House", + "description": "A house that is not connected to any other houses" + }, + "link-detached": { + "title": "Link-Detached House", + "description": "A house that is connected to another house by a garage or other non-living area" + }, + "maisonette": { + "title": "Maisonette", + "description": "A residential dwelling, split over two floors with private external entrances rather than a communal entrance" + }, + "semi-detached": { + "title": "Semi-Detached House", + "description": "A house that is attached to another house on one side" + }, + "terrace": { + "title": "Row of Townhouses", + "description": "A row of houses that are attached to each other in a line (mapping each house as a separate area is preferred)" + }, + "terraced": { + "title": "Single Townhouse", + "description": "Individual house in a row of townhouses" + } + } + }, + "autoSuggestions": false } diff --git a/data/presets/building/house.json b/data/presets/building/house.json index 87c937de..d2a05461 100644 --- a/data/presets/building/house.json +++ b/data/presets/building/house.json @@ -4,8 +4,8 @@ "area" ], "fields": [ - "{building}", - "house" + "house", + "{building}" ], "tags": { "building": "house" diff --git a/data/presets/building/house/_detached.json b/data/presets/building/house/_detached.json index b20361cb..9f751ef9 100644 --- a/data/presets/building/house/_detached.json +++ b/data/presets/building/house/_detached.json @@ -3,6 +3,10 @@ "geometry": [ "area" ], + "fields": [ + "house", + "{building}" + ], "tags": { "building": "house", "house": "detached" diff --git a/data/presets/building/house/_semi-detached.json b/data/presets/building/house/_semi-detached.json index 57ada385..4bd07c02 100644 --- a/data/presets/building/house/_semi-detached.json +++ b/data/presets/building/house/_semi-detached.json @@ -3,6 +3,10 @@ "geometry": [ "area" ], + "fields": [ + "house", + "{building}" + ], "tags": { "building": "house", "house": "semi-detached" diff --git a/data/presets/building/house/_terrace.json b/data/presets/building/house/_terrace.json index 753c8714..53fb7947 100644 --- a/data/presets/building/house/_terrace.json +++ b/data/presets/building/house/_terrace.json @@ -3,6 +3,10 @@ "geometry": [ "area" ], + "fields": [ + "house", + "{building}" + ], "tags": { "building": "house", "house": "terrace" diff --git a/data/presets/building/house/terraced.json b/data/presets/building/house/terraced.json index e99640b4..6627f68e 100644 --- a/data/presets/building/house/terraced.json +++ b/data/presets/building/house/terraced.json @@ -3,6 +3,10 @@ "geometry": [ "area" ], + "fields": [ + "house", + "{building}" + ], "tags": { "building": "house", "house": "terraced" From 0a199617e0485c9667a33386daf730429b65ce6a Mon Sep 17 00:00:00 2001 From: Youssef Ahmed Hassan Elzedy <39376520+youssefelzedy@users.noreply.github.com> Date: Mon, 15 Sep 2025 08:38:39 +0300 Subject: [PATCH 04/13] Change the placeholder to a country code that no other country uses. (#1491) Co-authored-by: Vectorial1024 --- data/fields/phone.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/fields/phone.json b/data/fields/phone.json index c05c1223..70b17ee2 100644 --- a/data/fields/phone.json +++ b/data/fields/phone.json @@ -6,7 +6,7 @@ ], "type": "tel", "label": "Telephone", - "placeholder": "+31 42 123 4567", + "placeholder": "+000 0000 0000 0000", "terms": [ "phone number" ] From 81595e261e107e1e3cec07ee4834c118a2086f35 Mon Sep 17 00:00:00 2001 From: Dimitar <19364673+Dimitar5555@users.noreply.github.com> Date: Mon, 15 Sep 2025 08:41:19 +0300 Subject: [PATCH 05/13] Add term "street fitness" for `leisure=fitness_station` preset (#1660) --- data/presets/leisure/fitness_station.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/data/presets/leisure/fitness_station.json b/data/presets/leisure/fitness_station.json index 214f07a1..fb125c8b 100644 --- a/data/presets/leisure/fitness_station.json +++ b/data/presets/leisure/fitness_station.json @@ -28,7 +28,8 @@ "terms": [ "exercise", "fitness", - "gym" + "gym", + "street fitness" ], "aliases": [ "Calisthenics Park", From 6a671b7f77d34f4b7c86a1f3f3927c205d074b88 Mon Sep 17 00:00:00 2001 From: kjonosm <51236777+kjonosm@users.noreply.github.com> Date: Mon, 15 Sep 2025 07:42:00 +0200 Subject: [PATCH 06/13] Add `inscription` field to `tourism=artwork` (#1664) --- data/presets/tourism/artwork.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/data/presets/tourism/artwork.json b/data/presets/tourism/artwork.json index 0335051c..b073a90a 100644 --- a/data/presets/tourism/artwork.json +++ b/data/presets/tourism/artwork.json @@ -8,7 +8,8 @@ "moreFields": [ "level", "material", - "subject/wikidata" + "subject/wikidata", + "inscription" ], "geometry": [ "point", From 5860a04c264c4340cf8f715e4ac0b2852a3b2553 Mon Sep 17 00:00:00 2001 From: Tobias Date: Tue, 16 Sep 2025 12:19:37 +0200 Subject: [PATCH 07/13] Remove redundant `internet_access` from preset `aerodrome` (#1676) --- data/presets/aeroway/aerodrome.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/data/presets/aeroway/aerodrome.json b/data/presets/aeroway/aerodrome.json index b35f01ae..ecf41923 100644 --- a/data/presets/aeroway/aerodrome.json +++ b/data/presets/aeroway/aerodrome.json @@ -6,8 +6,7 @@ "icao", "address", "operator", - "operator/type", - "{@templates/internet_access}" + "operator/type" ], "moreFields": [ "{@templates/contact}", From cea8c7e69013f37c6bcae0f25f1a95a1048627e5 Mon Sep 17 00:00:00 2001 From: Tobias Date: Tue, 16 Sep 2025 12:22:43 +0200 Subject: [PATCH 08/13] Add option `container` to `building` field (#1524) --- data/fields/building.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/data/fields/building.json b/data/fields/building.json index 1ef7e2d6..f688eb50 100644 --- a/data/fields/building.json +++ b/data/fields/building.json @@ -63,7 +63,8 @@ "train_station": "Train Station Building", "transportation": "Transportation Building", "university": "University Building", - "warehouse": "Warehouse" + "warehouse": "Warehouse", + "container": "Container" } }, "terms": [ From de448020e0bc6dd21ac9e943a2707e1448fd241b Mon Sep 17 00:00:00 2001 From: Tobias Date: Tue, 16 Sep 2025 12:24:08 +0200 Subject: [PATCH 09/13] Docs: change wording from "Data item" to "OSM Wiki data item" (#1506) --- CONTRIBUTING.md | 4 ++-- GUIDELINES.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 98aa33d3..457189bb 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -50,10 +50,10 @@ Icons from different sources (_icon sets_) can be used in the tagging schema. He ### Info-`i` -![Screenshot of a preset in iD with the information details open.](https://github.com/openstreetmap/id-tagging-schema/assets/111561/13549318-cd7c-4dd1-9948-7a2d84662f04) +Screenshot of a preset in iD with the information details open. iD and other tools provide users with a way to learn more about the main tag of a preset. It is important to provide good information in this information panel. Here are a few notes on how to do this: -- Does your tag have a Wikibase entry? Click the small pencil icon next to the text to open the Wikibase item on the OSM wiki. Improve this wording if needed. If the Wikibase item is missing, [learn more about how to add it in "Current methods for creating new items"](https://wiki.openstreetmap.org/wiki/Data_items#Item_creation_process). +- Does your tag have a OSM Wiki data item? Click the small pencil icon next to the text to open the data item on the OSM Wiki. Improve this wording if needed. If the data item is missing, [learn more about how to add it in "Current methods for creating new items"](https://wiki.openstreetmap.org/wiki/Data_items#Item_creation_process). - Does your tag have a Wiki page with a good image? - Your preset might need [a `reference` property](https://github.com/ideditor/schema-builder?tab=readme-ov-file#reference) to force the system to use a specific tag for the information section. diff --git a/GUIDELINES.md b/GUIDELINES.md index f9a25451..1d652739 100644 --- a/GUIDELINES.md +++ b/GUIDELINES.md @@ -49,7 +49,7 @@ In addition, the deprecated tag must have reasonably high usage to be considered Deprecation rules work such that the user sees a message with suggestions and can act only when editing the given element. This makes them well-suited for gradual, human-reviewed updates of taggings like crossings. However, they are not suitable for cleaning up incorrect tagging from the database, especially for low-volume changes. -There are, however, alternatives to consider: +There are, however, alternatives to consider: - Your cleanup task might be eligible for an automated (bot) edit. [Please learn more on the wiki…](https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct) - If your task is small enough, a few [editing sessions in JOSM](https://wiki.openstreetmap.org/wiki/JOSM) will often do the trick. However, mass-replacing without checking each object is still considered an automated edit, so the [guidelines apply](https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct). Please consult other mappers first. - A good way to work down a list of tasks is to create [a MapRoulette Challenge](https://maproulette.org/). @@ -65,7 +65,7 @@ The user interface must be clear, concise, and easy to use, leaving no room for - Check the search functionality to ensure other presets do not cause confusion. - Select an icon or start the process to create a new one. - Define which fields to show (`fields`) and suggest (`moreFields`), considering the order of fields. -- Check the `(i)` documentation and add or update the [OSM Wikibase item](https://wiki.openstreetmap.org/wiki/Data_items) if needed to provide a helpful short text. +- Check the [`(i)` documentation](./CONTRIBUTING.md#info-i) and add or update the OSM Wiki data item if needed to provide a helpful short text. - Use the PR preview to add test cases with deep links to OSM objects that demonstrate the preset in use. ## 3. Implement From d219b376cd92d4b0302dafa7f87216b9f1d3e6ac Mon Sep 17 00:00:00 2001 From: Martin Raifer Date: Tue, 16 Sep 2025 12:26:49 +0200 Subject: [PATCH 10/13] more strictly match historic=building preset (#1677) --- data/presets/historic/building.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/data/presets/historic/building.json b/data/presets/historic/building.json index 482e5d5d..e5070c7a 100644 --- a/data/presets/historic/building.json +++ b/data/presets/historic/building.json @@ -12,9 +12,6 @@ "area" ], "tags": { - "historic": "building" - }, - "addTags": { "historic": "building", "building": "*" }, From c202e6046cdc5f350310ea7ee335ca02f1646fcd Mon Sep 17 00:00:00 2001 From: UKChris-osm <59393694+UKChris-osm@users.noreply.github.com> Date: Tue, 16 Sep 2025 11:32:12 +0100 Subject: [PATCH 11/13] Preset: shop=mobile_phone_accessories (#1406) --- data/presets/shop/mobile_phone_accessories.json | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 data/presets/shop/mobile_phone_accessories.json diff --git a/data/presets/shop/mobile_phone_accessories.json b/data/presets/shop/mobile_phone_accessories.json new file mode 100644 index 00000000..6a580490 --- /dev/null +++ b/data/presets/shop/mobile_phone_accessories.json @@ -0,0 +1,14 @@ +{ + "icon": "fas-mobile-screen", + "geometry": [ + "point", + "area" + ], + "tags": { + "shop": "mobile_phone_accessories" + }, + "terms": [ + "phone case" + ], + "name": "Mobile Phone Accessory Store" +} From 449fae43042dffe49fb3d189de066e74a68717c8 Mon Sep 17 00:00:00 2001 From: Tobias Date: Tue, 16 Sep 2025 12:34:56 +0200 Subject: [PATCH 12/13] CI: Configure dependabot to also update package.json (#1255) --- .github/dependabot.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index c5b6b65b..d0faeb1f 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -9,3 +9,4 @@ updates: directory: "/" schedule: interval: "daily" + versioning-strategy: increase-if-necessary From 37251709d2ef19a4030f111e89f1ef69e80df0f0 Mon Sep 17 00:00:00 2001 From: Kyle Hensel Date: Tue, 9 Sep 2025 21:23:56 +1000 Subject: [PATCH 13/13] create preset for 'Offshore Platform' --- data/fields/seamark/platform/category.json | 14 ++++++++ data/fields/seamark/radio_station/mmsi.json | 7 ++++ data/presets/seamark/offshore_platform.json | 40 +++++++++++++++++++++ 3 files changed, 61 insertions(+) create mode 100644 data/fields/seamark/platform/category.json create mode 100644 data/fields/seamark/radio_station/mmsi.json create mode 100644 data/presets/seamark/offshore_platform.json diff --git a/data/fields/seamark/platform/category.json b/data/fields/seamark/platform/category.json new file mode 100644 index 00000000..1c171fec --- /dev/null +++ b/data/fields/seamark/platform/category.json @@ -0,0 +1,14 @@ +{ + "key": "seamark:platform:category", + "type": "combo", + "label": "Category", + "strings": { + "options": { + "oil": "Oil Rig", + "production": "Production Platform", + "observation": "Observation/research platform", + "fpso": "FPSO: Floating production, storage and off-loading vessel", + "accommodation": "Accommodation Platform" + } + } +} diff --git a/data/fields/seamark/radio_station/mmsi.json b/data/fields/seamark/radio_station/mmsi.json new file mode 100644 index 00000000..be31217c --- /dev/null +++ b/data/fields/seamark/radio_station/mmsi.json @@ -0,0 +1,7 @@ +{ + "key": "seamark:radio_station:mmsi", + "type": "identifier", + "urlFormat": "https://www.vesselfinder.com/vessels/details/{value}", + "pattern": "^[0-9]{1,}$", + "label": "MMSI" +} diff --git a/data/presets/seamark/offshore_platform.json b/data/presets/seamark/offshore_platform.json new file mode 100644 index 00000000..592f7fa3 --- /dev/null +++ b/data/presets/seamark/offshore_platform.json @@ -0,0 +1,40 @@ +{ + "icon": "maki-harbor", + "fields": [ + "name", + "seamark/platform/category", + "seamark/radio_station/mmsi" + ], + "geometry": [ + "point", + "vertex", + "area" + ], + "tags": { + "seamark:type": "platform" + }, + "addTags": { + "seamark:type": "platform", + "man_made": "offshore_platform" + }, + "removeTags": { + "seamark:type": "*", + "man_made": "offshore_platform" + }, + "terms": [ + "bore", + "drilling rig", + "drilling rig", + "offshore platform", + "oil derrick", + "oil drill", + "oil horse", + "oil pump", + "oil rig", + "oil rig", + "petroleum well", + "platform", + "pumpjack" + ], + "name": "Offshore Platform" +}