From 5860a04c264c4340cf8f715e4ac0b2852a3b2553 Mon Sep 17 00:00:00 2001 From: Tobias Date: Tue, 16 Sep 2025 12:19:37 +0200 Subject: [PATCH 1/6] Remove redundant `internet_access` from preset `aerodrome` (#1676) --- data/presets/aeroway/aerodrome.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/data/presets/aeroway/aerodrome.json b/data/presets/aeroway/aerodrome.json index b35f01ae..ecf41923 100644 --- a/data/presets/aeroway/aerodrome.json +++ b/data/presets/aeroway/aerodrome.json @@ -6,8 +6,7 @@ "icao", "address", "operator", - "operator/type", - "{@templates/internet_access}" + "operator/type" ], "moreFields": [ "{@templates/contact}", From cea8c7e69013f37c6bcae0f25f1a95a1048627e5 Mon Sep 17 00:00:00 2001 From: Tobias Date: Tue, 16 Sep 2025 12:22:43 +0200 Subject: [PATCH 2/6] Add option `container` to `building` field (#1524) --- data/fields/building.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/data/fields/building.json b/data/fields/building.json index 1ef7e2d6..f688eb50 100644 --- a/data/fields/building.json +++ b/data/fields/building.json @@ -63,7 +63,8 @@ "train_station": "Train Station Building", "transportation": "Transportation Building", "university": "University Building", - "warehouse": "Warehouse" + "warehouse": "Warehouse", + "container": "Container" } }, "terms": [ From de448020e0bc6dd21ac9e943a2707e1448fd241b Mon Sep 17 00:00:00 2001 From: Tobias Date: Tue, 16 Sep 2025 12:24:08 +0200 Subject: [PATCH 3/6] Docs: change wording from "Data item" to "OSM Wiki data item" (#1506) --- CONTRIBUTING.md | 4 ++-- GUIDELINES.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 98aa33d3..457189bb 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -50,10 +50,10 @@ Icons from different sources (_icon sets_) can be used in the tagging schema. He ### Info-`i` -![Screenshot of a preset in iD with the information details open.](https://github.com/openstreetmap/id-tagging-schema/assets/111561/13549318-cd7c-4dd1-9948-7a2d84662f04) +Screenshot of a preset in iD with the information details open. iD and other tools provide users with a way to learn more about the main tag of a preset. It is important to provide good information in this information panel. Here are a few notes on how to do this: -- Does your tag have a Wikibase entry? Click the small pencil icon next to the text to open the Wikibase item on the OSM wiki. Improve this wording if needed. If the Wikibase item is missing, [learn more about how to add it in "Current methods for creating new items"](https://wiki.openstreetmap.org/wiki/Data_items#Item_creation_process). +- Does your tag have a OSM Wiki data item? Click the small pencil icon next to the text to open the data item on the OSM Wiki. Improve this wording if needed. If the data item is missing, [learn more about how to add it in "Current methods for creating new items"](https://wiki.openstreetmap.org/wiki/Data_items#Item_creation_process). - Does your tag have a Wiki page with a good image? - Your preset might need [a `reference` property](https://github.com/ideditor/schema-builder?tab=readme-ov-file#reference) to force the system to use a specific tag for the information section. diff --git a/GUIDELINES.md b/GUIDELINES.md index f9a25451..1d652739 100644 --- a/GUIDELINES.md +++ b/GUIDELINES.md @@ -49,7 +49,7 @@ In addition, the deprecated tag must have reasonably high usage to be considered Deprecation rules work such that the user sees a message with suggestions and can act only when editing the given element. This makes them well-suited for gradual, human-reviewed updates of taggings like crossings. However, they are not suitable for cleaning up incorrect tagging from the database, especially for low-volume changes. -There are, however, alternatives to consider: +There are, however, alternatives to consider: - Your cleanup task might be eligible for an automated (bot) edit. [Please learn more on the wiki…](https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct) - If your task is small enough, a few [editing sessions in JOSM](https://wiki.openstreetmap.org/wiki/JOSM) will often do the trick. However, mass-replacing without checking each object is still considered an automated edit, so the [guidelines apply](https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct). Please consult other mappers first. - A good way to work down a list of tasks is to create [a MapRoulette Challenge](https://maproulette.org/). @@ -65,7 +65,7 @@ The user interface must be clear, concise, and easy to use, leaving no room for - Check the search functionality to ensure other presets do not cause confusion. - Select an icon or start the process to create a new one. - Define which fields to show (`fields`) and suggest (`moreFields`), considering the order of fields. -- Check the `(i)` documentation and add or update the [OSM Wikibase item](https://wiki.openstreetmap.org/wiki/Data_items) if needed to provide a helpful short text. +- Check the [`(i)` documentation](./CONTRIBUTING.md#info-i) and add or update the OSM Wiki data item if needed to provide a helpful short text. - Use the PR preview to add test cases with deep links to OSM objects that demonstrate the preset in use. ## 3. Implement From d219b376cd92d4b0302dafa7f87216b9f1d3e6ac Mon Sep 17 00:00:00 2001 From: Martin Raifer Date: Tue, 16 Sep 2025 12:26:49 +0200 Subject: [PATCH 4/6] more strictly match historic=building preset (#1677) --- data/presets/historic/building.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/data/presets/historic/building.json b/data/presets/historic/building.json index 482e5d5d..e5070c7a 100644 --- a/data/presets/historic/building.json +++ b/data/presets/historic/building.json @@ -12,9 +12,6 @@ "area" ], "tags": { - "historic": "building" - }, - "addTags": { "historic": "building", "building": "*" }, From c202e6046cdc5f350310ea7ee335ca02f1646fcd Mon Sep 17 00:00:00 2001 From: UKChris-osm <59393694+UKChris-osm@users.noreply.github.com> Date: Tue, 16 Sep 2025 11:32:12 +0100 Subject: [PATCH 5/6] Preset: shop=mobile_phone_accessories (#1406) --- data/presets/shop/mobile_phone_accessories.json | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 data/presets/shop/mobile_phone_accessories.json diff --git a/data/presets/shop/mobile_phone_accessories.json b/data/presets/shop/mobile_phone_accessories.json new file mode 100644 index 00000000..6a580490 --- /dev/null +++ b/data/presets/shop/mobile_phone_accessories.json @@ -0,0 +1,14 @@ +{ + "icon": "fas-mobile-screen", + "geometry": [ + "point", + "area" + ], + "tags": { + "shop": "mobile_phone_accessories" + }, + "terms": [ + "phone case" + ], + "name": "Mobile Phone Accessory Store" +} From 449fae43042dffe49fb3d189de066e74a68717c8 Mon Sep 17 00:00:00 2001 From: Tobias Date: Tue, 16 Sep 2025 12:34:56 +0200 Subject: [PATCH 6/6] CI: Configure dependabot to also update package.json (#1255) --- .github/dependabot.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index c5b6b65b..d0faeb1f 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -9,3 +9,4 @@ updates: directory: "/" schedule: interval: "daily" + versioning-strategy: increase-if-necessary