Commit graph

695 commits

Author SHA1 Message Date
Martin Raifer
a090dadf41
Merge pull request #1201 from tordans/crossing-refactoring
Crossing refactoring
2024-11-13 12:46:17 +01:00
Tobias
c1989accfe
Add presets for meadow=meadow_orchard, orchard=meadow_orchard (#1218) 2024-11-13 12:44:22 +01:00
Mateusz Konieczny
bfa675f4b5
shop=pastry: Add "cookies" as a term (#1368) 2024-11-03 07:13:50 +01:00
Kyℓe Hensel
8bc37a85f8
Add search terms to several presets (#1370) 2024-11-03 06:13:43 +01:00
archpdx
339ae5bd55
amenity/theatre/type/amphi: Use American English (#1366) 2024-10-24 11:29:47 +02:00
danieldegroot2
99b01c056e
Add terms to public_bookcase: 'book exchange shelf', 'book swap' (#1354) 2024-10-10 06:35:55 +02:00
Coehill
7629cf2bd8
Add term to public_bookcase (#1333)
Co-authored-by: Coehill <thomas@thomascraig.dev>
2024-09-27 15:58:47 +02:00
Matija Nalis
8a37712301
Add search terms for monitoring_station (#1347)
Generally, but also specifically for bicycle counters and water levels
2024-09-27 11:35:48 +02:00
yvecai
ce216355bd
Make preset for piste:type=yes unsearchable and update name (#1312)
* General piste preset to not searchable
* Preset Piste: Add "Unspecified Type" to name

---------

Co-authored-by: yves <yves@maisonux-iii.home>
Co-authored-by: Tobias <t@tobiasjordans.de>
2024-09-15 10:31:30 +02:00
archpdx
1919effc91
Add building_area_yes field to Funeral Service Hall preset (#1324) 2024-09-05 16:26:30 +02:00
Tobias
b2ad5362e0
Crossings: Improve wording for name
Co-authored-by: Kyℓe Hensel <k-yle@users.noreply.github.com>
2024-09-03 14:09:28 +02:00
Roman Deev
e25f91e8c0
Add preset for office=translator (#1298) 2024-08-20 15:23:11 +02:00
osmuser63783
5d95be8cdd
Add camp_site field to tourism=camp_site (#1286)
Co-authored-by: Martin Raifer <martin@raifer.tech>
2024-08-20 10:04:44 +02:00
ᴄʜʀɪsᴛᴏᴘʜᴇʀ ᴍ
790f6d9992
Add maxheight field to parking garage entrance/exit (#232) 2024-08-08 18:21:21 +02:00
Martin Raifer
2f06f22b42
sort terms alphabetically, see #1249 2024-08-08 17:02:02 +02:00
tiptoptom
9c42f73111
Add presets for additional community_centre (#1200)
Co-authored-by: Samu__ <s.lechner@etlgr.com>
2024-07-29 07:34:51 +02:00
Axel
455d733d87
Add preset for amenity=swingerclub (#1187) 2024-07-22 17:18:23 +02:00
archpdx
4535fb74f6
Add Chinese Fast Food preset (#1280) 2024-07-22 17:11:42 +02:00
archpdx
a43e03ec73
Add Go Kart Facility preset (#1281) 2024-07-22 17:01:13 +02:00
Kyℓe Hensel
87c39e17a6
Create preset for man_made=footwear_decontamination (#1235)
Co-authored-by: Tobias <t@tobiasjordans.de>
2024-07-15 09:23:51 +02:00
kjonosm
4a3c6f6325
Add hairdresser=barber preset (#1165)
Co-authored-by: Martin Raifer <martin@raifer.tech>
2024-07-13 14:28:09 +02:00
Kyℓe Hensel
b36e802919
Allow some presets to be mapped as vertices (#1233)
Some case an object would change it's preset when merged with a line due to inconsistencies with a parent preset.
2024-07-10 22:12:40 +02:00
osmuser63783
bab09d1791
Add preset for leisure=bathing_place (#1217) (#1274)
* Add preset for leisure=bathing_place (#1217)
* Swapped icons for bathing_place and public_bath
2024-07-08 09:07:46 +02:00
Olaf Kryus
f7622e377f
Add presets for ski jump tagging (#1176)
* Add presets for ski jump tagging
* Update data/presets/man_made/ski_jump.json

Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Tobias <tobias@fixmycity.de>
2024-07-08 08:29:24 +02:00
Kyℓe Hensel
2bd6a13294
Add preset man_made=flare (#1237) 2024-06-14 10:07:06 +02:00
Kyℓe Hensel
7252394f2e
Remove matchScore=1.1 from Kitchen Garden (#1253) 2024-06-06 17:29:40 +02:00
Mateusz Konieczny
6abf094b9a
Add term medical to sample collection (#1249) 2024-06-06 06:17:44 +02:00
ToastHawaii
dc4bf38a1f
Add field organic to more amenity (#1247) 2024-06-06 05:38:30 +02:00
Mateusz Konieczny
ee94a6b7c5
Add term laboratory to sample collection (#1223) 2024-06-05 21:11:53 +02:00
Pieter Vander Vennet
87b710df73
Add term to bicycle_repair_station (#1231)
Add 'compressed air' as some people search for this term when they want to add a bicycle pump
2024-06-05 21:02:50 +02:00
Kyℓe Hensel
f2fbc7998a
Add maxweight to helipad preset (#1234) 2024-06-05 20:49:52 +02:00
bompstable
87d7b90f93
amenity=bench: Add armrest field, move color to moreFields (#1227) 2024-05-31 10:46:51 +02:00
Martin Raifer
ffef8769aa
fix typos, finish sentences 2024-05-22 18:04:05 +02:00
Martin Raifer
14e30fa5bb
fix typo, minor rewording 2024-05-22 17:59:15 +02:00
Tobias
4381d3ac45 crossing: Fix fields order for highway/crossing 2024-04-26 13:19:45 +02:00
Tobias
b1ab6e35cf crossing: Add lit to all crossing "way" geometry presets via new @template/geometry_way_more
The "lit" value was present on some of the presets before and is common to be applied to all kind of ways.
2024-04-26 13:18:32 +02:00
Tobias
6c0174e208 crossing: Re-add crossing to all fields
This fixes "crossing: New approach with …`@templates/crossing/defaults`".

We need the "crossing" field on vertex/node fields as well to allow to quickly change the preset.

SQ
2024-04-26 13:18:32 +02:00
Tobias
289a57b700 crossing: Add readme docs on the presets/@templates 2024-04-26 13:18:32 +02:00
Tobias
2cec1313d7 crossing: Add readme for crossing presets and fields 2024-04-26 13:18:32 +02:00
Tobias
118ae02ebe crossing: Extract tactile_paving from shared @template to node crossings
The common practice is to tag this in the `highway=crossing` nodes and on separate `barrier=kerb` nodes but not on the crossing ways. Same as the `kerb` field.
2024-04-26 13:18:32 +02:00
Tobias
28638cf6c8 crossing: Apply flashing_light to all footway=crossing and crossing notes
The field `flashing_light` was used on some of those presets. It is now more systematic.

I also kept them on the `traffic_signals` presets because those can have additional `flashing_lights` as well.
2024-04-26 13:18:25 +02:00
Tobias
46ac97189c crossing: New approach with @templates/crossing/bicycle_more, adding segregated
The fields `oneway` and `access` are important for `highway=cycleway|path` crossings but not essential. They are more of a advanced user setup which should be visible when prev filled in but only added by users that read more about it before. They are moved to the `moreFields` for that reason.

The `segregated` is added here for the same reasons and because of it's importance for highway types that likely have bike traffic.
Ping https://github.com/openstreetmap/id-tagging-schema/issues/317

The `surface` and `smoothness` is extracted from the `@template` because it makes more sense to split them up in `fields` and `moreFields`. A templates adds too much abstraction in this case.
2024-04-26 13:18:25 +02:00
Tobias
8ca0db555c crossing: Fix marking* templates by allowing line geometries
The markings templates are not touched by this PR and it does seem to work without this. However, the fields are used on line and point geometries so either the `geometry` field is ignored during build or something else is happening…
2024-04-26 13:18:25 +02:00
Tobias
75d756f2bc crossing: New approach with @templates/crossing/bicycle_relevance and @templates/crossing/defaults
The field "crossing" is removed from the `/defaults` fields.
- it is only relevant for the geometry line because it is hidden on geometry vertex.
- but on geometry line, we want it to be on the first position of fields
- the `/defaults` fields however should be positioned below the `markings` which are more relevant for specifying the kind of crossing
- the `/defaults` fields now includes `crossing_raised` which was removed from the previous and discontinued `/geomery_line` fields template.

The new `@templates/crossing/bicycle_relevance`
- is used on all highways that have bicycle relevance which are `highway=path|cycleway` and not on `highway=footway`

For all traffic_signal presets, the order of fields is different to give the `/traffic_signal` more prominence.
2024-04-26 13:18:25 +02:00
Tobias
30a8be932d crossing: Introduce highway=path+path=crossing fields
All fields are unsearchable (for now) so we can learn how to name properly.

The names are adapted from `presets/highway/cycleway/crossing/bicycle_foot.json`.

The terms are removed because the presets are unsearchable.
2024-04-26 12:00:45 +02:00
Tobias
cd56a0db32 crossing: Move the @templates/crossing/markings to first field position
Using the preset I find the markings field to be the most important to change. The `@templates/crossing/defaults` is less important for all situation except for `data/presets/highway/crossing.json`. The main reasons for this is, that only on the base `highway/crossing` the field `crossing` is actually visible. For the more precise presets this field is hidden by some automatic part of the system.
2024-04-26 12:00:45 +02:00
Tobias
cb4b64e2c9 crossing: Add kerb to all vertex crossings
The convention is, to tag this on the node _and_/_or_ on the separate `barrier=kerb+kerb=*` node when the path is mapped separately.
It should be part of all crossing vertex presets.
2024-04-26 12:00:45 +02:00
Tobias
99caf278b0 crossing: remove "oneway" on highway/crossing vertex
I added this in 3e5e99ff88 an I think that was a mistake so lets remove it again.
2024-04-26 12:00:45 +02:00
Tobias
c624700656 crossing: Introduce @templates/crossing/traffic_signal_more
This extract the three moreFields to be reused in all traffic_signals presets.
- "traffic_signals/arrow"
- "traffic_signals/countdown"
- "traffic_signals/minimap"

For unclear reasons the cycleway/crossing/traffic_signals did not have those more fields which are now added to streamline the presets.
2024-04-26 12:00:45 +02:00
Tobias
50aeb69b4e crossing: Introduce @templates/crossing/traffic_signal
This extract the three fields to be reused in all traffic_signals presets.
- "button_operated"
- "traffic_signals/sound"
- "traffic_signals/vibration"

Nothing else is changed, this is just an extraction into a template.
2024-04-25 04:57:26 +02:00