According to [taginfo](https://taginfo.openstreetmap.org/tags/?key=amenity&value=parcel_locker#combinations), 2/3 of all parcel lockers have an `opening_hours` tag. Most of these are `24/7`, but I see many enough lockers that have other modes.
In this PR I:
* add the tag to the list of common fields;
* add `brand` and `colour` fields to the `moreFields` list — these are mentioned on the wiki page, and might be interesting to fill out;
* also move `operator` to the top, since it's the most important attribute of a parcel locker.
* Update wastewater_plant.json
adding a ref field, because they're often on the signage, and they match official open-data listings for correlation, so hinting to the users to fill out if known helps.
Also, they're known as wastewater treatment works
* add some additional terms
Co-authored-by: Martin Raifer <martin@raifer.tech>
* garages: Only keep capacity as field
Move fields from from https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/building.json to the moreFields section to only show very relevant fields by default.
* garage: Use same fields as garages
* fix json syntax
… and use template syntax to tidy up moreFields list slightly
* fix json syntax
and also copy "moreFields" from building/garages preset
Co-authored-by: Martin Raifer <martin@raifer.tech>
* Fix data/presets/amenity/ticket_validator format and file ending
* Fix reference to disc_golf_basket icon, which is from temaki, not maki
* Fixed space in preset name (water_reservoir_covered)
Co-authored-by: Johnny Accot <johnny@accot.fr>
Co-authored-by: Martin Raifer <martin@raifer.tech>
The upgrade paths for the old `vending=parcel_pickup` and `vending=parcel_mail_in` tags overlap for the case of a feature tagged as `parcel_pickup;parcel_mail_in`. This casuses all three matching `replacement`s to be applied in iD. The value of the `parcel_mail_in` conflicts in this case. Since for `parcel_pickup` the implied `yes` default should not be set, it is impossible to resolve this ambiguity with the current schema of `deprecated.json`.
This hotfix/workaround solves this by skipping the upgrade path for `vending=parcel_mail_in`-only features. This minimally impacts the functionality, as such parcel lockers are much less common than pickup-only or combined ones (250 vs. 18k features).
closes#364
