Commit graph

898 commits

Author SHA1 Message Date
Tobias
3ab88d0fcd crossing: Use the same property order for fields/crossing/markings*
All those fields used a different order of properties, which made it hard to compare them.

This commit does not change anything on the fields, it just streamlines the same order of properties across files.
2024-04-26 12:00:45 +02:00
Tobias
cb4b64e2c9 crossing: Add kerb to all vertex crossings
The convention is, to tag this on the node _and_/_or_ on the separate `barrier=kerb+kerb=*` node when the path is mapped separately.
It should be part of all crossing vertex presets.
2024-04-26 12:00:45 +02:00
Tobias
99caf278b0 crossing: remove "oneway" on highway/crossing vertex
I added this in 3e5e99ff88 an I think that was a mistake so lets remove it again.
2024-04-26 12:00:45 +02:00
Tobias
c624700656 crossing: Introduce @templates/crossing/traffic_signal_more
This extract the three moreFields to be reused in all traffic_signals presets.
- "traffic_signals/arrow"
- "traffic_signals/countdown"
- "traffic_signals/minimap"

For unclear reasons the cycleway/crossing/traffic_signals did not have those more fields which are now added to streamline the presets.
2024-04-26 12:00:45 +02:00
Tobias
50aeb69b4e crossing: Introduce @templates/crossing/traffic_signal
This extract the three fields to be reused in all traffic_signals presets.
- "button_operated"
- "traffic_signals/sound"
- "traffic_signals/vibration"

Nothing else is changed, this is just an extraction into a template.
2024-04-25 04:57:26 +02:00
Tobias
e47e4d6325 crossing: Introduce @templates/crossing/geometry_line
This streamlines the fields on all line geometry crossings.
- "oneway"
- "surface"
- "smoothness"
- "crossing_raised"
- "access"

Those fields are always the last in the list. For traffic signal those specific fields are put above. Which is also the only change for one vertex preset in this commit, to have the "crossing_raised" come after the traffic signal specific fields and so the order is the same across presets.

This will roll out the smoothness field for all crossings; it was previously only present in some. But given the importance of smoothness for accessibility I think that is OK. This commit also moves the surface (and smoothness where present) fields further down the list which reduces the priority a bit.

The biggest change in priority is the oneway-field which had the first position before and now is below the defaults- and markings-field.
2024-04-25 04:57:08 +02:00
Tobias
ca2b2e5f7a crossing: Introduce @templates/crossing/defaults
This way we have the same fields in all crossing presets:
- "crossing"
- "tactile_paving"
- "crossing/island"

This change the order of things slightly for some footway, cycleway crossing where `surface` is now a bit lower, but that should not be a problem.
2024-04-25 04:57:08 +02:00
Tobias
89a1671c3f cycleway/crossing: add "tactile_paving" to traffic_signal
This streamlines the crossings presets
2024-04-24 17:16:41 +02:00
Tobias
41a9443e84 cycleway/crossing: add "oneway" field to unmarked in bicycle_foot
This streamlines the presets and makes it easer to review and use them.
2024-04-24 17:16:41 +02:00
Tobias
02eb4d0235 crossing/_marked: remove terms
Terms are not used for unsearchable preset so we can remove them.
2024-04-24 17:16:41 +02:00
danieldegroot2
6de5f5fde8
Add activity field to route_marker.json (#1197) 2024-04-11 13:43:58 +02:00
Martin Raifer
4fed7efe1f
fix wrong tag in deprecation rule, fixes #1180
wrong tag was introduced in 01e7739976
2024-04-05 18:25:05 +02:00
Flo Edelmann
e904de263c
Add terms to historic = wayside_cross preset (#1181) 2024-04-05 17:59:38 +02:00
tyrasd
653eaf9e21 Deploying to main from @ openstreetmap/id-tagging-schema@b9d9fede53 🚀 2024-04-05 15:59:22 +00:00
tyrasd
d1d811f7ab Deploying to main from @ openstreetmap/id-tagging-schema@ed497a32a7 🚀 2024-04-05 15:58:42 +00:00
qugebert
b9d9fede53
Change some icons, reducing multiply reused icons (#1163) 2024-04-05 17:55:30 +02:00
Martin Raifer
ed497a32a7
suggest to discard "playground:theme=playground" tags
see https://github.com/openstreetmap/id-tagging-schema/issues/1188#issuecomment-2040063095
2024-04-05 17:52:23 +02:00
Flo Edelmann
6727a604e0
Add terms to Dance Hall / Dance School presets (#1182) 2024-04-05 17:41:59 +02:00
Martin Raifer
915ed76ac0
finally actually drop "deprecation" of amenity=dancing_school 2024-04-05 17:25:38 +02:00
Martin Raifer
0a6eb743eb
don't allow cliffs mapped as areas
see https://wiki.openstreetmap.org/w/index.php?title=Tag:natural%3Dcliff&oldid=2536175
2024-04-05 17:25:38 +02:00
Tobias
c6dfbbd2a4
Playground Preset: Move "playground:theme" to "moreFields" (#1191)
Following https://github.com/openstreetmap/id-tagging-schema/issues/1188#issuecomment-2038817783 to remove the common misstagging as `playground:theme=playground` due to the prominent autosuggest.
2024-04-05 17:02:59 +02:00
trigpoint
e75eaeea81
Add "E5 gasoline" as option to Fuel field (#1192) 2024-04-05 16:55:51 +02:00
Martin Raifer
9505676e24
fix tag key for kitchen garden to kitchen:style, tweak fields
see https://github.com/openstreetmap/id-tagging-schema/pull/1135
2024-03-26 15:02:20 +01:00
Martin Raifer
692da6c5f5
country field on flags should be case sensitive
see #490
2024-03-25 10:52:53 +01:00
Martin Raifer
799fc6ce92
standalone traffic calming preset should only apply to vertices
use on lines makes only sense in combination with a road preset, for which there is a field now
2024-03-15 20:32:53 +01:00
Martin Raifer
9b92e82818
add traffic_calming field to minor and major road presets 2024-03-15 20:32:53 +01:00
Martin Raifer
1d3023e104
add preset for area:highway=traffic_island (#1162) 2024-03-15 20:32:53 +01:00
Martin Raifer
01e7739976
patch v6.7.2: traffic_calming=island + area=yes -> area:highway=traffic_island
partially addresses https://github.com/openstreetmap/id-tagging-schema/issues/1162
2024-03-15 20:32:49 +01:00
Martin Raifer
f6f5c95f06
add some missing common cuisine values, closes #1146
this includes most of the top ~100 most used values of the `cuisine` tag, omitting discouraged values like `international`

also sorts the list by the current number of uses according to taginfo (see https://gist.github.com/tyrasd/aaa5d32cb05f8ed1acafdd2e40737254)
2024-03-15 14:02:49 +01:00
qugebert
926ca653c6
Add dedicated presets for pillar and underground hydrants (#1160) 2024-03-14 17:01:16 +01:00
Martin Raifer
89139bbaf0
use dedicate icon for unspecified kerbs, see #1077 2024-03-14 15:27:13 +01:00
qugebert
d13d3cdbad
add preset for natural=sinkhole (#1154) 2024-03-14 15:25:07 +01:00
qugebert
183cf30485
add preset for highway=ladder (#1153) 2024-03-14 15:21:32 +01:00
Martin Raifer
ff077366fe
make all tree type presets searchable, fixes #1156
also adding "tree" as search term to all of these presets and use matchscore to nudge sorting to slightly prefer the (in OSM) more common cases
2024-03-13 16:14:45 +01:00
Mateusz Konieczny
b5a1794d2a
more terms for amenity=public_bookcase (#1150) 2024-03-07 11:26:24 +01:00
Martin Raifer
3593ffcf40
allow historic=ruins to be used on lines, closes #1149
as documented on https://wiki.openstreetmap.org/w/index.php?title=Tag:historic%3Druins&oldid=2581907
2024-03-06 14:28:39 +01:00
IreuN
48e730498a
Remove area type for traffic_calming=island (#1076)
* Remove area type for traffic_calming=island
* also disallow areas on generic traffic_calming=* preset

see https://wiki.openstreetmap.org/w/index.php?title=Key:traffic_calming&oldid=2594288

---------

Co-authored-by: Martin Raifer <martin@raifer.tech>
2024-02-28 14:06:57 +01:00
Tobias
3e5e99ff88
Add oneway to moreFields for path like highways 2024-02-28 09:22:48 +01:00
Martin Raifer
a6cfb236af
lint 2024-02-27 16:47:31 +01:00
Martin Raifer
982e632ec0
add icons to kerb fields, tweak label, drop from specialized presets
specialized presets should be switched using the preset selector, no need to duplicate that as a combo box. this effectively reverts https://github.com/openstreetmap/iD/issues/6360

(re icons, see also https://github.com/openstreetmap/id-tagging-schema/pull/1077#issuecomment-1966247784)

also remove duplicates of translatable strings
2024-02-27 16:43:46 +01:00
mcliquid
f8085257fa
Create preset for amenity=bicycle_wash (#1032, #1016) 2024-02-27 11:33:23 +01:00
Mateusz Konieczny
17e8c209cd
add extra terms to Transit Ticket Vending Machine preset (#1142) 2024-02-27 10:13:10 +01:00
Martin Raifer
48cb0b60ce
clarify that left/right meant to be given relative to the cyclist
see https://github.com/openstreetmap/iD/issues/10128
see https://wiki.openstreetmap.org/w/index.php?title=Tag:highway%3Dcyclist_waiting_aid&oldid=2631832
see https://community.openstreetmap.org/t/approved-feature-proposal-cyclist-footrests-and-handrails-cyclist-waiting-aid/105762/3
2024-02-26 13:35:17 +01:00
kjonosm
9b7e616904
Add translatable strings to bridge field (#1002) 2024-02-26 12:48:58 +01:00
Max Langer
b8862ed383
add changing_table as optional field to several presets (#1060) (#1139) 2024-02-26 12:20:59 +01:00
Martin Raifer
55184b6d09
don't automatically add building=yes on man_made=works objects, fixes #1132 2024-02-25 10:19:34 +01:00
Kyℓe Hensel
269443c478
add via tag to ferry routes (#1126) 2024-02-25 09:59:55 +01:00
qugebert
05fff1108b
Create cannon.json (#1134) 2024-02-24 18:41:35 +01:00
Kyℓe Hensel
c1115c6b38
add road-related fields to busway preset (#1127)
* add road-related fields to busway preset

* remove duplicate field
2024-02-24 18:38:08 +01:00
Kyℓe Hensel
e5c374c4fd
add structure field to steps preset (#1128) 2024-02-24 18:35:18 +01:00