* Fix data/presets/amenity/ticket_validator format and file ending
* Fix reference to disc_golf_basket icon, which is from temaki, not maki
* Fixed space in preset name (water_reservoir_covered)
Co-authored-by: Johnny Accot <johnny@accot.fr>
Co-authored-by: Martin Raifer <martin@raifer.tech>
The upgrade paths for the old `vending=parcel_pickup` and `vending=parcel_mail_in` tags overlap for the case of a feature tagged as `parcel_pickup;parcel_mail_in`. This casuses all three matching `replacement`s to be applied in iD. The value of the `parcel_mail_in` conflicts in this case. Since for `parcel_pickup` the implied `yes` default should not be set, it is impossible to resolve this ambiguity with the current schema of `deprecated.json`.
This hotfix/workaround solves this by skipping the upgrade path for `vending=parcel_mail_in`-only features. This minimally impacts the functionality, as such parcel lockers are much less common than pickup-only or combined ones (250 vs. 18k features).
closes#364
* embassy=embassy to embassy=yes
embassy=embassy is an unwanted tagging fueled by iD presets showing top taginfo suggestions
there was confused philosophical discussion about deprecations on tagging mailing list - but of all involved noone considered embassy=embassy as a good idea
see https://lists.openstreetmap.org/pipermail/tagging/2022-January/063459.html
* specify values for "embassy" tag (closes#340)
Co-authored-by: Mateusz Konieczny <matkoniecz@gmail.com>
add presets for all categories currently documented at https://wiki.openstreetmap.org/wiki/Key:wetland
also drop the tidal/salt fields where they do not apply to the more specific wetland presets
* deprecated old vending_machine tagging for parcel lockers
* moved and updated parcel lockers presets
* removed non-english term
* removed terms referring to brands since they will be pulled from NSI anyway
* fixed missing tag
* added missing preset for dropoff only locker
* created single preset for parcel locker
* use generic "parcel locker" as title of preset
* add some additional search terms
* make description field optional again
Co-authored-by: Martin Raifer <martin@raifer.tech>