From 7133e6fc36f518b88caae5761dfafb19ab782f09 Mon Sep 17 00:00:00 2001 From: Tobias Date: Sun, 11 May 2025 17:13:26 +0200 Subject: [PATCH 1/7] Add three presets for substation=minor_distribution (Kiosk, Building, Tower) https://wiki.openstreetmap.org/wiki/Tag:substation%3Dminor_distribution --- ...ubstation_minor_distribution_building.json | 40 ++++++++++++++++++ .../substation_minor_distribution_kiosk.json | 41 +++++++++++++++++++ .../substation_minor_distribution_tower.json | 37 +++++++++++++++++ 3 files changed, 118 insertions(+) create mode 100644 data/presets/power/substation_minor_distribution_building.json create mode 100644 data/presets/power/substation_minor_distribution_kiosk.json create mode 100644 data/presets/power/substation_minor_distribution_tower.json diff --git a/data/presets/power/substation_minor_distribution_building.json b/data/presets/power/substation_minor_distribution_building.json new file mode 100644 index 00000000..33926a11 --- /dev/null +++ b/data/presets/power/substation_minor_distribution_building.json @@ -0,0 +1,40 @@ +{ + "icon": "temaki-power", + "fields": [ + "building", + "power", + "substation", + "name", + "operator", + "voltage", + "ref" + ], + "moreFields": [ + "address", + "gnis/feature_id-US", + "transformer", + "phases", + "frequency" + ], + "geometry": [ + "area", + "point" + ], + "tags": { + "building": "service", + "utility": "power" + }, + "addTags": { + "power": "substation", + "substation": "minor_distribution" + }, + "reference": { + "key": "building", + "value": "service" + }, + "terms": [ + "minor distribution station", + "small masonry building" + ], + "name": "Substation (Building)" +} diff --git a/data/presets/power/substation_minor_distribution_kiosk.json b/data/presets/power/substation_minor_distribution_kiosk.json new file mode 100644 index 00000000..3c24d40f --- /dev/null +++ b/data/presets/power/substation_minor_distribution_kiosk.json @@ -0,0 +1,41 @@ +{ + "icon": "temaki-power", + "fields": [ + "man_made", + "power", + "substation", + "name", + "operator", + "voltage", + "ref" + ], + "moreFields": [ + "address", + "gnis/feature_id-US", + "transformer", + "phases", + "frequency", + "material" + ], + "geometry": [ + "area", + "point" + ], + "tags": { + "man_made": "street_cabinet", + "substation": "minor_distribution" + }, + "addTags": { + "utility": "power", + "power": "substation" + }, + "reference": { + "key": "substation", + "value": "minor_distribution" + }, + "terms": [ + "kiosk", + "compact" + ], + "name": "Substation (Kiosk)" +} diff --git a/data/presets/power/substation_minor_distribution_tower.json b/data/presets/power/substation_minor_distribution_tower.json new file mode 100644 index 00000000..46377cff --- /dev/null +++ b/data/presets/power/substation_minor_distribution_tower.json @@ -0,0 +1,37 @@ +{ + "icon": "temaki-power", + "fields": [ + "building", + "power", + "substation", + "name", + "operator", + "voltage", + "ref" + ], + "moreFields": [ + "address", + "gnis/feature_id-US" + ], + "geometry": [ + "area", + "point" + ], + "tags": { + "building": "transformer_tower" + }, + "addTags": { + "utility": "power", + "power": "substation", + "substation": "minor_distribution" + }, + "reference": { + "key": "building", + "value": "transformer_tower" + }, + "terms": [ + "transformer building", + "electricity pole" + ], + "name": "Substation (Tower)" +} From 520124ea46e263f9bbc2d6f01da7ccdc1da4dbf8 Mon Sep 17 00:00:00 2001 From: Tobias Date: Sun, 11 May 2025 17:36:34 +0200 Subject: [PATCH 2/7] Add all tags to `addTags` This will hopefully make it, so that when I select a building=yes this gets overwritten with building=service. --- data/presets/power/substation_minor_distribution_building.json | 2 ++ data/presets/power/substation_minor_distribution_kiosk.json | 2 ++ data/presets/power/substation_minor_distribution_tower.json | 1 + 3 files changed, 5 insertions(+) diff --git a/data/presets/power/substation_minor_distribution_building.json b/data/presets/power/substation_minor_distribution_building.json index 33926a11..caf841f7 100644 --- a/data/presets/power/substation_minor_distribution_building.json +++ b/data/presets/power/substation_minor_distribution_building.json @@ -25,6 +25,8 @@ "utility": "power" }, "addTags": { + "building": "service", + "utility": "power", "power": "substation", "substation": "minor_distribution" }, diff --git a/data/presets/power/substation_minor_distribution_kiosk.json b/data/presets/power/substation_minor_distribution_kiosk.json index 3c24d40f..25a8e44f 100644 --- a/data/presets/power/substation_minor_distribution_kiosk.json +++ b/data/presets/power/substation_minor_distribution_kiosk.json @@ -26,6 +26,8 @@ "substation": "minor_distribution" }, "addTags": { + "man_made": "street_cabinet", + "substation": "minor_distribution", "utility": "power", "power": "substation" }, diff --git a/data/presets/power/substation_minor_distribution_tower.json b/data/presets/power/substation_minor_distribution_tower.json index 46377cff..a4412e74 100644 --- a/data/presets/power/substation_minor_distribution_tower.json +++ b/data/presets/power/substation_minor_distribution_tower.json @@ -21,6 +21,7 @@ "building": "transformer_tower" }, "addTags": { + "building": "transformer_tower", "utility": "power", "power": "substation", "substation": "minor_distribution" From 51581bcea8b6c309aea3eb30e94bc37df15dc0de Mon Sep 17 00:00:00 2001 From: Tobias Date: Sun, 11 May 2025 17:39:49 +0200 Subject: [PATCH 3/7] Remove "power" field This looked confusing in the editor, see testing notes --- data/presets/power/substation_minor_distribution_building.json | 1 - data/presets/power/substation_minor_distribution_kiosk.json | 1 - data/presets/power/substation_minor_distribution_tower.json | 1 - 3 files changed, 3 deletions(-) diff --git a/data/presets/power/substation_minor_distribution_building.json b/data/presets/power/substation_minor_distribution_building.json index caf841f7..c46010f2 100644 --- a/data/presets/power/substation_minor_distribution_building.json +++ b/data/presets/power/substation_minor_distribution_building.json @@ -2,7 +2,6 @@ "icon": "temaki-power", "fields": [ "building", - "power", "substation", "name", "operator", diff --git a/data/presets/power/substation_minor_distribution_kiosk.json b/data/presets/power/substation_minor_distribution_kiosk.json index 25a8e44f..37cb494a 100644 --- a/data/presets/power/substation_minor_distribution_kiosk.json +++ b/data/presets/power/substation_minor_distribution_kiosk.json @@ -2,7 +2,6 @@ "icon": "temaki-power", "fields": [ "man_made", - "power", "substation", "name", "operator", diff --git a/data/presets/power/substation_minor_distribution_tower.json b/data/presets/power/substation_minor_distribution_tower.json index a4412e74..d036e645 100644 --- a/data/presets/power/substation_minor_distribution_tower.json +++ b/data/presets/power/substation_minor_distribution_tower.json @@ -2,7 +2,6 @@ "icon": "temaki-power", "fields": [ "building", - "power", "substation", "name", "operator", From b9bda54b205a822bd1b7df192234aacced69848d Mon Sep 17 00:00:00 2001 From: Tobias Date: Sun, 11 May 2025 17:57:27 +0200 Subject: [PATCH 4/7] Remove some fields that no one can or should change for this preset --- data/presets/power/substation_minor_distribution_building.json | 1 - data/presets/power/substation_minor_distribution_kiosk.json | 2 -- data/presets/power/substation_minor_distribution_tower.json | 1 - 3 files changed, 4 deletions(-) diff --git a/data/presets/power/substation_minor_distribution_building.json b/data/presets/power/substation_minor_distribution_building.json index c46010f2..339727bf 100644 --- a/data/presets/power/substation_minor_distribution_building.json +++ b/data/presets/power/substation_minor_distribution_building.json @@ -2,7 +2,6 @@ "icon": "temaki-power", "fields": [ "building", - "substation", "name", "operator", "voltage", diff --git a/data/presets/power/substation_minor_distribution_kiosk.json b/data/presets/power/substation_minor_distribution_kiosk.json index 37cb494a..5617f7a7 100644 --- a/data/presets/power/substation_minor_distribution_kiosk.json +++ b/data/presets/power/substation_minor_distribution_kiosk.json @@ -1,8 +1,6 @@ { "icon": "temaki-power", "fields": [ - "man_made", - "substation", "name", "operator", "voltage", diff --git a/data/presets/power/substation_minor_distribution_tower.json b/data/presets/power/substation_minor_distribution_tower.json index d036e645..e341d735 100644 --- a/data/presets/power/substation_minor_distribution_tower.json +++ b/data/presets/power/substation_minor_distribution_tower.json @@ -2,7 +2,6 @@ "icon": "temaki-power", "fields": [ "building", - "substation", "name", "operator", "voltage", From 37a40bbe9102a1c249f523593548434be67662fa Mon Sep 17 00:00:00 2001 From: Tobias Date: Sun, 17 Aug 2025 17:26:09 +0200 Subject: [PATCH 5/7] Apply suggestions from code review: Remove `frequency` https://github.com/openstreetmap/id-tagging-schema/pull/1543#issuecomment-3194448040 --- data/presets/power/substation_minor_distribution_building.json | 3 +-- data/presets/power/substation_minor_distribution_kiosk.json | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/data/presets/power/substation_minor_distribution_building.json b/data/presets/power/substation_minor_distribution_building.json index 339727bf..3a281fcf 100644 --- a/data/presets/power/substation_minor_distribution_building.json +++ b/data/presets/power/substation_minor_distribution_building.json @@ -11,8 +11,7 @@ "address", "gnis/feature_id-US", "transformer", - "phases", - "frequency" + "phases" ], "geometry": [ "area", diff --git a/data/presets/power/substation_minor_distribution_kiosk.json b/data/presets/power/substation_minor_distribution_kiosk.json index 5617f7a7..2205ef22 100644 --- a/data/presets/power/substation_minor_distribution_kiosk.json +++ b/data/presets/power/substation_minor_distribution_kiosk.json @@ -11,7 +11,6 @@ "gnis/feature_id-US", "transformer", "phases", - "frequency", "material" ], "geometry": [ From ba0d42dfb3166c190a06a6d8298e6fe4d12b86a4 Mon Sep 17 00:00:00 2001 From: Tobias Date: Sat, 18 Oct 2025 13:20:05 +0200 Subject: [PATCH 6/7] Apply suggestion from @FloEdelmann Co-authored-by: Flo Edelmann --- data/presets/power/substation_minor_distribution_kiosk.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/data/presets/power/substation_minor_distribution_kiosk.json b/data/presets/power/substation_minor_distribution_kiosk.json index 2205ef22..e2dbf51f 100644 --- a/data/presets/power/substation_minor_distribution_kiosk.json +++ b/data/presets/power/substation_minor_distribution_kiosk.json @@ -32,8 +32,8 @@ "value": "minor_distribution" }, "terms": [ - "kiosk", - "compact" + "compact", + "kiosk" ], "name": "Substation (Kiosk)" } From 374cbae3b8b3bd2b5f38425b9e29716c542b51fe Mon Sep 17 00:00:00 2001 From: Tobias Date: Sat, 18 Oct 2025 13:20:11 +0200 Subject: [PATCH 7/7] Apply suggestion from @FloEdelmann Co-authored-by: Flo Edelmann --- data/presets/power/substation_minor_distribution_tower.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/data/presets/power/substation_minor_distribution_tower.json b/data/presets/power/substation_minor_distribution_tower.json index e341d735..69e5619c 100644 --- a/data/presets/power/substation_minor_distribution_tower.json +++ b/data/presets/power/substation_minor_distribution_tower.json @@ -29,8 +29,8 @@ "value": "transformer_tower" }, "terms": [ - "transformer building", - "electricity pole" + "electricity pole", + "transformer building" ], "name": "Substation (Tower)" }