From 54205c7a29c552e38246348b7576758d0927f34f Mon Sep 17 00:00:00 2001
From: Martin Raifer <martin@raifer.tech>
Date: Fri, 2 Feb 2024 11:46:27 +0100
Subject: [PATCH] add "unleashed" as value for `dog` tag field

and limit offered values of `dog` field on dog-specific features to just =leashed`/`unleashed`: `no` does generally not make sense on these, and `yes`/`designated` is already implied by the primary tag.
---
 data/fields/dog.json                 |  1 +
 data/fields/dog_yes.json             | 12 ++++++++++++
 data/presets/amenity/dog_toilet.json |  2 +-
 data/presets/leisure/dog_park.json   |  2 +-
 interim/source_strings.yaml          |  4 ++++
 5 files changed, 19 insertions(+), 2 deletions(-)
 create mode 100644 data/fields/dog_yes.json

diff --git a/data/fields/dog.json b/data/fields/dog.json
index d9e8de29..bcc9d343 100644
--- a/data/fields/dog.json
+++ b/data/fields/dog.json
@@ -6,6 +6,7 @@
         "options": {
             "yes": "Allowed",
             "leashed": "Leashed Only",
+            "unleashed": "Leashes Not Required",
             "no": "Not Allowed"
         }
     },
diff --git a/data/fields/dog_yes.json b/data/fields/dog_yes.json
new file mode 100644
index 00000000..904e3db2
--- /dev/null
+++ b/data/fields/dog_yes.json
@@ -0,0 +1,12 @@
+{
+    "key": "dog",
+    "type": "combo",
+    "label": "{dog}",
+    "options": [
+        "leashed",
+        "unleashed"
+    ],
+    "stringsCrossReference": "{dog}",
+    "autoSuggestions": false,
+    "customValues": false
+}
diff --git a/data/presets/amenity/dog_toilet.json b/data/presets/amenity/dog_toilet.json
index be7599f8..12f22c44 100644
--- a/data/presets/amenity/dog_toilet.json
+++ b/data/presets/amenity/dog_toilet.json
@@ -10,7 +10,7 @@
     ],
     "moreFields": [
         "{@templates/contact}",
-        "dog",
+        "dog_yes",
         "gnis/feature_id-US",
         "ref"
     ],
diff --git a/data/presets/leisure/dog_park.json b/data/presets/leisure/dog_park.json
index 9bfcf261..64d448c3 100644
--- a/data/presets/leisure/dog_park.json
+++ b/data/presets/leisure/dog_park.json
@@ -11,7 +11,7 @@
     "moreFields": [
         "{@templates/contact}",
         "{@templates/internet_access}",
-        "dog",
+        "dog_yes",
         "gnis/feature_id-US",
         "ref"
     ],
diff --git a/interim/source_strings.yaml b/interim/source_strings.yaml
index 7d4ed4cf..460b2ccc 100644
--- a/interim/source_strings.yaml
+++ b/interim/source_strings.yaml
@@ -1824,10 +1824,14 @@ en:
           leashed: Leashed Only
           # dog=no
           'no': Not Allowed
+          # dog=unleashed
+          unleashed: Leashes Not Required
           # dog=yes
           'yes': Allowed
         # 'terms: animals,pets'
         terms: '[translate with synonyms or related terms for ''Dogs'', separated by commas]'
+      dog_yes:
+        # dog=*
       door:
         # door=*
         label: Door