mirror of
https://github.com/commons-app/apps-android-commons.git
synced 2025-10-26 20:33:53 +01:00
Commons app mirror
androidcommonsgood-first-issuegsochacktoberfesthelp-wantedjavakotlinkotlin-androidphotographywikimediawikimedia-apiwikimedia-commons
c77e5abba7
This commit adds logic to classify notifications as "email" type when the notification text contains "sent you an email". It also updates the email notification prompt to support localization, ensuring a better user experience across different regions. ### Problem: 1. Previously, email-related notifications from the backend were missing a URL. As a result, when users clicked on these notifications, there was no link to open, and the notifications were categorized as UNKNOWN. This led to a poor user experience since there was no feedback provided when the user clicked on an email notification. 2. Additionally, the existing code used hardcoded English text for the email notification prompt, which did not provide a localized experience for users in different regions. ### Solution: 1. Added logic to categorize email-related notifications as `EMAIL` when the notification text contains "sent you an email". 2. Replaced the hardcoded "Check your email inbox" string with a localized string and added translations for multiple languages, including zh, zh-rhk, zh-rcn, zh-rtw, and ja. ### Changes: - **NotificationClient**: - Modified `WikimediaNotification.toCommonsNotification()` to check if the notification text contains "sent you an email". If it does, the notification is classified as `EMAIL_MESSAGE` instead of the default `UNKNOWN`. - **NotificationActivity**: - In the `NotificatinAdapter` click handler, added a check for `EMAIL_MESSAGE` type. When an email-type notification is clicked, a localized "Check your mail box" prompt is shown using `Snackbar`, instead of attempting to open a URL (which is typically missing for such notifications). - Modified to fetch the string using `getString(R.string.check_your_mail_box)` to support localization. - **NotificationType**: - Added a new `EMAIL` type to categorize email-related notifications. - **Localization**: - Added localized translations for "Check your mail box" in zh, zh-rhk, zh-rcn, zh-rtw, and ja. Co-authored-by: Qiutong Zeng <Qiutong.zeng@anu.edu.au> |
||
|---|---|---|
| .github | ||
| .idea | ||
| app | ||
| design | ||
| fastlane/metadata/android/en-US/images | ||
| gradle/wrapper | ||
| update-license-info | ||
| .gitignore | ||
| .mailmap | ||
| build.gradle | ||
| CHANGELOG.md | ||
| CONTRIBUTING.md | ||
| COPYING | ||
| CREDITS | ||
| dependency-injection.md | ||
| find-broken-strings-variables.sh | ||
| gitutils.gradle | ||
| gradle.properties | ||
| gradlew | ||
| gradlew.bat | ||
| jacoco.gradle | ||
| nr-commons.keystore.enc | ||
| play.p12.enc | ||
| README.md | ||
| RELEASE-CHECKLIST.md | ||
| settings.gradle | ||
| sign.sh | ||
Wikimedia Commons Android app
The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons. Download the app here, or view our website.
Initially started by the Wikimedia Foundation, this app is now maintained by grantees and volunteers of the Wikimedia community. Anyone is welcome to improve it, just choose among the open issues and send us a pull request! :-)
Documentation
Our documentation repository contains extensive documentation for users, contributors, and developers alike:
Contributors
Thank you all for your work!
.. and many more.
License
This software is open source, licensed under the Apache License 2.0.