apps-android-commons/app
Brigham Byerly 2be828c50e
Fixes #3694 Pre-select places as depictions (#4452)
* WikidataEditService: stop automatically adding WikidataPlace as a depiction

When the user initiates the upload process from Nearby and also manually adds the place as a depiction, the depiction is added twice. Since this behavior is invisible to the user, it is being removed in preparation for auto-selecting the place as a depiction on the DepictsFragment screen.

* DepictsFragment: auto-select place as a depiction

Pass the Place reference from UploadActivity to DepictsFragment and select the corresponding DepictedItem. Using the place id, retrieve the corresponding Entity to create and select a DepictedItem.

* UploadRepository: use Place from UploadItem to obtain a DepictedItem

Instead of passing a Place object from UploadActivity to DepictsFragment and then passing the Place object up the chain to obtain and select a DepictedItem, retrieve the Place object directly within UploadRepository

* DepictsFragment: select Place depiction when fragment becomes visible

* UploadDepictsAdapter: make adapter aware of selection state

Update selection state when recycled list items are automatically selected, preventing automatically selected items from appearing as unselected until they are forced to re-bind (i.e. after scrolling)

* DepictsFragment: pre-select place depictions for all UploadItems

If several images are selected and set to different places, pre-select all place depictions to reinforce the intended upload workflow philosophy (i.e. all images in a set are intended to be from/of the same place). See discussion in commons-app/apps-android-commons#3694

* DepictsFragment: scroll to the top every time list is updated
2021-06-17 10:09:41 +09:00
..
src Fixes #3694 Pre-select places as depictions (#4452) 2021-06-17 10:09:41 +09:00
build.gradle Added a feature for editing coordinates (#4418) 2021-06-13 12:36:47 +09:00
proguard-rules.txt [WIP] Implemented Espresso tests for upload with multilingual descriptions (#2830) 2020-03-10 12:01:22 -07:00
quality.gradle Deprecation removed 2018-05-01 17:03:59 +05:30
test-proguard-rules.txt Update to API 28, and fix CI issues. (#2595) 2019-03-15 08:30:08 +05:30