mirror of
https://github.com/commons-app/apps-android-commons.git
synced 2025-10-29 05:43:55 +01:00
d4ababc0a5
* Rename Constants to Follow Kotlin Naming Conventions >This PR refactors constant names in the project to adhere to Kotlin's UPPERCASE_SNAKE_CASE naming convention, improving code readability and maintaining consistency across the codebase. >Renamed the following constants in LoginActivity: >saveProgressDialog → SAVE_PROGRESS_DIALOG >saveErrorMessage → SAVE_ERROR_MESSAGE >saveUsername → SAVE_USERNAME >savePassword → SAVE_PASSWORD >Updated all references to these constants throughout the project. * Update Project_Default.xml * Refactor variable names to adhere to naming conventions Renamed variables to use camel case: -UPLOAD_COUNT_THRESHOLD → uploadCountThreshold -REVERT_PERCENTAGE_FOR_MESSAGE → revertPercentageForMessage -REVERT_SHARED_PREFERENCE → revertSharedPreference -UPLOAD_SHARED_PREFERENCE → uploadSharedPreference Renamed variables with uppercase initials to lowercase for alignment with Kotlin conventions: -Latitude → latitude -Longitude → longitude -Accuracy → accuracy Refactored the following variable names: -NUMBER_OF_QUESTIONS → numberOfQuestions -MULTIPLIER_TO_GET_PERCENTAGE → multiplierToGetPercentage * Refactor Dialog View Initialization with Null-Safe Calls This PR refactors the dialog setup code in CustomSelectorActivity to improve safety and readability by replacing explicit casts with null-safe generic calls for findViewById. >Replaced explicit casting (as Button and as TextView) with the generic findViewById<T>() method for improved type safety. >Added null-safety (?.) to avoid potential crashes if a view is not found in the dialog layout. why changed:- >Prevents runtime crashes caused by NullPointerException when a view is missing in the layout. * Refactor Unit Test: Replace Unsafe Casting with Type-Safe Mocking for findViewById >PR refactors the unit test for NearbyParentFragment by replacing unsafe casting in the findViewById mocking statements with type-safe >Ensured all findViewById mocks now use a consistent, type-safe format (findViewById<View>(...)) to reduce verbosity and potential casting errors. >Verified the functionality of prepareViewsForSheetPosition remains unchanged, ensuring no regression in test behavior. * Update NearbyParentFragmentUnitTest.kt * Refactor: Rename Constants to Follow CamelCase Naming Convention >Updated all constant variable names to follow the camelCase naming convention, removing underscores in the middle or end. >Ensured variable names remain descriptive and align with code readability best practices. * Replace private val with const val for URL constants in QuizController * Renaming the constant to use UPPER_SNAKE_CASE * Renaming the constant to use UPPER_SNAKE_CASE * Update Done * **Refactor: Convert `minimumThresholdForSwipe` to a compile-time constant** --------- Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com> |
||
|---|---|---|
| .. | ||
| model | ||
| AbstractTextWatcher.kt | ||
| ActivityUtils.kt | ||
| CommonsDateUtil.kt | ||
| ConfigUtils.kt | ||
| CustomSelectorUtils.kt | ||
| DateUtil.kt | ||
| DeviceInfoUtil.kt | ||
| DialogUtil.kt | ||
| DownloadUtils.kt | ||
| ExecutorUtils.kt | ||
| FragmentUtils.kt | ||
| ImageUtils.kt | ||
| ImageUtilsWrapper.kt | ||
| LangCodeUtils.kt | ||
| LayoutUtils.kt | ||
| LengthUtils.kt | ||
| LocationUtils.kt | ||
| MapUtils.kt | ||
| MediaDataExtractorUtil.kt | ||
| NearbyFABUtils.kt | ||
| NetworkUtils.kt | ||
| PermissionUtils.kt | ||
| PlaceUtils.kt | ||
| StringSortingUtils.kt | ||
| StringUtil.kt | ||
| SwipableCardView.kt | ||
| SystemThemeUtils.kt | ||
| TimeProvider.kt | ||
| UiUtils.kt | ||
| ViewUtil.kt | ||
| ViewUtilWrapper.kt | ||