From 2e52adbef8b04a2b0c1187527b3271df849a263d Mon Sep 17 00:00:00 2001 From: "Amir E. Aharoni" Date: Tue, 14 Oct 2025 18:37:17 -0400 Subject: [PATCH 1/2] Clean up empty tags in XML files (#6505) This resolves all the "XML empty tags" lint errors. --- app/src/main/res/drawable/thumbnail_not_selected.xml | 2 +- app/src/main/res/layout/dialog_select_language.xml | 2 +- .../main/res/layout/fragment_upload_media_detail_fragment.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/main/res/drawable/thumbnail_not_selected.xml b/app/src/main/res/drawable/thumbnail_not_selected.xml index 8ead4b377..50404cf47 100644 --- a/app/src/main/res/drawable/thumbnail_not_selected.xml +++ b/app/src/main/res/drawable/thumbnail_not_selected.xml @@ -1,5 +1,5 @@ - + diff --git a/app/src/main/res/layout/dialog_select_language.xml b/app/src/main/res/layout/dialog_select_language.xml index 6fa70dcdb..dcef302fc 100644 --- a/app/src/main/res/layout/dialog_select_language.xml +++ b/app/src/main/res/layout/dialog_select_language.xml @@ -16,7 +16,7 @@ android:padding="12dp" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toTopOf="parent"> + app:layout_constraintTop_toTopOf="parent" /> + android:orientation="horizontal" /> Date: Wed, 15 Oct 2025 00:52:05 -0400 Subject: [PATCH 2/2] Simplify android:gravity in two layouts (#6506) The "Inspect Code" linter complained that these two files had Right-to-left text compatibility issues. I couldn't really see any problems neither in English nor in Hebrew, but the linter's suggestion still made sense, so I cleaned it up. This fixes all the errors of the type "Android Lint: Internationalization / Right-to-left text compatibility issues". --- app/src/main/res/layout/fragment_review_image.xml | 6 ++---- app/src/main/res/layout/pic_of_day_app_widget.xml | 1 - 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/app/src/main/res/layout/fragment_review_image.xml b/app/src/main/res/layout/fragment_review_image.xml index c4e9e4f73..4a21f4df0 100644 --- a/app/src/main/res/layout/fragment_review_image.xml +++ b/app/src/main/res/layout/fragment_review_image.xml @@ -22,9 +22,8 @@ android:id="@+id/tv_review_question" android:layout_width="match_parent" android:layout_height="wrap_content" - android:gravity="center_vertical" + android:gravity="center" tools:text="testing1" - android:textAlignment="center" android:textColor="?attr/reviewHeading" android:textSize="32sp"/> @@ -33,9 +32,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginBottom="@dimen/filter_padding" - android:gravity="center_vertical" + android:gravity="center" tools:text="testing2" - android:textAlignment="center" android:textSize="22sp"/> diff --git a/app/src/main/res/layout/pic_of_day_app_widget.xml b/app/src/main/res/layout/pic_of_day_app_widget.xml index 46e00a0f4..beb3e20d4 100644 --- a/app/src/main/res/layout/pic_of_day_app_widget.xml +++ b/app/src/main/res/layout/pic_of_day_app_widget.xml @@ -35,7 +35,6 @@ android:layout_height="wrap_content" android:id="@+id/appwidget_title" android:textAlignment="center" - android:layout_gravity="bottom" android:textColor="@color/white" android:layout_marginTop="@dimen/filter_padding" android:layout_marginStart="@dimen/tiny_padding"