Compare commits

..

2 commits

Author SHA1 Message Date
Amir E. Aharoni
755d8311dc
Make some hardcoded strings translatable (#6459)
Some checks are pending
Android CI / Run tests and generate APK (push) Waiting to run
2025-10-09 10:07:19 +09:00
Amir E. Aharoni
b6457cc6b9
Rename an identifier with a non-ASCII character (#6460)
Android Studio reported that there's an identifier
with a non-ASCII letter. It was nearbyFılterStateInstance,
with a Turkish dotless i. I renamed to ASCII dotted i.

This brings the number of Internationalization
issues in Inspect Code to zero.
2025-10-09 10:06:23 +09:00
6 changed files with 13 additions and 7 deletions

View file

@ -9,7 +9,7 @@ public class NearbyFilterState {
private int checkBoxTriState;
private ArrayList<Label> selectedLabels;
private static NearbyFilterState nearbyFılterStateInstance;
private static NearbyFilterState nearbyFilterStateInstance;
/**
* Define initial filter values here
@ -23,10 +23,10 @@ public class NearbyFilterState {
}
public static NearbyFilterState getInstance() {
if (nearbyFılterStateInstance == null) {
nearbyFılterStateInstance = new NearbyFilterState();
if (nearbyFilterStateInstance == null) {
nearbyFilterStateInstance = new NearbyFilterState();
}
return nearbyFılterStateInstance;
return nearbyFilterStateInstance;
}
public static void setSelectedLabels(ArrayList<Label> selectedLabels) {

View file

@ -71,7 +71,7 @@
android:layout_alignParentRight="true"
android:layout_marginLeft="@dimen/activity_margin_horizontal"
android:layout_marginRight="@dimen/activity_margin_horizontal"
android:text="I am not sure"
android:text="@string/quiz_i_am_not_sure"
android:backgroundTint="#D6DCE0"
android:layout_marginBottom="@dimen/activity_margin_vertical" />

View file

@ -98,7 +98,7 @@
android:paddingHorizontal="@dimen/activity_margin_horizontal"
android:layout_height="wrap_content"
android:backgroundTint="#D6DCE0"
android:text="Continue" />
android:text="@string/quiz_continue" />
</RelativeLayout>
</ScrollView>

View file

@ -11,6 +11,6 @@
android:id="@+id/categories_checkbox"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:text="Don't show this message again" />
android:text="@string/upload_categories_dont_show_this_message_again" />
</LinearLayout>

View file

@ -173,7 +173,9 @@
<string name="explore_tab_title_map">{{Identical|Map}}</string>
<string name="successful_wikidata_edit">Message shown in a dialog (\"success toast\") after a contribution by the user.\n\nParameter:\n* %1$s - title of the target page on Wikidata</string>
<string name="question">{{Identical|Question}}</string>
<string name="quiz_i_am_not_sure">In the quiz, a third option in addition to "Yes" and "No".</string>
<string name="result">{{Identical|Result}}</string>
<string name="quiz_continue">Button in quiz.</string>
<string name="delete">{{Identical|Delete}}</string>
<string name="statistics">Èstatistik</string>
<string name="statistics_featured">To see the correct translation for your language, please go to https://commons.wikimedia.org/wiki/Commons:Featured_pictures and select your language in \"This project page in other languages\".</string>
@ -190,6 +192,7 @@
<string name="please_wait">{{Identical|Please wait}}</string>
<string name="exif_tag_name_author">{{Identical|Author}}</string>
<string name="exif_tag_name_location">{{Identical|Location}}</string>
<string name="upload_categories_dont_show_this_message_again">A label of a checkbox.</string>
<string name="no_depiction_found">{{Doc-commons-app-depicts}}</string>
<string name="depictions_edit_helper_make_edit_toast">{{Doc-commons-app-depicts}}</string>
<string name="depictions_edit_helper_show_edit_title">{{Doc-commons-app-depicts}}</string>

View file

@ -348,6 +348,7 @@
<string name="quiz">Quiz</string>
<string name="quiz_question_string">Is this picture OK to upload?</string>
<string name="question">Question</string>
<string name="quiz_i_am_not_sure">I am not sure</string>
<string name="result">Result</string>
<string name="quiz_back_button">If you carry on uploading images that require deletion, your account will likely be banned. Are you sure you want to end the quiz?</string>
<string name="quiz_alert_message">More than %1$s of the images you uploaded have been deleted. If you carry on uploading images that require deletion, your account will likely be banned.\n\nWould you like to view the tutorial again and then take a quiz to help you learn what type of images you should or shouldn\'t upload?</string>
@ -357,6 +358,7 @@
<string name="blurry_image_answer">One of the goals of Commons is to gather quality images. Therefore, blurry images shouldn\'t be uploaded. Always try to take nice pictures with good lighting.</string>
<string name="construction_event_answer">Pictures showing technology or culture are very welcome on Commons.</string>
<string name="congratulatory_message_quiz">You got %1$s of the answers correct. Congratulations!</string>
<string name="quiz_continue">Continue</string>
<string name="warning_for_no_answer">Select one of the two options to answer the question</string>
<string name="user_not_logged_in">Log-in expired. Please log in again.</string>
<string name="quiz_result_share_message">Share your quiz with your friends!</string>
@ -555,6 +557,7 @@ Upload your first media by tapping on the add button.</string>
<string name="share_text">Upload photos to Wikimedia Commons directly from your phone. Download the Commons App now: %1$s</string>
<string name="share_via">Share app via...</string>
<string name="image_info">Image Info</string>
<string name="upload_categories_dont_show_this_message_again">Don\'t show this message again</string>
<string name="no_categories_found">No Categories found</string>
<string name="no_depiction_found">No Depictions found</string>
<string name="upload_cancelled">Cancelled Upload</string>