Compare commits

...

3 commits

Author SHA1 Message Date
Amir E. Aharoni
ed7007fc8c
Change a hardcoded string to a translatable message (#6444)
Some checks failed
Android CI / Run tests and generate APK (push) Has been cancelled
Follow-up to #6443. Noticed this one after that pull request
was already merged.
2025-10-04 14:10:00 +09:00
Amir E. Aharoni
71ad6a2ce5
Change hardcoded preferences strings to translatable messages (#6443) 2025-10-04 10:43:54 +09:00
Amir E. Aharoni
e9a1af0f52
Change hardcoded strings in the language search dialog to messages (#6440)
Another comment: While working on this, I also noticed that
"Recent Searches" is hardcoded in the XML file, and
I'm not sure where does it actually appear. I fixed it, too,
but perhaps it can be completely removed.

Fixes #6439.
2025-10-04 10:43:10 +09:00
4 changed files with 16 additions and 6 deletions

View file

@ -12,7 +12,7 @@
android:layout_marginStart="8dp" android:layout_marginStart="8dp"
android:layout_marginTop="8dp" android:layout_marginTop="8dp"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
android:hint="Type Language Name" android:hint="@string/language_search_type_language_name"
android:padding="12dp" android:padding="12dp"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
@ -22,7 +22,7 @@
android:id="@+id/recent_searches" android:id="@+id/recent_searches"
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:text="Recent Searches" android:text="@string/language_search_recent_searches"
app:layout_constraintTop_toBottomOf="@id/search_language" app:layout_constraintTop_toBottomOf="@id/search_language"
app:layout_constraintEnd_toEndOf="@+id/language_history_list" app:layout_constraintEnd_toEndOf="@+id/language_history_list"
android:layout_marginEnd="8dp" android:layout_marginEnd="8dp"
@ -55,7 +55,7 @@
android:id="@+id/all_languages" android:id="@+id/all_languages"
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:text="All Languages" android:text="@string/language_search_all_languages"
app:layout_constraintTop_toBottomOf="@id/separator" app:layout_constraintTop_toBottomOf="@id/separator"
app:layout_constraintEnd_toEndOf="@+id/language_history_list" app:layout_constraintEnd_toEndOf="@+id/language_history_list"
android:layout_margin="8dp" android:layout_margin="8dp"

View file

@ -97,6 +97,9 @@
<string name="no_uploads_yet">Message shown on contribution list during non-first sync if no uploads present.</string> <string name="no_uploads_yet">Message shown on contribution list during non-first sync if no uploads present.</string>
<string name="menu_retry_upload">Menu item text prompting user to retry a failed upload.\n{{Identical|Retry}}</string> <string name="menu_retry_upload">Menu item text prompting user to retry a failed upload.\n{{Identical|Retry}}</string>
<string name="menu_cancel_upload">Menu item text prompting user to cancel and delete a failed upload.\n{{Identical|Cancel}}</string> <string name="menu_cancel_upload">Menu item text prompting user to cancel and delete a failed upload.\n{{Identical|Cancel}}</string>
<string name="language_search_type_language_name">Placeholder text in the top search box in the language search dialog.</string>
<string name="language_search_recent_searches">A title in the language search dialog.</string>
<string name="language_search_all_languages">A title in the language search dialog.</string>
<string name="menu_download">Menu item text prompting user to download a selected photo or media file locally.\n{{Identical|Download}}</string> <string name="menu_download">Menu item text prompting user to download a selected photo or media file locally.\n{{Identical|Download}}</string>
<string name="preference_license">{{Identical|License}}</string> <string name="preference_license">{{Identical|License}}</string>
<string name="use_previous">This is a button text. Concise wording is preferred (e.g. \"&amp;\" instead of \"and\"), where possible. It should ideally be rendered in one line, even on small devices.</string> <string name="use_previous">This is a button text. Concise wording is preferred (e.g. \"&amp;\" instead of \"and\"), where possible. It should ideally be rendered in one line, even on small devices.</string>
@ -151,6 +154,7 @@
<string name="navigation_item_notification">{{Identical|Notification}}</string> <string name="navigation_item_notification">{{Identical|Notification}}</string>
<string name="navigation_item_review">{{Identical|Review}}</string> <string name="navigation_item_review">{{Identical|Review}}</string>
<string name="upload_connection_error_alert_title">{{Identical/Connection Error}}</string> <string name="upload_connection_error_alert_title">{{Identical/Connection Error}}</string>
<string name="preferences_uploads">A section title in preferences.</string>
<string name="nominated_see_more">&lt;u&gt;See webpage for details&lt;/u&gt;</string> <string name="nominated_see_more">&lt;u&gt;See webpage for details&lt;/u&gt;</string>
<string name="skip_login">{{Identical|Skip}}</string> <string name="skip_login">{{Identical|Skip}}</string>
<string name="navigation_item_login">{{Identical|Log in}}</string> <string name="navigation_item_login">{{Identical|Log in}}</string>

View file

@ -150,6 +150,9 @@
<string name="no_uploads_yet">You have not yet uploaded any photos.</string> <string name="no_uploads_yet">You have not yet uploaded any photos.</string>
<string name="menu_retry_upload">Retry</string> <string name="menu_retry_upload">Retry</string>
<string name="menu_cancel_upload">Cancel</string> <string name="menu_cancel_upload">Cancel</string>
<string name="language_search_type_language_name">Type Language Name</string>
<string name="language_search_recent_searches">Recent Searches</string>
<string name="language_search_all_languages">All Languages</string>
<string name="media_upload_policy">By submitting this picture, I declare that this is my own work, that it does not contain copyrighted material or selfies, and otherwise adheres to &lt;a href=\"https://commons.wikimedia.org/wiki/Commons:Policies_and_guidelines\"&gt;Wikimedia Commons policies&lt;/a&gt;.</string> <string name="media_upload_policy">By submitting this picture, I declare that this is my own work, that it does not contain copyrighted material or selfies, and otherwise adheres to &lt;a href=\"https://commons.wikimedia.org/wiki/Commons:Policies_and_guidelines\"&gt;Wikimedia Commons policies&lt;/a&gt;.</string>
<string name="menu_download">Download</string> <string name="menu_download">Download</string>
<string name="preference_license">Default License</string> <string name="preference_license">Default License</string>
@ -266,6 +269,7 @@
<string name="upload_problem_image">Problems found in image</string> <string name="upload_problem_image">Problems found in image</string>
<string name="internet_downloaded">Please only upload pictures that you have taken by yourself. Don\'t upload pictures that you have downloaded from the Internet.</string> <string name="internet_downloaded">Please only upload pictures that you have taken by yourself. Don\'t upload pictures that you have downloaded from the Internet.</string>
<string name="preferences_uploads">Uploads</string>
<string name="use_external_storage">Save In-app shots</string> <string name="use_external_storage">Save In-app shots</string>
<string name="use_external_storage_summary">Save pictures taken with the in-app camera to your device storage</string> <string name="use_external_storage_summary">Save pictures taken with the in-app camera to your device storage</string>
<string name="login_to_your_account">Log in to your account</string> <string name="login_to_your_account">Log in to your account</string>
@ -461,6 +465,8 @@ Upload your first media by tapping on the add button.</string>
<string name="ends_on">Ends on:</string> <string name="ends_on">Ends on:</string>
<string name="display_campaigns">Display campaigns</string> <string name="display_campaigns">Display campaigns</string>
<string name="display_campaigns_explanation">See the ongoing campaigns</string> <string name="display_campaigns_explanation">See the ongoing campaigns</string>
<string name="show_deletion_button">Show deletion button</string>
<string name="show_deletion_button_explanation">Enable the \"Delete Folder\" button in the custom picker</string>
<string name="in_app_camera_location_access_explanation">Allow the app to fetch location in case the camera does not record it. Some device cameras do not record location. In such cases, letting the app fetch and attach location to it makes your contribution more useful. You may change this any time from the Settings</string> <string name="in_app_camera_location_access_explanation">Allow the app to fetch location in case the camera does not record it. Some device cameras do not record location. In such cases, letting the app fetch and attach location to it makes your contribution more useful. You may change this any time from the Settings</string>
<string name="option_allow">Allow</string> <string name="option_allow">Allow</string>
<string name="option_dismiss">Dismiss</string> <string name="option_dismiss">Dismiss</string>

View file

@ -55,13 +55,13 @@
android:defaultValue="false" android:defaultValue="false"
android:key="displayDeletionButton" android:key="displayDeletionButton"
app:singleLineTitle="false" app:singleLineTitle="false"
android:summary="Enable the &quot;Delete folder&quot; button in the custom picker" android:summary="@string/show_deletion_button_explanation"
android:title="Show Deletion Button" /> android:title="@string/show_deletion_button" />
</PreferenceCategory> </PreferenceCategory>
<PreferenceCategory <PreferenceCategory
android:title="Uploads"> android:title="@string/preferences_uploads">
<SwitchPreference <SwitchPreference