Commit graph

2371 commits

Author SHA1 Message Date
Aditya-Srivastav
7cb5ff9167
Fixed #4232 App crashes on trying to upload a media from gallery. (#4235)
* ExifFixed

* requested changes

* requested changes

* indentation
2021-02-17 18:38:11 +09:00
Prince kushwaha
6293f90950
fix app crash in CategoryDetailsActivity (#4233)
Thanks Prince kushwaha!
2021-02-17 16:37:29 +09:00
Prince kushwaha
2695bbaf4b
fix- #2770 -Incomplete Nearby List shown in Landscape mode (#4188)
* fix-Incomplete Nearby List shown in Landscape mode (#2270)

* fix-Incomplete Nearby List shown in Landscape mode (#2770)

* added the setLayoutParams() method

* reformed the codechange
2021-02-15 21:01:48 +03:00
Pratham Pahariya
37c39ad55f
Fixed the issue with blank screen after changing the theme. (#4220)
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-02-15 23:52:35 +09:00
Taco
38f80687b1
Remove duplicate ViewPagerAdapter (#4222) 2021-02-15 21:50:30 +09:00
Taco
ee50bc8188
Update AndroidX Browser and ExifInterface to latest version (#4223) 2021-02-15 21:35:20 +09:00
Aditya-Srivastav
1a31265770
Fixes #4215 "Swiping on the last item in explore featured tab takes you to uploaded via mobile" (#4227)
* scrolling disabled on media details

* javadoc added

* javadoc modified
2021-02-15 14:41:55 +09:00
Prince kushwaha
944bede42d
fixes - #3559 - Failed to send thanks" notification, but thank actually sent successfully
I create another Model Class->"MwThankPostResponse.java" to store the Result of Post Request POST(MW_API_PREFIX+"action=thank")
2021-02-08 16:50:30 +03:00
Prince kushwaha
8384ad03dc
fixes - #1984 -Upload count does not get updated right away post successful upload
->implements the Callback method to update total number of media uploaded
2021-02-08 15:06:16 +03:00
Adam Jones
89737b2640
#747: Convert action package (ThanksClient and PageEditClient) to Kotlin (#4075) 2021-01-23 14:36:01 +05:30
Pratham Pahariya
36406bad85
Fixed the issue with back button in contribution tab. (#4177)
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-01-22 01:30:25 +10:00
Aditya-Srivastav
b58d135b4c
Fixes #4178 Bookmarks not Updated in Picture section after remove 2021-01-20 20:35:33 +03:00
Pratham Pahariya
edef23f03d
Fixes #4159 On Explore Tab, All Available Options on toolbar in media detail view are only targeting the first media in the list.
Fixes #4159 On Explore Tab, All Available Options on toolbar in media detail view are only targeting the first media in the list.
2021-01-20 20:18:55 +03:00
Shabir Ahmad
e70fea64fb
fixed bug: App crashes on viewing review in Review Fragment #4132 (#4146)
* fixed bug:app crashes on viewing review in Review Fragment #4135
2021-01-20 18:06:08 +03:00
KushMehta1511
f3ee74d436
Update comments in ThanksClient.java (#4183) 2021-01-16 17:33:18 +05:30
Pratham Pahariya
ca82addb58
Fixed the issue with back navigation button on toolbar in explore tab. (#4175) 2021-01-15 12:42:43 +05:30
KushMehta1511
bd90497936
Updating comments in PageEditClient.java (#4170)
Description (required)

Fixes commons-app#4161
In the comments of the class PageEditClient.java "@param pagetitle" is written in three areas in this file. It should have been "@param pageTitle" with capital T as pageTitle is being passed as an argument rather than pagetitle.

What changes did you make and why?
Changes are made in the comments of fil where the parameters for Observable method are stated. pagetitle has been changed to pageTitle as the correct argument passed. This change would increase the code readability for fellow developers.
2021-01-13 13:36:18 +05:30
Aditya-Srivastav
c4bd23f7a1
Fix (#4148) Issues on theme change
* fixed themeChange crashes

* fixed comments

* Overlooked the title bar
2021-01-11 17:21:44 +03:00
Prince kushwaha
2d884b44ca
Repull request of fixes #4081 App is crash when Backbutton is pressed from Favourites Fragment(#4104)
fixes NullPointerexception in Favorities when backButton is pressed
2021-01-11 16:03:02 +03:00
neslihanturan
b06f875812
Fixes #4079 Menu item are not visible (#4145)
* Revert custom stylings of toolbar

* Enable back button on toolbar
2021-01-02 23:06:08 +10:00
Prince kushwaha
86c571ceee
fix app Crash when tapping on the nearbyNotification (#4139)
* bugfix-#4086
-> implement CallBack interface in MainActivity centerMapToPlace() function

* update previous  commit

* reformed the codechanges
2021-01-01 19:33:35 +03:00
Aditya-Srivastav
7730112807
fixed the contribution crash on scroll (#4128)
* fixed the contribution crash on scroll

* Investigation

Just to get the Log of the issue

* fixed null data causing scroll to top

* Removed unneeded log import.
2021-01-01 18:10:10 +03:00
Pratham Pahariya
e1be458821
Fixed issue with notification count. (#4126)
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-01-01 17:09:48 +03:00
Prince kushwaha
6286607fc5
fixes In nearby tab when back button is pressed nothing happen(#4096) (#4102)
* fixes #4096

* reformed the codechange

* reformed the codechange
2020-12-29 00:32:55 +09:00
Saral Verma
c461f1134c
Fixed 4115 achievement issue (#4138) 2020-12-28 20:16:13 +10:00
Pratham Pahariya
5bdb21cb3e
Fixed issue with "Copy previous captions & descriptions". (#4109)
* Fixed issue with "Copy previous captions & descriptions".

* Added comments and also fixed the styling issue.

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2020-12-27 19:48:57 +09:00
Saral Verma
170ecaa570
Used instance to solve the issue (#4108) 2020-12-27 19:12:47 +09:00
Harsh Maheshwari
1ccb3578e8
issue #3996 solved (#3999) 2020-12-22 21:22:40 +03:00
Saral Verma
b2823514ed
solved issue 4043 : overlapping (#4117) 2020-12-22 19:42:21 +03:00
FliegendeWurst
174db88ae8
Fix category links in media detail (#3957) 2020-12-22 14:34:31 +03:00
Aditya-Srivastav
a0af174d72
Erroneous data fixed (#4119) 2020-12-22 04:49:47 +10:00
Aditya-Srivastav
ae18b24e92
flickering fixed (#4095) 2020-12-17 03:19:12 +10:00
neslihanturan
9e92c95d42
Remove individual remove and add metods, use only setItems for setting items instead (#4107) 2020-12-16 01:10:05 +10:00
Vivek Maskara
5c6e777b37
Fix issue where upload notification shows up on app start (#4099) 2020-12-14 22:55:17 +10:00
Saral Verma
0415a57d34
Regarding issue 4042: bordering (#4071) 2020-12-13 00:27:06 +05:30
neslihanturan
7d8e09f708
Adds more obvious display for limited connection mode (#4094)
* Limited connection is enabled layout is added

* Add a layout to indicate limited connection is active

* fix string
2020-12-12 02:11:53 +10:00
Prince kushwaha
e581318fc6
fixes #4072 (#4074)
->add an function->setSupportActionBar()
->add some attributes
2020-12-11 01:28:03 +10:00
neslihanturan
3aa7a13ec5
Make sure exif is added if exists and not addet if null or 0.0 (#4082)
* Make sure exif is added if exists and not addet if null or 0.0

* Move boolean to bottom to cover both cases
2020-12-10 03:18:10 +10:00
Ashish
d720750ab4
Fixes invalid authorname in explore (#4054)
* Fixes #3341, #4018
* Defined two feild author and user in Media and used them at the corresponding places
Minor bug fixes
-displaying userName in uploadedBy.
-modified HTML parsing in getArtist.
-Replaced creator with author.

* Fixes #3341, #4018
* Defined two feild author and user in Media and used them at the corresponding places
Minor bug fixes
-displaying userName in uploadedBy.
-modified HTML parsing in getArtist.
-Replaced creator with author.
2020-12-01 23:56:41 +10:00
Ashish
f1b40728b2
Fixes #343 (#4057)
Removed the quantity item zero from string plural contributions_subtitle
Handled zero uplaod count from MainActivity
2020-12-01 21:08:30 +10:00
Ashish
0f9d462e6e
Fixes #4051 (#4052)
* null check on mediaDetails
2020-11-28 11:22:00 -07:00
Ashish
8a860345fe
Fixes 4019 (#4050)
Passed application context to adapter instead of the activity context
2020-11-28 11:17:22 -07:00
Anadi Kashyap
cbca290e4d
upload: made duplicate picture dialog more informative and added checkbox to never show again (#4045) 2020-11-25 20:03:37 +10:00
neslihanturan
0b5f56b682
Fixes theme change issue (#4029)
Catch Service Unregistered exception in Activity's onDestroy
2020-11-25 10:32:12 +05:30
Prince kushwaha
9375a8ba11
fixes Progress Bar Visibility change with Orientation Change and login process terminated (#4001) (#4028)
* fixes #4001
* Overrides the onSaveInstanceState method and onRestoreInstanceState method in LoginActivity.java
* In onSaveInstanceState save  ProgressDailog state or visiblity and text of TextView(errorMessage)
* In onRestoreInstanceState restore All saved Data

* Update the commit -1a92b17e37

* formatting the codechanges

* reformated the codechange
2020-11-24 03:41:02 +10:00
neslihanturan
ffdfb05d5f
Fix black map issue (#4040) 2020-11-18 05:11:34 +10:00
Anadi Kashyap
c93ab86d65
upload: added titles for each step of upload with a tooltip for futher explanation (#4030) 2020-11-17 19:14:16 +10:00
Vivek Maskara
6fa8cc627a
Increase chunk size to 1MB (#4011)
* Increase chunk size to 1MB

* Increase timeouts

* Add logs

* Enable HTTP logging

* Encode file name

* Update chunk size

* Add toast
2020-11-09 19:41:49 +10:00
neslihanturan
71d200ee41
Fixes #2843 New main screen UI in v3.0 (#3891)
* Add additional classes from 2019 hackathon implementation

* Make first tab work

* Make explore tab work

* Handle back button for contrib and nearby

* Fix framelayout and nav bar allignment

* Fix nav bar tint

* Fix nearby card layout

* Make contributions number visible

* Change menu icon according to fragment

* Make notification icon work and remove drawer

* Make favourites accessible from nav bar

* Turn bookmark and explore activities into fragments

* Use bottom sheet instead of more fragment

* Add actions

* Remove unused classes

* Fix indentation

* remove more fragment title

* Fix explore fragment indentation

* Make toolbar settings as we wanted

* Set card view styles

* Make colors for explore actiivty

* Remove drawer from achievements activity

* Add back button to achievements activity

* remove drawer from review activity

* Remove drawer from settings activity

* Remove drawer from about activity

* Fix dagger injection of fragment

* Implement skip login version

* Add theme missing colors

* Add style to moresheet

* refactor name

* call login with button

* Remove all old bookmarks activity dependency

* Make explore tab items clickable

* Do nothing if same tab is selected

* Fix notification icon color for dark theme

* Fix wrong drawable colors

* Handle back button after media details is visible from contrib and explore fragments

* make favourites open media details

* Fix profile icon

* Make user name visible instead

* Move user back to contrib fragment

* Remove NavigationBaseAvticity

* Fix typo in bookmark fragment

* Fix menu button colors

* Remove explore activity

* remove drawer and dependencies

* Make bookmark media details visible

* Cleanup code

* Code cleanup

* Remove unused layout

* Make contriblist UI look like in mockups

* Change limited connecton toggle

* Move list menu item to nearby fragment

* Fix search button crash

* Make media detail appear

* Back button added

* Fix back button npe

* Change bookmark list view

* Fix always the firs item displayed issue

* Allign contrib list bottom line to simple drawee bottom

* fix fragment string

* Fix back button for mobile uploads

* Make lists appear

* Make fav item selected

* Make favourites clickable

* Add back button to media details

* Add toolbar of notification activity

* Change contributions icon

* Fix card UI

* Fix back button in explore

* Make card views look similar to mockups

* Solve campaign bug visible issue

* Make borders a little softer
2020-11-07 02:04:04 +10:00
Rebecca Rothschild
ee3e52d0c6
#3980 Hitting "My Rank" button from a list position below your rank on leaderboard takes you to the person ranked below you (#3990)
* Refactored scrollToUserRank to account for users scrolling from below their rank

* Refactored my change to use a similar method

* Added comments to change

* Removed leftover cruft

* Reverted package updates

* Added tests for the LeaderBoard UI
2020-10-28 23:21:58 +09:00