Commit graph

1558 commits

Author SHA1 Message Date
Sean Nemann
fcfae643c3 Updated isUserBlocked method to check the expiration time instead of just if an expiration time exists. Updated tests accordingly 2018-06-04 11:48:07 -04:00
Sean Nemann
01a3a233a9 Added comments to isUserBlocked method and tests for the method 2018-06-04 11:48:05 -04:00
Sean Nemann
39096cf30b Upon creating AuthenticatedActivity, now checking if the user is blocked via api call and notifying the user if they are blocked via snackbar 2018-06-04 11:48:02 -04:00
Vivek Maskara
bcbf0db1ff Add option to set image as wallpaper (#1535)
* Add option to set image as wallpaper

* Added java docs

* Toast message on setting the wallpaper successfully
2018-05-30 20:11:36 +10:00
neslihanturan
2bd3c318f9
Merge pull request #1562 from ujjwalagrawal17/featured_image_bug
Fixes #1518  (fixed Featured image back button bug)
2018-05-29 10:35:16 +03:00
Ujjwal Agrawal
ab2e8c5919 Javadocs added 2018-05-28 15:14:52 +05:30
Ujjwal Agrawal
89418403f9 fixed featured image back bug 2018-05-28 14:16:29 +05:30
Paul Hawke
a66a0e8ca0 Refactoring to extract GpsCategoryModel and ensure single-responsibility-principle is maintained in CategoryApi. 2018-05-25 01:55:03 -05:00
Paul Hawke
c7948c817b Extracted a few networking related items into a new Dagger module and finished the process of mocking the main component for tests. 2018-05-25 01:50:35 -05:00
Paul Hawke
32cb8df9ae Consolidate the networking libraries - drop volley in favor of OkHttp 2018-05-25 01:42:12 -05:00
ShridharGoel
2255bd9a56 Fix for issue #1508 (#1512)
* Made changes to the error message when user enters wrong login credentials.

* Used a single string for the error message when user enters wrong login credentials.
2018-05-24 16:27:13 +03:00
Vivek Maskara
2a0b9d8a0b Enable crosswiki notifications and minor UI fixes in displaying notif… (#1540)
* Enable crosswiki notifications and minor UI fixes in displaying notifications

* Added java docs
2018-05-24 15:54:31 +03:00
Vivek Maskara
41acb76bd8 Show nominate for deletion only for own uploads (#1541) 2018-05-24 15:34:04 +03:00
neslihanturan
32d36944fc
Revert "Wmhack2018 (#1536)" (#1539)
This reverts commit 01cb9ccd70.
2018-05-19 23:02:29 +03:00
Elliott Eggleston
01cb9ccd70 Wmhack2018 (#1536)
* Add new activity to manifest

* Create review activity layout base

* Add a new menu item to drawer for peer review

* Add a top menu with randomizer icon to review activity

* Add strings for review button

* Add activity to ActivityBuilderModule for injection

* Add a new drawer item to start review acitivty

* Create base of the Review Activity

* Add fragment pager

* Add new fragment for injection

* Create a fragment pager layout

* Wikimedia hackathon 2018 (#1533)

* First draft of fn to get random recent image

* Use log entries for requests to beta, try to connect refresh button

FIXME: runs http request on main thread, breaks

* Tweak button connection

* Add ReviewController class

* Fix fragments

* Wmhack2018 (#1534)

* tiny fixes

* Load pictures into activities

* Re-use same class for all review fragments (#1537)

And try to add pager indicator

* [WIP] category check

* [WIP] add on-click actions to ReviewActivity

* [WIP] add SendThankTask

* Make it beautiful

* Use standalone category extraction code in MediaDataExtractor

* Add categories to category review page
2018-05-19 23:00:06 +03:00
Vivek Maskara
0cfcd4e942
Merge pull request #1505 from ashishkumar468/feature/switch_to_butterknife
Feature/switch to butterknife
2018-05-19 10:29:28 +05:30
Vivek Maskara
d891b8f310 Fix security exception crash while accessing network location provider (#1498)
* Fix security exception crash while accessing network location provider

* Added java docs
2018-05-15 17:25:37 +10:00
Ashish Kumar
b6e4fb2d68 Bug fix #1504 (#1506)
* Bug fix #1504

* Filtered messages with ConnectException [issue #1504]

* A generalised message for exceptions in Nearby Activity [issue #1504]
2018-05-12 16:49:43 +05:30
Ashish
66b275b19d Implemented butterknife in SimilarImageFragment [issue #1491] 2018-05-10 14:16:08 +05:30
Ashish
8f76dd0b61 Implemented butterknife in ShareActivity [issue #1491] 2018-05-10 13:32:03 +05:30
Ashish
2d1f166ac7 Implemented butterknife in MultipleUploadListFragment [issue #1491] 2018-05-09 17:57:59 +05:30
Ashish Kumar
d960029775 Feature/switch to butterknife (#1494)
* Implemented butterknife in MediaDetailFragment [issue #1491]

* Implemented butterknife in MediaDetailPagerFragment [[issue #1491]]

* post merge upstream master wip [[issue #1491]]
2018-05-08 09:51:13 +03:00
neslihanturan
2a98bd21ce Add nearby tutorial (#1467)
* Add dependency for MaterialShowcase

* Add actionview class to get a reference to material showcase

* Create a NearbyMaterialShowcaseSequence class

* Apply sequence steps

* Add first three steps of nearby showcase

* Add sequence id constants to make sure they will be displayed only once

* Add last step of sequence to explain plus fab

* Create an object to prevent customize all sequences every time

* Fix typo

* Code cleanup

* Add strings to strings.xml

* Code cleanup

* Revert irrelevant change

* Revert irrelevant change

* Remove showcaseview for recenter button

* Use single showcaseView instead of sequence

* Add single showcase view insted of sequence to be able to edit text style

* Make sure it will be displayed only once

* Cleanup

* Update strings

* Change dismiss text style
2018-05-07 22:05:20 +10:00
Tanvi Dadu
4f6b791c93 Open map of place where picture was taken (#1360)
* Intent to map added

*  Merge conflicts resolved

*  Added the functionality to hide FAB incase of null coordinate

*  Merge Conflict resolved

*  Improve pr quality

* Improve Quality

*  Added nested FAB animations

* Nested FAB implemented

*  Improve Quality

*  Added up arrow

*  Javadocs Added
2018-05-07 12:57:59 +03:00
Man Parvesh Singh Randhawa
bd86dde444 resolves #1464 : MediaDataExtractor is making inefficient (redundant) server calls (#1496) 2018-05-07 12:32:11 +03:00
Vivek Maskara
9845a6265d Integrate API for displaying featured images (#1456)
* Integrate API for displaying featured images

* Add pagination and refactor code so that it can be reused for category images

* Add license info to the images

* Fix author view

* Remove unused values

* Fix minor issues with featured images

* Fix null license url issue

* Remove some log lines

* Fix back navigation issue

* fix tests

* fix test inits

* Gracefully handling various error situations

* Added java docs
2018-05-07 11:09:23 +03:00
Ujjwal Agrawal
693c37f2ec Updated share feature (#1474) 2018-05-04 12:56:13 +03:00
Ujjwal Agrawal
d3597b80a6 Added hideKeyboard in ViewUtil (#1488) 2018-05-03 02:47:56 +05:30
neslihanturan
35f05be8df
fix memory leaks (they happened due to hiding keyboard) and lint null pointer warnings in the same code (#1471) 2018-04-30 14:42:19 +03:00
Balakrishnan S
6d2c41b91e Help button (#1415)
* Help button added to tutorial

* debug typo removed

* Help changed to more info

* More option moved to bottom

* Alignment changes made
2018-04-30 14:31:27 +03:00
Abhishek Poonia
0223c5ab76 Error messages in LoginActivity persist after orientation change. (#1407) 2018-04-30 14:27:35 +03:00
neslihanturan
3c2cc26d3b
Fix conflicts from #1366 fixing lint issues (#1470)
* lint issue #171 - added Locale.getDefault()

* lint issue #171 - added Locale.getDefault()

* lint issue #171 - added %d

* lint issue #171 - Changed version

* lint issue #171 - added singleLine="true"

* lint issue #171 - changed commit to apply

* lint issue #171 - added Locale.getDefault()

* lint issue #171 - added Locale.getDefault()

* Codacy issues #778 - nested if loop

* Codacy issues #778 - nested if loop

* Revert "lint issue #171 - added %d" since we dont edit translated string files

This reverts commit e4917cddcf.
2018-04-30 14:05:47 +03:00
Mansi Agarwal
f80311d9f6 fixed crash while uploadiing certain images (#1388) 2018-04-30 13:49:03 +03:00
Ujjwal Agrawal
b017d1c99a Changed webview to Custom Tabs in Settings Page (#1328)
* Changed Webview to Custoom tabs in Settings Page

* Get COntext changed to getActivity
2018-04-30 12:24:37 +03:00
Tanvi Dadu
9c91d7a799 Zoom (#1300)
*  Basic Zoom feature added along with button to control it

*  Pinch Zoom added

*  Merge Conflicts Resolved

*  Icons Changed

*  Compressed the high resolution images

* Fixed null pointer exception

* Fixed null pointer exception

*  Fixed exception

*  Fixed error

*  Fixed Resource availability issue
2018-04-26 03:18:58 +05:30
Vivek Maskara
fed9b1dc00
Merge pull request #1461 from misaochan/remove-author
Remove author Javadocs for FeaturedImagesListFragment.java
2018-04-25 02:28:33 +05:30
misaochan
fab3d32a8c Remove author Javadocs for FeaturedImagesListFragment.java
As mentioned at #1451 . Travis will fail prior to merge of #1460
2018-04-24 01:31:24 +10:00
misaochan
d252275b7c Fix error during merge conflict resolution 2018-04-23 21:56:48 +10:00
misaochan
d6a4188cb1 Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release'
# Conflicts:
#	app/src/main/java/fr/free/nrw/commons/nearby/NearbyActivity.java
2018-04-23 20:14:21 +10:00
Vivek Maskara
b108dff460
Merge branch 'master' into featuredImages 2018-04-19 23:44:33 +05:30
kamilya35231
108ca26967 Fix for #1437 :Button that opens Google Maps shows always only the coordinates of the first chosen mark (#1446) 2018-04-19 23:50:23 +10:00
Vivek Maskara
8b118b309c Fix loading issue after upgrade from older version (#1454) 2018-04-19 12:52:58 +03:00
Josephine Lim
3b129a6ea4 Fix security exception (Nearby places not loading after permissions granted) (#1440)
* Update changelog.md

* Versioning for v2.7.0

* Add logging to onPermissionsRequestResult

* Request location updates onStatusChanged

* Copy onResume() actions into onPermissionsRequestResult

* Added getLastKnownLocation method and hooked it up to refreshView

* Remove unnecessary calls, add more logging

* Add check to prevent NPE

* Check that curLatLng exists before getting Mapbox instance

* Moar logging

* Make curLatLang clearer

* Not a good hack - put curLatLang into the bundle separately

* Add TODO

* Rename variables for clarity

* Check for Network Provider as well, tidy up getLKL()

* Add Javadocs

* Remove unnecessary method in onStatusChanged

* Add checkGPS comment

* Remove unnecessary logs

* Add TODO

* Call bundle.clear() before inserting CurLatLng
2018-04-18 14:30:13 +03:00
brok85
01a11a95ea Fix for issue #1436 list icon allows user only to show the list, but not to make it disappear (#1443)
* Fixed by using a boolean variable "opened" that changes according to the current state of the list. It is false by default when you open the nearby activity.

* Fixed by using bottomSheetBehavior.getState() to decide whether to expand or collapse the bottom list.
2018-04-17 16:12:04 +03:00
Anubhav Gupta
d3071718b4 Changes made (#1447) 2018-04-17 15:52:53 +03:00
misaochan
4285b5e77f Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release' 2018-04-17 18:58:35 +10:00
Balakrishnan S
f8fb9f1ce9 fixed typo in nearbyActivity (#1394) 2018-04-16 15:51:59 +03:00
Gabriela Radu
9a3b6fc964 Deletion button being disabled (#1403)
* used CDATA

* Improvements in Notification Activity (#1374)

* Improvements in Notification Activity

* Update NotificationActivity.java

* Share feature (#1338)

* added share app feature in About

* added share app feature in About

* a small fix

* Use custom tabs for nearby web views (#1347)

* Localisation updates from https://translatewiki.net.

* Fix for issue #1380 Improved Notification UI (#1387)

* Links added to TextView about_upload_to in aboutActivity (#1326)

*  Added the link in about_upload_to textfield

*  Merge conflicts resolved

*  Removed the extra textView

* Fix re-enabling delete button if the action is canceled.

* Keep delete button enabled until a reason is given.
2018-04-16 15:03:24 +03:00
kamilya35231
35a7d49590 Fix for #1437 :Button that opens Google Maps shows always only the coordinates of the first chosen mark (#1446) 2018-04-16 14:37:04 +03:00
neslihanturan
482b06ccf0 Hot fix connectivity leak (#1432)
* Fixed bug #1399

* Changed visibility from visible to gone

* Changed behaviour according to review

* Changed bottom sheet visibility from visible to gone

* Fix memory leak causing usage of activity as context
2018-04-11 19:40:13 +10:00