Commit graph

249 commits

Author SHA1 Message Date
Paul Hawke
fb30a34478 Merge branch 'master' into dependency-injection 2017-11-30 21:41:38 -06:00
Paul Hawke
ce32505ca3 Created a Robolectric unit test replacement for the NearbyActivity test. 2017-11-29 21:29:09 -06:00
Paul Hawke
02b5b9b680 Merge branch 'master' into dependency-injection 2017-11-24 22:30:08 -06:00
misaochan
f96169baa7 Changed to refreshView 2017-11-23 21:32:26 +10:00
misaochan
7a50a7dbdf Call setupPlaceList onResume 2017-11-23 18:31:57 +10:00
maskara
b6441ef89f Lock location after the list is loaded once 2017-11-23 02:38:24 +05:30
maskara
a61124a580 Fix: Location update in nearby activity 2017-11-22 01:11:02 +05:30
maskara
c97f39fcdf Dispose observable for places 2017-11-13 23:16:27 +05:30
maskara
a59bf1bc4b make location manager singleton 2017-11-13 23:15:53 +05:30
maskara
d4bafd94e0 Fixes leaks in contribution and nearby activity 2017-11-13 23:15:53 +05:30
Sergey Kozelko
bd5b95040d Force request radius to be no larger than MAX_RADIUS, thus always make request 2017-10-27 20:02:39 +03:00
Sergey Kozelko
dd4e7c3aa0 Fixed bug when there are places nearby but none are loaded 2017-10-27 14:15:25 +03:00
Neslihan
9d6d773b33 Set progress bar visible on refresh 2017-10-24 01:28:19 +03:00
Neslihan
959c581b79 Refresh current location on refreshView() 2017-10-23 18:11:11 +03:00
Paul Hawke
f134d23ecb Merge branch 'master' into dependency-injection 2017-10-21 17:20:56 -05:00
Martin Entwistle
069bca6f22 Refactor based on review comments. 2017-10-10 22:28:47 +01:00
Martin Entwistle
47adcbc5e4 Corrected code style issue. 2017-10-10 22:25:27 +01:00
Martin Entwistle
0b01efa2c3 Corrected code style issues. 2017-10-10 22:25:07 +01:00
Martin Entwistle
276f4dc94b Method rename. 2017-10-10 22:21:40 +01:00
Martin Entwistle
30104af6a0 Introduced a view mode and shared preference to determine which style of view to use. 2017-10-10 22:21:40 +01:00
Vishan Seru
6b96b65203 Synced branch to master 2017-10-10 19:51:29 +05:30
Paul Hawke
9aa021695b @Injected shared preferences where needed 2017-09-27 21:30:41 -05:00
Paul Hawke
e33febf506 Merge branch 'master' into dependency-injection 2017-09-23 14:24:34 -05:00
Paul Hawke
a208c9f273 Further reduced coupling between classes and the need to @Inject the account utils class, fixed imports. 2017-09-10 10:37:58 -05:00
Vishan Seru
11f9511495 When location permission request is denied in NearbyActivity, instead of the NoPermissionsFragment, now an AlertDialog is shown providing options to either retry the permission request or cancel and quit the activity. 2017-09-05 20:53:55 +05:30
Paul Hawke
15107e622b Codacy suggestions for improvement. 2017-09-03 22:20:52 -05:00
Paul Hawke
13e84a82b8 Removed unused imports. 2017-09-03 17:05:37 -05:00
Paul Hawke
388f588301 Correctly configured injection for fragments and services. 2017-08-26 08:57:16 -05:00
Paul Hawke
cfe17cafa6 Moved other singletons over to being managed by Dagger 2017-08-26 08:57:15 -05:00
Paul Hawke
ed1ae98d8e Finished removing coupling between classes around the getInstance() method. 2017-08-26 08:56:15 -05:00
Paul Hawke
8fe2816ca9 First baby steps into the world of dependency injection using Dagger. 2017-08-26 08:56:14 -05:00
mebr1416
0c303298b2 Resolve for "Day mode by default #825" 2017-08-04 18:40:22 +03:00
Paul Hawke
02315c2ae7 Propagated the @NonNull annotation for place click listener and removed a test that made no sense. 2017-07-22 18:08:56 -05:00
Paul Hawke
4796557fb7 Made a pass through the code to introduce lambdas / method references in the places the Android Studio suggested. 2017-07-22 18:04:40 -05:00
Mikel
e9d77a0716 Use vector icons for nearby-map markers (#786) 2017-07-22 10:01:08 +09:00
Yusuke Matsubara
3b728ca568 Coding style fixes 2017-07-16 15:13:40 +09:00
Josephine Lim
0da51457d0 Merge pull request #771 from tised/#739_issue
fix for #739
2017-07-14 02:17:48 +10:00
Dmytro Vodnik
0ce99bc10e improvements for #657 issue 2017-07-13 16:26:07 +03:00
Dmytro Vodnik
719b30be85 fix for #739 2017-07-13 12:04:51 +03:00
Paul Hawke
9387d31cb6 Improvements based on codacy-bot feedback. 2017-07-09 17:52:50 -05:00
Paul Hawke
6ccc608a1e Converted nearby list to recycler view and fixed a few issues pointed out by static code analysis. 2017-07-09 17:33:24 -05:00
veyndan
3509b0a413 Remove redundant call to method 2017-06-30 20:19:25 +01:00
Yusuke Matsubara
b83c32f81e Merge pull request #742 from veyndan/place
Use an enum for the place description
2017-06-30 16:46:26 +09:00
veyndan
5d6bada4c8 Use an enum for the place description 2017-06-29 15:11:24 +01:00
Yusuke Matsubara
f8bb106b83 Merge pull request #745 from veyndan/string-sanitation
Simplify string sanitation logic
2017-06-28 09:15:10 +09:00
veyndan
8c3adbbb97 Simplify string sanitation logic 2017-06-19 17:02:16 +01:00
veyndan
dc01dfa014 Prevent instantiation of a class with a builder 2017-06-19 16:23:09 +01:00
misaochan
7d5469dcfa Add null check for nearbyAsyncTask 2017-06-03 12:40:27 +10:00
misaochan
8e059691f9 Tidy up code 2017-06-02 18:27:39 +10:00
misaochan
6091cc7465 Remove addToBackStack
We do not actually want users to go back to this fragment
2017-06-02 18:26:05 +10:00