Commit graph

581 commits

Author SHA1 Message Date
Nicolas Raoul
fa13c1b4f8 Merge branch 'fix_skip_login_nearby_bug' of github.com:ujjwalagrawal17/apps-android-commons 2018-08-08 16:07:22 +09:00
Nicolas Raoul
e00f69a23d Merged from 2.8-release 2018-08-08 15:07:51 +09:00
Ujjwal Agrawal
825a529003 Changed default value of skip login to false 2018-08-07 23:12:28 +05:30
Vivek Maskara
b5e90bea76 Wikidata edit fix (#1800)
Wikidata edit fix
2018-08-07 19:03:59 +10:00
Nicolas Raoul
f12f1d50a3 Merge branch 'skip_login' of github.com:ujjwalagrawal17/apps-android-commons 2018-08-07 13:12:00 +09:00
neslihanturan
d29aa2e2e5 Fix urgent crashes A and E (#1749)
* Create utility class for contribution process

* implement method to save five from given URİ

* Add file utilities for directory checks

* Add ContributionUtils for saving file during upload

* Change method call acordingly with handleImagePicked() method

* Call method to save file temproarily when a photo to upload is chosen from contributions list.

* Call method to save file temproarily when a photo to upload is chosen from nearby list and map

* Arrange method call

* Write a method to save file temporarily during upload process. It will save the file to a internal path and it will be deleted by another method after upload process is done.

* Add a method to save a file to a given path from a content provider Uri

* On openAssetFileDescriptor method, use URi from temporarily saved file, instead of Contributions.getLocalUri which was Uri from content provider

* Edit uploadContribution method so that it will use FileInputStream from temporarily saved file, insdeat of the Uri from content provider.

* Make it work

* Code cleanup

* Add directory cleaner method

* Call temp directory cleaner method at the end of uplpoad process

* Use FileInputStream insted

* Add directory cleaner method

* Add file removal method

* Use external directory instead

* Make destination file name flexible

* Make it work with share action coming from another activity

* Make it work for Multiple hare Activity

* Code cleanup

* Solve camera issue

* Fix camera crash

* Cleanup

* Revert change of commenting out posibly useles code, because I am not sure if it is useless or not. Requires discussion

* Use timestamp in temoorary file names, so that we wont never create same file and access old file reference. It was a weird problem though

* Code cleanup

* Add nullable annotation to handleImagePicked method uri parameter

* Add Nullable anotation to method

* Code cleanup

* Bugfix: use uri.getPath() instead uri.toString

* Remove unecesarry file saving operation, which was added accidentally

* Fix travis fail

* Remove temp file if upload gets failed and file is still there

* Code cleanup:Remove unused parameters from removeTempFile method

* Empty temp directory on app create, in case some of files are still there

* Add null check to array to prevent NPE on first run

* Fix multiple uploads bug

* Remove file if upload is succeed

* Add external storage utility methods

* Check external file permission before saving files temporarily

* finish activity if permission is not granted

* Add log lines

* Remove files even if user decides to go back without sharing

* Add easy null check

* Change storage permission settings in singe upload fragment too

* Finish app if permission is not granted

* Code optimisation

* Remove temp file if upload process never is finalised on activity stop

* Bugfix maybe contribution is never created

* Fix travis build
2018-08-02 06:24:08 +10:00
Ujjwal Agrawal
987fff0c38 Javadocs added 2018-07-31 12:40:12 +05:30
Ujjwal Agrawal
68165c7ea6 redirecting to category images Actovoty instead of Nearby now 2018-07-31 12:05:48 +05:30
misaochan
f1f41e59f7 Merge remote-tracking branch 'refs/remotes/origin/2.8-release' 2018-07-11 00:45:02 +10:00
Vivek Maskara
b2a150a3ae Fix issue where Wikidata edits were not happening (#1682)
* Added logs to debug wikidata edits

* Minor changes in logs
2018-07-05 20:13:37 +10:00
dlsrks1021
e8b2dd7163 remove unused imports (#1606) 2018-06-21 07:28:27 +09:00
misaochan
a9ae072c73 Merge remote-tracking branch 'refs/remotes/commons-app/master' into upload-overhaul-fork
# Conflicts:
#	app/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java
2018-06-05 18:28:41 +10:00
Vivek Maskara
4815e93fc9 Make P18 edits to corresponding wikidata entity on uploading from Nearby (#1495)
* Localisation updates from https://translatewiki.net.

* Integrate API for displaying featured images (#1456)

* Integrate API for displaying featured images

* Add pagination and refactor code so that it can be reused for category images

* Add license info to the images

* Fix author view

* Remove unused values

* Fix minor issues with featured images

* Fix null license url issue

* Remove some log lines

* Fix back navigation issue

* fix tests

* fix test inits

* Gracefully handling various error situations

* Added java docs

* Update pull_request_template.md (#1476)

* Update pull_request_template.md

* Remove Javadocs mention

* Added required/optional notes

* resolves #1464 : MediaDataExtractor is making inefficient (redundant) server calls (#1496)

* Open map of place where picture was taken (#1360)

* Intent to map added

*  Merge conflicts resolved

*  Added the functionality to hide FAB incase of null coordinate

*  Merge Conflict resolved

*  Improve pr quality

* Improve Quality

*  Added nested FAB animations

* Nested FAB implemented

*  Improve Quality

*  Added up arrow

*  Javadocs Added

* Add nearby tutorial (#1467)

* Add dependency for MaterialShowcase

* Add actionview class to get a reference to material showcase

* Create a NearbyMaterialShowcaseSequence class

* Apply sequence steps

* Add first three steps of nearby showcase

* Add sequence id constants to make sure they will be displayed only once

* Add last step of sequence to explain plus fab

* Create an object to prevent customize all sequences every time

* Fix typo

* Code cleanup

* Add strings to strings.xml

* Code cleanup

* Revert irrelevant change

* Revert irrelevant change

* Remove showcaseview for recenter button

* Use single showcaseView instead of sequence

* Add single showcase view insted of sequence to be able to edit text style

* Make sure it will be displayed only once

* Cleanup

* Update strings

* Change dismiss text style

* CONTRIBUTING: fix formatting of the gist of the guidelines (#1453)

* CONTRIBUTING: fix formatting of the gist of the guidelines

First level headings for a gist seems to be overkill.

So, replace first level headings with an ordered-list which
sounds more meaningful.

* CONTRIBUTING: specify clearly that 'blame' is a feature of "Git"

The contributing file specifies about the ability to know who wrote
something without the need of @author javadoc tags but incorrectly
attributes the feature to GitHub.

Correctly attribute the feature to where it belongs, Git, and specify
the name of the feature to help users easily take advantage of it.

* Feature/switch to butterknife (#1494)

* Implemented butterknife in MediaDetailFragment [issue #1491]

* Implemented butterknife in MediaDetailPagerFragment [[issue #1491]]

* post merge upstream master wip [[issue #1491]]

* Localisation updates from https://translatewiki.net.

* Bug fix #1504 (#1506)

* Bug fix #1504

* Filtered messages with ConnectException [issue #1504]

* A generalised message for exceptions in Nearby Activity [issue #1504]

* Localisation updates from https://translatewiki.net.

* Fix security exception crash while accessing network location provider (#1498)

* Fix security exception crash while accessing network location provider

* Added java docs

* Localisation updates from https://translatewiki.net.

* Log P18 edits to wikidata corresponding wikidata entity on uploading a nearby image

* Added java docs

* Fix test build

* Refresh nearby

* Refresh nearby list on successful edit

* Java docs

* Make authenticated wikidata edits

* Updated toast message to show entity name that was edited
2018-05-31 11:00:17 +10:00
misaochan
104cb5f1d7 Change references to upload.FileUtils 2018-05-25 22:50:22 +10:00
misaochan
41673c0067 Unify FileUtils.java, misleading to have 2 of it in different packages 2018-05-25 22:48:47 +10:00
Vivek Maskara
f99363c06c Fix security exception crash while accessing network location provider (#1498)
* Fix security exception crash while accessing network location provider

* Added java docs
2018-05-18 16:52:11 +05:30
Ashish Kumar
8bdc4f6b95 Bug fix #1504 (#1506)
* Bug fix #1504

* Filtered messages with ConnectException [issue #1504]

* A generalised message for exceptions in Nearby Activity [issue #1504]
2018-05-18 16:52:11 +05:30
neslihanturan
8eed630ee5 Add nearby tutorial (#1467)
* Add dependency for MaterialShowcase

* Add actionview class to get a reference to material showcase

* Create a NearbyMaterialShowcaseSequence class

* Apply sequence steps

* Add first three steps of nearby showcase

* Add sequence id constants to make sure they will be displayed only once

* Add last step of sequence to explain plus fab

* Create an object to prevent customize all sequences every time

* Fix typo

* Code cleanup

* Add strings to strings.xml

* Code cleanup

* Revert irrelevant change

* Revert irrelevant change

* Remove showcaseview for recenter button

* Use single showcaseView instead of sequence

* Add single showcase view insted of sequence to be able to edit text style

* Make sure it will be displayed only once

* Cleanup

* Update strings

* Change dismiss text style
2018-05-18 16:52:11 +05:30
Vivek Maskara
d891b8f310 Fix security exception crash while accessing network location provider (#1498)
* Fix security exception crash while accessing network location provider

* Added java docs
2018-05-15 17:25:37 +10:00
Ujjwal Agrawal
ed241e09f7 resolving Login page switching issue 2018-05-14 16:55:08 +05:30
Ashish Kumar
b6e4fb2d68 Bug fix #1504 (#1506)
* Bug fix #1504

* Filtered messages with ConnectException [issue #1504]

* A generalised message for exceptions in Nearby Activity [issue #1504]
2018-05-12 16:49:43 +05:30
neslihanturan
2a98bd21ce Add nearby tutorial (#1467)
* Add dependency for MaterialShowcase

* Add actionview class to get a reference to material showcase

* Create a NearbyMaterialShowcaseSequence class

* Apply sequence steps

* Add first three steps of nearby showcase

* Add sequence id constants to make sure they will be displayed only once

* Add last step of sequence to explain plus fab

* Create an object to prevent customize all sequences every time

* Fix typo

* Code cleanup

* Add strings to strings.xml

* Code cleanup

* Revert irrelevant change

* Revert irrelevant change

* Remove showcaseview for recenter button

* Use single showcaseView instead of sequence

* Add single showcase view insted of sequence to be able to edit text style

* Make sure it will be displayed only once

* Cleanup

* Update strings

* Change dismiss text style
2018-05-07 22:05:20 +10:00
misaochan
d252275b7c Fix error during merge conflict resolution 2018-04-23 21:56:48 +10:00
misaochan
d6a4188cb1 Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release'
# Conflicts:
#	app/src/main/java/fr/free/nrw/commons/nearby/NearbyActivity.java
2018-04-23 20:14:21 +10:00
kamilya35231
108ca26967 Fix for #1437 :Button that opens Google Maps shows always only the coordinates of the first chosen mark (#1446) 2018-04-19 23:50:23 +10:00
Josephine Lim
3b129a6ea4 Fix security exception (Nearby places not loading after permissions granted) (#1440)
* Update changelog.md

* Versioning for v2.7.0

* Add logging to onPermissionsRequestResult

* Request location updates onStatusChanged

* Copy onResume() actions into onPermissionsRequestResult

* Added getLastKnownLocation method and hooked it up to refreshView

* Remove unnecessary calls, add more logging

* Add check to prevent NPE

* Check that curLatLng exists before getting Mapbox instance

* Moar logging

* Make curLatLang clearer

* Not a good hack - put curLatLang into the bundle separately

* Add TODO

* Rename variables for clarity

* Check for Network Provider as well, tidy up getLKL()

* Add Javadocs

* Remove unnecessary method in onStatusChanged

* Add checkGPS comment

* Remove unnecessary logs

* Add TODO

* Call bundle.clear() before inserting CurLatLng
2018-04-18 14:30:13 +03:00
brok85
01a11a95ea Fix for issue #1436 list icon allows user only to show the list, but not to make it disappear (#1443)
* Fixed by using a boolean variable "opened" that changes according to the current state of the list. It is false by default when you open the nearby activity.

* Fixed by using bottomSheetBehavior.getState() to decide whether to expand or collapse the bottom list.
2018-04-17 16:12:04 +03:00
misaochan
4285b5e77f Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release' 2018-04-17 18:58:35 +10:00
Balakrishnan S
f8fb9f1ce9 fixed typo in nearbyActivity (#1394) 2018-04-16 15:51:59 +03:00
Gabriela Radu
9a3b6fc964 Deletion button being disabled (#1403)
* used CDATA

* Improvements in Notification Activity (#1374)

* Improvements in Notification Activity

* Update NotificationActivity.java

* Share feature (#1338)

* added share app feature in About

* added share app feature in About

* a small fix

* Use custom tabs for nearby web views (#1347)

* Localisation updates from https://translatewiki.net.

* Fix for issue #1380 Improved Notification UI (#1387)

* Links added to TextView about_upload_to in aboutActivity (#1326)

*  Added the link in about_upload_to textfield

*  Merge conflicts resolved

*  Removed the extra textView

* Fix re-enabling delete button if the action is canceled.

* Keep delete button enabled until a reason is given.
2018-04-16 15:03:24 +03:00
kamilya35231
35a7d49590 Fix for #1437 :Button that opens Google Maps shows always only the coordinates of the first chosen mark (#1446) 2018-04-16 14:37:04 +03:00
neslihanturan
802b2a8df4 Hot fix bundle issue (#1425)
* Fixed bug #1399

* Changed visibility from visible to gone

* Changed behaviour according to review

* Changed bottom sheet visibility from visible to gone

* Fix adding bundle to an already created fragment
2018-04-08 19:17:20 +10:00
Yiran Cao
3949dbca5c Fixed issue #1395 (#1423)
* fixed issue #1395

* moved the compass icon to bottom-left corner
2018-04-05 20:27:10 +03:00
misaochan
a095a4e25b Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release' 2018-04-06 00:15:40 +10:00
Josephine Lim
f4166899ca Fix issue with onRequestPermissionsResult not being called in Nearby map and list (#1424)
* Update changelog.md

* Versioning for v2.7.0

* Call fragment method, not activity's

* Initialize directUpload and controller in onCreate

* Add logs

* Change requestcodes in DirectUpload and NearbyMapFragment

* Chain to super in default case (where request codes don't match activity's)

* Controller must be initialized before directUpload

* Fix whitespace, add comments

* Alter request codes for Nearby List as well

* Make permission rationales more specific

* Add comments
2018-04-05 16:31:18 +03:00
misaochan
ba9287fa8b Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release' 2018-03-31 04:06:10 +10:00
neslihanturan
09763f942f
Merge pull request #1390 from commons-app/fixNearbyLeaks
Fix nearby leaks, at least some ot them
2018-03-30 12:36:41 +03:00
neslihanturan
499d64bb26 Fix NPE 2018-03-30 11:55:15 +03:00
neslihanturan
ea57855dcc Fix memory leak C, I hope 2018-03-29 19:48:01 +03:00
neslihanturan
59a7428048 Fix neraby leak B, leak caused map marker's have reference to activity stays remain on destroy fragment 2018-03-29 16:11:30 +03:00
Vivek Maskara
e122bf3a54 Use custom tabs for nearby web views (#1347) 2018-03-29 16:56:34 +10:00
Josephine Lim
6fc294ab3f
Merge pull request #1381 from commons-app/fixNearbyCurLoctionMarker
Fix nearby current location marker
2018-03-29 00:29:31 +10:00
misaochan
0ec77b31f8 Add check for size of places array 2018-03-28 20:45:08 +10:00
neslihanturan
ba73dbbd50 Fix zoom and target according to bottom sheet position 2018-03-27 22:24:14 +03:00
neslihanturan
ae0bfae275 Fix bottom sheet and current location marker visibilities 2018-03-27 20:39:38 +03:00
misaochan
f23cd8214d Add comments 2018-03-26 18:48:09 +10:00
misaochan
f08641b66f Add getLineCount() == 0 check for button text to prevent wrapping lines 2018-03-26 18:43:19 +10:00
misaochan
0861533d29 Fix logging 2018-03-26 18:29:30 +10:00
neslihanturan
49f4b5bc7c Merge master to branch 2018-03-22 18:22:32 +03:00
neslihanturan
fccc7e66d4 Add network connectivity listener and inform user acordingly 2018-03-22 18:15:35 +03:00