Commit graph

317 commits

Author SHA1 Message Date
Vivek Maskara
f7c57c03ba Log P18 edits with custom tag (#1583)
* Log P18 edits by adding custom tag to the edits

* Add javadocs
2018-06-04 17:50:50 +10:00
maskara
edaa0dd05a Fix build 2018-06-01 01:15:28 +05:30
Vivek Maskara
0e86741cc4
Merge branch 'master' into wikidataEdits 2018-05-31 10:02:38 +05:30
Vivek Maskara
4815e93fc9 Make P18 edits to corresponding wikidata entity on uploading from Nearby (#1495)
* Localisation updates from https://translatewiki.net.

* Integrate API for displaying featured images (#1456)

* Integrate API for displaying featured images

* Add pagination and refactor code so that it can be reused for category images

* Add license info to the images

* Fix author view

* Remove unused values

* Fix minor issues with featured images

* Fix null license url issue

* Remove some log lines

* Fix back navigation issue

* fix tests

* fix test inits

* Gracefully handling various error situations

* Added java docs

* Update pull_request_template.md (#1476)

* Update pull_request_template.md

* Remove Javadocs mention

* Added required/optional notes

* resolves #1464 : MediaDataExtractor is making inefficient (redundant) server calls (#1496)

* Open map of place where picture was taken (#1360)

* Intent to map added

*  Merge conflicts resolved

*  Added the functionality to hide FAB incase of null coordinate

*  Merge Conflict resolved

*  Improve pr quality

* Improve Quality

*  Added nested FAB animations

* Nested FAB implemented

*  Improve Quality

*  Added up arrow

*  Javadocs Added

* Add nearby tutorial (#1467)

* Add dependency for MaterialShowcase

* Add actionview class to get a reference to material showcase

* Create a NearbyMaterialShowcaseSequence class

* Apply sequence steps

* Add first three steps of nearby showcase

* Add sequence id constants to make sure they will be displayed only once

* Add last step of sequence to explain plus fab

* Create an object to prevent customize all sequences every time

* Fix typo

* Code cleanup

* Add strings to strings.xml

* Code cleanup

* Revert irrelevant change

* Revert irrelevant change

* Remove showcaseview for recenter button

* Use single showcaseView instead of sequence

* Add single showcase view insted of sequence to be able to edit text style

* Make sure it will be displayed only once

* Cleanup

* Update strings

* Change dismiss text style

* CONTRIBUTING: fix formatting of the gist of the guidelines (#1453)

* CONTRIBUTING: fix formatting of the gist of the guidelines

First level headings for a gist seems to be overkill.

So, replace first level headings with an ordered-list which
sounds more meaningful.

* CONTRIBUTING: specify clearly that 'blame' is a feature of "Git"

The contributing file specifies about the ability to know who wrote
something without the need of @author javadoc tags but incorrectly
attributes the feature to GitHub.

Correctly attribute the feature to where it belongs, Git, and specify
the name of the feature to help users easily take advantage of it.

* Feature/switch to butterknife (#1494)

* Implemented butterknife in MediaDetailFragment [issue #1491]

* Implemented butterknife in MediaDetailPagerFragment [[issue #1491]]

* post merge upstream master wip [[issue #1491]]

* Localisation updates from https://translatewiki.net.

* Bug fix #1504 (#1506)

* Bug fix #1504

* Filtered messages with ConnectException [issue #1504]

* A generalised message for exceptions in Nearby Activity [issue #1504]

* Localisation updates from https://translatewiki.net.

* Fix security exception crash while accessing network location provider (#1498)

* Fix security exception crash while accessing network location provider

* Added java docs

* Localisation updates from https://translatewiki.net.

* Log P18 edits to wikidata corresponding wikidata entity on uploading a nearby image

* Added java docs

* Fix test build

* Refresh nearby

* Refresh nearby list on successful edit

* Java docs

* Make authenticated wikidata edits

* Updated toast message to show entity name that was edited
2018-05-31 11:00:17 +10:00
Paul Hawke
a66a0e8ca0 Refactoring to extract GpsCategoryModel and ensure single-responsibility-principle is maintained in CategoryApi. 2018-05-25 01:55:03 -05:00
Paul Hawke
32cb8df9ae Consolidate the networking libraries - drop volley in favor of OkHttp 2018-05-25 01:42:12 -05:00
Tanvi Dadu
aca3f0f832 Open map of place where picture was taken (#1360)
* Intent to map added

*  Merge conflicts resolved

*  Added the functionality to hide FAB incase of null coordinate

*  Merge Conflict resolved

*  Improve pr quality

* Improve Quality

*  Added nested FAB animations

* Nested FAB implemented

*  Improve Quality

*  Added up arrow

*  Javadocs Added
2018-05-18 16:52:11 +05:30
Ashish
66b275b19d Implemented butterknife in SimilarImageFragment [issue #1491] 2018-05-10 14:16:08 +05:30
Ashish
8f76dd0b61 Implemented butterknife in ShareActivity [issue #1491] 2018-05-10 13:32:03 +05:30
Ashish
2d1f166ac7 Implemented butterknife in MultipleUploadListFragment [issue #1491] 2018-05-09 17:57:59 +05:30
Tanvi Dadu
4f6b791c93 Open map of place where picture was taken (#1360)
* Intent to map added

*  Merge conflicts resolved

*  Added the functionality to hide FAB incase of null coordinate

*  Merge Conflict resolved

*  Improve pr quality

* Improve Quality

*  Added nested FAB animations

* Nested FAB implemented

*  Improve Quality

*  Added up arrow

*  Javadocs Added
2018-05-07 12:57:59 +03:00
Ujjwal Agrawal
d3597b80a6 Added hideKeyboard in ViewUtil (#1488) 2018-05-03 02:47:56 +05:30
neslihanturan
35f05be8df
fix memory leaks (they happened due to hiding keyboard) and lint null pointer warnings in the same code (#1471) 2018-04-30 14:42:19 +03:00
neslihanturan
3c2cc26d3b
Fix conflicts from #1366 fixing lint issues (#1470)
* lint issue #171 - added Locale.getDefault()

* lint issue #171 - added Locale.getDefault()

* lint issue #171 - added %d

* lint issue #171 - Changed version

* lint issue #171 - added singleLine="true"

* lint issue #171 - changed commit to apply

* lint issue #171 - added Locale.getDefault()

* lint issue #171 - added Locale.getDefault()

* Codacy issues #778 - nested if loop

* Codacy issues #778 - nested if loop

* Revert "lint issue #171 - added %d" since we dont edit translated string files

This reverts commit e4917cddcf.
2018-04-30 14:05:47 +03:00
Mansi Agarwal
f80311d9f6 fixed crash while uploadiing certain images (#1388) 2018-04-30 13:49:03 +03:00
Tanvi Dadu
9c91d7a799 Zoom (#1300)
*  Basic Zoom feature added along with button to control it

*  Pinch Zoom added

*  Merge Conflicts Resolved

*  Icons Changed

*  Compressed the high resolution images

* Fixed null pointer exception

* Fixed null pointer exception

*  Fixed exception

*  Fixed error

*  Fixed Resource availability issue
2018-04-26 03:18:58 +05:30
Vivek Maskara
b108dff460
Merge branch 'master' into featuredImages 2018-04-19 23:44:33 +05:30
Anubhav Gupta
d3071718b4 Changes made (#1447) 2018-04-17 15:52:53 +03:00
neslihanturan
7b5c5ce497 Fix nearby leaks D 2018-03-29 23:15:21 +03:00
Vivek Maskara
463673f942
Merge branch 'master' into featuredImages 2018-03-24 12:46:38 +05:30
Vivek Maskara
50d9cff8c6
Merge branch 'master' into directNearbyUploadsNew 2018-03-21 17:54:03 +05:30
misaochan
eaed36555c Remove TODO 2018-03-18 20:45:51 +10:00
misaochan
d6e848b32e Remove comment from UploadController.java 2018-03-18 19:17:02 +10:00
misaochan
efa7820fe4 Comment out UploadController.java line to test with Prod categories 2018-03-18 18:35:50 +10:00
neslihanturan
c869581c2a
Merge pull request #1209 from hismaeel/1130(j)
issue #1130 -(j). bad Token Exception from showDialog() in ExistingFi…
2018-03-16 12:16:07 +02:00
misaochan
5e828d4541 Save categories in PlaceRenderer and SingleUploadFragment 2018-03-16 20:01:52 +10:00
yashshah7197
87b794ce1f feat: Add checks for title and description in intent extras.
In case other apps want to send a title and description along with the
image, we check if those have been passed as intent extras and set the
EditText values accordingly.

Fixes: #1273
See also: #892
2018-03-12 18:06:04 +05:30
neslihanturan
41494bea5b Fix conflicts 2018-03-06 20:32:28 +03:00
neslihanturan
5b88111289 Fix conflicts 2018-03-06 19:47:18 +03:00
Vivek Maskara
4c3513b442
Merge pull request #1211 from tshradheya/1195-give-toast-message
Give toast when trying to upload image without giving a Title #1195
2018-03-03 19:23:10 +05:30
maskara
123c4adbfd Minor changes to make things work 2018-03-03 00:30:44 +05:30
misaochan
b2859ba874 Hopefully last cleanup 2018-03-03 00:00:36 +05:30
misaochan
676fa0e0d0 Remove unused imports 2018-03-02 23:59:47 +05:30
misaochan
ce6c95aa29 Fix whitespace 2018-03-02 23:59:22 +05:30
misaochan
821eaceb27 Further code cleanup 2018-03-02 23:59:22 +05:30
misaochan
9fb82da313 Remove unnecessary getters in ShareActivity 2018-03-02 23:59:07 +05:30
misaochan
59cc07922d Retrieve title/desc via Dagger injection in SingleUploadFragment 2018-03-02 23:59:07 +05:30
misaochan
f8343592f3 Add comments 2018-03-02 23:54:04 +05:30
misaochan
2e59a8e0b6 Add check in SingleUploadFragment for isNearbyUploadf 2018-03-02 23:54:04 +05:30
misaochan
0a6ed18c83 Pass nearby Title and Desc to SingleUploadFragment 2018-03-02 23:53:26 +05:30
misaochan
73327192f9 Tidy up and create framework for autofilling EditText 2018-03-02 23:53:07 +05:30
misaochan
fba7628f3c Change to getSharedPreferences to pass prefs between activities 2018-03-02 23:53:07 +05:30
misaochan
13a73fdcac Create boolean for isDirectUpload and pass shared prefs to ShareActivity.java 2018-03-02 23:53:07 +05:30
Suchit Kar
67d1df27fb Extract alert dialog creation to a function 2018-02-28 01:57:53 +05:30
Suchit Kar
de9bb89ff2 Merge branch 'master' of https://github.com/commons-app/apps-android-commons into rtl-upload 2018-02-27 19:08:30 +05:30
Shradheya Thakre
6a05231878 Logic to show toast on click 2018-02-26 14:13:31 +08:00
Hassan
14686138df
Merge branch 'master' into 1130(j) 2018-02-25 22:04:29 -06:00
hismaeel
ba49d0601a issue #1130 -(j). bad Token Exception from showDialog() in ExistingFileAsync 2018-02-25 21:55:04 -05:00
Meghna Gupta
9aceaca95d Hide Keypad when EditText out of focus (#1168)
* Hide Keypad when EditText out of focus
2018-02-24 00:00:45 +05:30
Suchit Kar
c3faf25d12 Remove unused import in SingleUploadFragment 2018-02-21 15:34:08 +05:30