* Integrate WLM
- Show monuments in maps along with nearby
* BugFix in Monuments
1. Single preference for monuments and campaigns
2. Expand collapse chips container in nearby
3. Typo fix in Monuments card in Nearby
4. If a nearby place is a monument as well - do not show them separately, show it as a monument instead
5. Bug fix, monument radius, use the same one as that of nearby
* More bug fixes
1. Possible NPE in nearby
2. Added column location_address in BookmarkLocationDao
3. Bug Fix - Display Date in WLM card
4. WLM card on click takes to nearby
* Use lowercase country code in WLM uploads
* Bug-Fix, WLM Campaign Icon
* 1. Updated monuments query to use any of the following properties for monuments - [P1435, P2186, P1459, P1460, P1216, P709, P718, P5694] 2. Append WikiData QID to descriptions template
* Updated WLM Banner String, Handle NPE in contributions callback
* Added nearby-monuments query log lines
* Handle WLM Query exception : - if an exception is thrown in WLM query, continue showing the nearby items if that succeeds
* Fix BookmarkLocationDaoTest
* Added Column Address in BookmarkLocationDaoTest
* Use fallback description as usual nearby pins even for WLM pins, instead of relying on P6375
* Test fix in BookmarkLocationDao
* Updated template for WLM, removed redundant feilds
* Fixed WLM template
* Removed categories from WLM template
* Fixed BookmarkControllerTest
* Fixed BookmarkLocationFragmentUnitTest
* fix ModelFunctions
* Fixed BookmarksDaoLocationTest
* Fixed WLM template
* #3624 DateTimeFormat wrong - match pattern returned from servers (#3625)
* Revert "Fixes: #3179 Make category search non case-sensitive (#3326)" (#3636)
Simply lower casing the name of the category sent to the server
doesn't result in the server doing a case insensitive category
search. In fact, it reduces the category search space as only
categories that has a lower case character is searched even
if the search text contains upper case characters.
The test case did not catch this issue as the first character
of the title is case insensitive[1].
So, revert the changes done in commit afdeaae075.
See further disucssion in the issue thread of #3179 starting
from [2].
[1]: https://www.mediawiki.org/wiki/Manual:Page_title
[2]: https://github.com/commons-app/apps-android-commons/issues/3179#issuecomment-605462140
* Bugfix/security exception (#3627)
* Fixes#3626
* Check is file is actually created before writing to file, file picker android
* Handle Security exception
* Fixes#3436 and #2881: Media Detail design Overhaul (#3505)
* ic_map_dark_24dp: map icon for white background
* ic_info_outline_dark_24dp: info icon for dark background
* MediaDetailFragment: update the spacer as per image aspect ratio
* fragment_media_detail: design overhaul
* fragment_media_detail: remove redundant background color statements
* make requested changes
* add dark mode support
* minor ui tweak
* white map icon in dark mode
* make rquested changes
* make requested changes to layout
* fix misalignment of category list
* subtle amendments
* convert comments to javadocs
* minor amendments
* minor changes
* add styles for media detail
* Media detail fragment refactored
* make suggested changes
* minor name fix
* fix the delete button border
* Fixes#3639 (Fix Save State implementation of CheckBoxTriState ) (#3686)
* Add #3723 and #3721 to 2.13 release, fix conflicts
Conflicts were caused by merging #3723 before #3721 , so I just rolled both into one commit.
* Fix NullPointer when clicking on image in MediaDetailFragment (#3730)… (#3739)
* Update changelog.md
* Versioning for v2.13
* Fixes#3705 (Crash when viewing pic I just uploaded) (#3782)
* Fixes#3705
* Let the MediaDetailPager fragment know when the contributions have been updated
* Handle NPE, null check on adapter in MediaDetailPagerFragment
* Fixed BookmarkLocationsDao DB migration (#3793)
* Fixes#3725 (#3795)
* Downgraded okhttp version to support Api 19 devices
* Handled null CompoundDrawable[2] in etTitle-> UploadMediaDetailsFragment (#3828)
* DownSample Upload image to be shown in UploadMediaDetailFragment to handle OOM, Bitmap Too large exception (#3830)
* Fixes#3829
* DownSample Upload image to be shown in UploadMediaDetailFragment to handle OOM, Bitmap Too large exception
* removed unused imports, handled possible exceptions
* Let Fresco handle the downsampling of image
* invalidate in onTransformEnd
* Expose an interface TransformationListener in ZoomableDraweeView to listen to transformation change end
* removed photoView dependency
* removed unused imports in ZoomableActivity
* Bugfix, expand/collapse
* changed functio name
* Bugfix/p18 uploads (#3869)
* updated gradle plugin version
* BugFix #3856
* Do not use preference for deciding acceptable lat long for nearby uploads, instead save the corresponding location in the Contribution via UploadItem
* Marshall contribution's hasInvalidLocation
* reset un-related changes
* Fixed test cases
* Minor code formatting and docs
* Fixes#3882 (#3883)
* Make hasInvalidLocation non-null integer with default value 0
Co-authored-by: Ashish Kumar <ashish@Ashishs-MacBook-Air.local>
* Fixes#3766, Added OPENSTREET attribution (#3889)
* Fixes#3766
* Added OPENSTREET attribution in nearby
* Added custom text attribution in Nearby
* Deleted unused class CustomBorderTextView
* review suggested changes
* modified telemetry summary string
* Versioning and changelog for v2.13.1 (#3908)
* Update changelog.md
* Versioning for v2.13.1
* Fixes#3914 (#3915)
* Verify user login before setting upload count
* fixed compile-time error
* fix erros
* delete emptied files
* remove empty file CategoriesModel.java
Co-authored-by: Seán Mac Gillicuddy <seantheappdev@gmail.com>
Co-authored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Co-authored-by: Kshitij Bhardwaj <44129798+kbhardwaj123@users.noreply.github.com>
Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
Co-authored-by: Josephine Lim <josephinelim86@gmail.com>
Co-authored-by: Ashish Kumar <ashish@Ashishs-MacBook-Air.local>
* Fixes#3303
* Refactor Nearby to alig lifecycle methods
* Pass updated place list to listfragment
* Added default zoom rate to mapbox
* Removed NearbyListFragmet and added the ui login to handle the same in NearbyParentFragment
* More code refactor
* Make BottomSheetList hideable
* onFragmentHide, hide the bottom sheets
* BigFix, Fragmet visibility, register/un-register camera move based on fragments lifecycke
* More code refactor
* Let the ExecutorUtil have non-ui thread
* Add Location Marker on non-ui thread (the non-ui stuffs)
* BugFixes
* Removed configchanges "orientation" from MainActivity in Manifest (That was messing with the fragment lifecycle)
* Some null checks
* Initialise lastknown location in onMapReady
* UI Fixes
* Adjusted UI to support dark and no-dark themes both (in nearby)
* Do not update map on Location Slightly changed
* Fix failing test case, let TestCommonsApplication extend Application instead of CommonsApplication
* start map view when nearby is visible
* start the map when NearbyFragmet is visible
* More bugfixes
* Added DUMMY view for NearbyPresenter's onDetach State
* Added a wrapper frame layout parent for MapView to preven it from drawing above other views
* More bugfixes (Fixes#3287)
* Gray out the un-selected markers from the nearby filter list
* BugFix, search this area should search the nearby places for the current camera position
* More BugFixes
* Handle null primitives with proxy
* Current location marker flow via permission flow
* onCameraMove should have null-check on NearbyController.latestSearchLocation instead of currentLocation
* Search for places around last focus location
* Handle location updates
* If the user is browsing the map, donot update the map with current location
* Add layout items for nearby filter list and filter item
(cherry picked from commit b96f8a68ce)
* Edit nearby query
(cherry picked from commit 1f3c8c8deb)
* Add filter items to nearby parent fragment xml
(cherry picked from commit d0beadd0e0)
* Add icon for green marker
(cherry picked from commit f65ca0387a)
* Add layout util file to organize layout utilities
(cherry picked from commit 5c57939245)
* Add pic parameter to nearby result item
(cherry picked from commit 86007e4bb6)
* Add pic parameter to place type
(cherry picked from commit 25c358b67f)
* Add green marker styling
(cherry picked from commit 929c92d887)
* Inıt search layouts on Nearby parent
(cherry picked from commit 2ac38a1919)
* Style green markers at nearby controller
(cherry picked from commit 3e08f39f8e)
* Edit bookmark daos to include pic to tables
(cherry picked from commit 48d69edf3b)
* TODO foc bookmark dao item but works now
(cherry picked from commit f748399720)
* Style nearby filter area
(cherry picked from commit 6267e488b0)
* fix style of filter tab
(cherry picked from commit 5f843bf366)
* Add nearby list adapter
(cherry picked from commit 56334afe03)
* Current status, list size is working, visibility working, filter mechanism is ready
(cherry picked from commit 7d75c9c589)
* Filtering works
(cherry picked from commit 8a13cf7728)
* Filter function works
(cherry picked from commit 78368a2c0c)
* Fix style issues
(cherry picked from commit 2204f70255)
* Add divider to recyclerview
(cherry picked from commit c8100b55d7)
* Hide bottom sheets accordingly
(cherry picked from commit c5deba8b0b)
* Code cleanup
(cherry picked from commit cf8f64f3cb)
* Add actions to chips
* Fetch destroyed information from servers
* Add destroyed places icon
* Make chip filter functions work
* Revert irrelevant changes
* Revert accidentally replaced strings
* Remove unneeded lines
* Remove only places expalanation from trings
* Do not filter if nearby places are not loaded
* Add triple checkbox for add none and neutral
* Make tri checkbox work
* Fix travis issue
* Add coments
* fix search this area button locaton
* Set initial place type state and recover it between each populate places
* Create parent contract
* Create map child contract and fill methods
* Add javadocs and specific interfaces for list
* Move general method to parent and add javadocs for parent
* Add explanation for keeping an emty View interface under NearbyListContract
* Move constracts under contract package
* Create presenters for map and list and implement user actions accordingly
* Add javadocs
* Add presenter, contract and fragment for parent Fragment of both NearyListFragment and NearbyMapFragment
* Implement missing methods
* Fix typo
* Add main views on fragment
* İmplement child fragment logic and their retain
* Relate parent presenter with parent fragment
* Add all location permission related methods to view contract and implement in fragment. Call them from presenter by passing locationServiceManager parameter
* Define refreshView method as updateMapAndList which is a better naming. Define it at presenter part.
* Define a presenter variable in fragment and call updateMapAndList method from there, if permissions are okay
* Add lock neabry method to unlisten nearby operations during updates
* Add network connection established check on view side, check it from presenter
* try to simplify previous method during refactor
* Add missing methods for NearbyMap
* Connect child fragment and prent fragment with presenter
* Change nearby design, first create views then register listeners
* AddnetworkBroadcatsReceiver on view side, call it from presenter
* Add comments
* Change the old NearbyFragment by our new NearbyParentFragment for first tests
* Prevent crash caused child fragment is actually null by checking if it is attached or not.
* Makes sure that initialize nearby operations method is called just after all views and fragments are ready and attached
* Make sure updateMAoAndList method is called when everything ready
* Rename a method with prepoer name
* Call update map and add required markers
* Find out zoom level problem
* Implement add nearby markers and add current marker methods
* remove unneeded codes copied from previous implementation
* Revert "remove unneeded codes copied from previous implementation"
This reverts commit 42539651de.
* add some commits and clear code
* Remove location listener implementation from view, handle them in presenter instead. And add timber debug notes and required method calls
* Style ,issues
* Refactor a variable name to camel case and bind search this area view
* Search this area button action is added
* Mostly implement search this area methods, not tested yet even once
* Make sure everything is called in required order and seach this area method basically works
* Rename methods accordingly and add Javadocs
* Add current location marker and remove circle around it
* Remove unused methods
* Add current location marker with object animator and remove previous marker is exists
* include clear map into add markers method and reorder methods
* Make search this area button appear at correct time
* Try to load un search this area is called
* Clear logs
* Add changes for permission made by Vivek to newly added fragments along with our nearby classes
* Add a view to nearby map ragment and insert map view as an item inside it
* Add logs to uınderstand why on meap ready callback is never called
* Add list item clicked and bottom sheet for list of nearby items is expanded
* Make nearby map ready callback came
* Add required methods to be called after map view is ready
* State: Map ready call is not called but permissions and methods are in correct order
* Remove unused logs
* Try to use SupportMapFragment instead, still no success...
* use SupportMapFragment instead
* Remove unused Near
* Upgrade mapbox sdk versions
* Remove Style import from fragment/NearbyMapFragment
* Remove Style import from **fragments/NearbyParentFragment
* Remove nearby/NearbyMapFragment
* Remove unused/old NearbyFragment and NearbyMapFragment
* Remove import of already removed class
* Make sure you removed everything related with mapbox implementation
* Update mapbox map
* Remove unused classes, do not forget centerMapToPlace doesn't work on this branch
* Remove Style class it required updated version of mapbox map
* Add base codes for new activity
* Prove that our mapbox sdk let us implement the map directly inside the activity
* Add base codes for testing mapbox activity in a single fragment inside activity
* Add codes from mapbox demo repository to test support fragment, map works in a single layer fragment
* Add base codes for test layered fragment activity
* Add Support fragment inside a fragment and proves that layered fragmentw with map works
* Test view pager and tab layout with support map fragment to see it works, it works!
* Move Contributions Fragment related codes to test activity
* Move nearby card methods
* Inject location manager and implement NerabyParentFragmentContract.View on test fragment
* Coppy the content of SupportMapFragment from mapbox repository, use this code to modify later. This method war suggested by mapbox team instead of extending the class
* Implement NearbyMapContract.View on our new SupportMapFragment
* Start to mplement logic of checking permissions
* Fix small dagger issue to inject location manager properly
* Request permission for nearby places if fragment is loaded and tab is selected
* Initialize map operations if map ready and tab is selected
* Markers loads at correct time
* Style the map according to new version of mapbox map
* Add some map elements like FABs and give their actions
* Implement map marker click actions
* Implement nearby Fabs logic with a small issue
* fix FABs are not closing problem
* Unkown problem occurs at map load when I try to use MainActivity again.
* Revert "Unkown problem occurs at map load when I try to use MainActivity again."
This reverts commit 3dc084415b.
* Search this area buttons are added but button function does not work and button visibility is problematic
* Fix issue with MainActivity with the help of Ashish
* Fix search this area button visibility issue
* Fix the issues with updating search nearby markers and camera position together
* Fix progress bar visibility issue
* Prevent loding map each time tab selected
* Take toolbar back
* Implement back button with presenter
* Add click actoion to bottom sheet details
* Add nearby list into bottom sheeet
* Make reuse existing fragments if there is any
* Code cleanup
* Cleanup
* Code cleanup
* Add lifecyle codes to prevent leaks
* Cleanup
* Code cleanup
* cleanup
* Make list item clicked and map focus to same place
* Add bookmark from list fragment
* Make nearby card click action work
* Revert "Fix conflicts"
This reverts commit f3451745d3, reversing
changes made to c5d4d5533d.
* Code cleanup
* Cleanup
* Make recenter button work when list sheet is expanded
* Cleanup
* Code cleanups
* NPE issue is not detected for now, can be solved on seperate PR
* Update map after Wikidata edit
* Cherry picked previously reverted merge, hoping this will fix enourmus amounts of diff files
* Previous merge bringed an file which should be deleted. Delete it.
* Revert irrelevant changes on build.gradle
* Revert irrelevant changes
* Jetbrains annotation is not included to build gradle, this issue caused build issues on my branch so I removed it to be able to build
* Rename ListView
* Use a singleton to access the presenter, instead of passing it to a variable inside fragment
* Fix code style issues
* Move hardcoded colors to colors.xml file
* Make larger methods smaller
* Make current location marker follow
* Do not track users position if user is searching around
* Revert irrelevant shanges at build gradle
* Remove unneeded variable
* Remove mvp directory, add sub directories directly under nearby directory instead
* Remove unneeded public definiton
* Remove unneeded namespace
* Add public defiiton, it is needed to reach the constructor.
2019-10-16 00:32:05 +10:00
Renamed from app/src/main/res/layout/fragment_nearby.xml (Browse further)
Ashish