Commit graph

928 commits

Author SHA1 Message Date
Clay Tsay
eeea0774b6 Added JavaDocs
Added JavaDocs to various files, namely License, Media, PageTitle, and Utils.
2017-12-10 00:28:51 -08:00
Dmitry Brant
da82466a17 Take out legacy event logging from app.
These are especially old bits of code, where it seems like WMF folks had set up Eventlogging schemas for some rudimentary analytics of the Commons app. These schemas are no longer queried or monitored, and can be safely removed. When the Commons app has a stronger need for more meaningful analytics, we can revisit reintroducing new and better schemas.
2017-12-05 23:01:55 -05:00
maskara
db8cae95e4 Fix Fresco initialization 2017-12-04 02:33:36 +05:30
Vivek Maskara
52b52c4895
Merge branch 'master' into dependency-injection 2017-12-04 02:17:16 +05:30
maskara
463f75e8b3 Show location permission denied dialog in all relevant scenarios 2017-12-02 20:58:31 +05:30
maskara
2796e4277c Fix issues around location in nearby activity 2017-12-02 20:58:31 +05:30
Paul Hawke
fb30a34478 Merge branch 'master' into dependency-injection 2017-11-30 21:41:38 -06:00
Paul Hawke
ce32505ca3 Created a Robolectric unit test replacement for the NearbyActivity test. 2017-11-29 21:29:09 -06:00
Paul Hawke
07577d73a1 Refactoring based on code review feedback. 2017-11-25 14:23:50 -06:00
Paul Hawke
6d77243329 Fixed issue found by tests running on Android API 21/22 2017-11-25 12:52:42 -06:00
Paul Hawke
17e1ff20d7 Update based on code-review feedback. 2017-11-25 11:46:41 -06:00
Paul Hawke
02b5b9b680 Merge branch 'master' into dependency-injection 2017-11-24 22:30:08 -06:00
misaochan
f96169baa7 Changed to refreshView 2017-11-23 21:32:26 +10:00
misaochan
7a50a7dbdf Call setupPlaceList onResume 2017-11-23 18:31:57 +10:00
Josephine Lim
8327aedaf1
Merge branch 'master' into locationUpdate 2017-11-23 17:11:37 +10:00
Vivek Maskara
f0d11a6074
Merge pull request #949 from ramarajesh2112/issue-944
Issue-944: Fix for same activity getting instantiated multiple times
2017-11-23 02:50:04 +05:30
maskara
b6441ef89f Lock location after the list is loaded once 2017-11-23 02:38:24 +05:30
maskara
a61124a580 Fix: Location update in nearby activity 2017-11-22 01:11:02 +05:30
Vivek Maskara
21f08ae986
Merge pull request #974 from misaochan/fix-log-file-send
Send log file to private Google group forum instead
2017-11-21 22:03:07 +05:30
Josephine Lim
243170768f
Merge pull request #967 from maskaravivek/nullFix
Fix: Crash because of no file found error while uploading
2017-11-22 02:17:16 +10:00
misaochan
785bed90ba Send log file to private Google group forum instead 2017-11-22 01:16:36 +10:00
Josephine Lim
591575faaf
Merge pull request #952 from JohnKal/master
Fixed issue #894
2017-11-21 15:45:45 +10:00
Ram Gudivada
3c9b325e58 Changed activity creation logic
- for home activity it will reuse existing activity from back stack and
  also clears all current activities
- for nearby, about and settings, it will use the existing activity from
  back stack
2017-11-20 21:37:10 -08:00
maskara
16ee2b87ec Fix: Crash because of no file found error while uploading 2017-11-18 01:28:12 +05:30
maskara
8dd8e09f2a Fixes NPE in Util function 2017-11-16 17:32:45 +05:30
maskara
c97f39fcdf Dispose observable for places 2017-11-13 23:16:27 +05:30
maskara
6a6ba7d542 Fix Leak canary test 2017-11-13 23:16:27 +05:30
maskara
0101dc4820 Cleanup 2017-11-13 23:15:53 +05:30
maskara
a59bf1bc4b make location manager singleton 2017-11-13 23:15:53 +05:30
maskara
d4bafd94e0 Fixes leaks in contribution and nearby activity 2017-11-13 23:15:53 +05:30
JohnKal
8dc9103ec0 Fixed issue #894 2017-11-12 13:02:16 +02:00
maskara
6a7b7cbbe8 Introduce dagger 2017-11-12 01:04:10 +05:30
Ram Gudivada
03517de9a3 Removed unnecessary finish() call for about option in menu. 2017-11-11 01:21:33 -08:00
Ram Gudivada
5548cec02e Removed finish() method for tutorial/feedback and logout menu options. 2017-11-11 01:19:51 -08:00
Ram Gudivada
2c1f20f1fd Issue-944: Fix for same activity getting instantiated multiple times
This is happening because the finish() method on current activity is not
called before switching to the new activity
2017-11-11 00:43:37 -08:00
Yusuke Matsubara
e317c369c1 Disable LeakCanary for Robolectric tests
See 'For Robolectric users:' https://github.com/square/leakcanary
2017-11-03 11:30:10 +09:00
neslihanturan
d09109006d
Merge pull request #920 from Bluesir9/fix_736_send_app_logs
Allow user to send app logs
2017-10-31 23:16:50 +03:00
neslihanturan
1f88b6d58a
Merge pull request #928 from RSBat/no-data-fix
Fixed issue #927
2017-10-30 17:27:13 +03:00
neslihanturan
75496388ce
Merge pull request #929 from JohnKal/master
fix for issue #719
2017-10-30 14:48:16 +03:00
JohnKal
aab792f75b Add period to Javadoc comment. 2017-10-28 16:45:05 +03:00
JohnKal
dd8f9a4873 fixed issues with code quality. 2017-10-28 16:05:33 +03:00
JohnKal
99f4f376bd fix for issue #719 2017-10-27 21:24:47 +03:00
Sergey Kozelko
bd5b95040d Force request radius to be no larger than MAX_RADIUS, thus always make request 2017-10-27 20:02:39 +03:00
Yusuke Matsubara
b0e8175003 Merge pull request #917 from RSBat/master
Fix Codacy issues
2017-10-27 22:26:44 +09:00
Sergey Kozelko
dd4e7c3aa0 Fixed bug when there are places nearby but none are loaded 2017-10-27 14:15:25 +03:00
Josephine Lim
3434c46f98 Merge pull request #921 from neslihanturan/fix#674
Fix nearby position not updating
2017-10-27 01:30:24 +10:00
neslihanturan
d6e74315a0 Merge pull request #914 from joeratt/master
Correcting some easy Codacy issues
2017-10-25 16:10:03 +03:00
neslihanturan
09fa46526c Merge pull request #913 from Bluesir9/fix_374_download_my_uploads_loader
Added progressbar in ContributionsListFragment to be shown while its loading contributions
2017-10-25 16:03:05 +03:00
Neslihan
9d6d773b33 Set progress bar visible on refresh 2017-10-24 01:28:19 +03:00
Neslihan
959c581b79 Refresh current location on refreshView() 2017-10-23 18:11:11 +03:00