* Moved Main Activity and Settings Activity to ViewBinding
* Moving only SettingsActivity for now
* Removed values-yue-hant directory
* Removing previously done changes to main.xml
* Butterknife to ViewBinding
* code fix to pass all tests
* test fix
* test fix
* test fix
* test fix
* Update ContributionsFragmentUnitTests.kt
* code cleanup and tests improved
* tests fixed
* adjustments and code cleanup
* adjustments and code cleanup
* Refactor :API calls separated from activity added to LoginClient
* getLoginToken() modifier set to private
* Code Cleanup : removed non-null from twofactor and Locale import
* Indentation fix
Added line breaks to PageContentsCreator.java, CategoryEditHelperUnitTests.kt, and MediaDetailFragmentUnitTests.kt following the example given on issue #5523.
* Convert UserClient to kotlin
* Added tests for WikiBaseClient
* Removed superfluous dao tests in review helper and got the proper ReviewDaoTest running in the unit test suite
* Improved tests for ReviewHelper
* Convert the ReviewHelper to kotlin
* Convert the WikiBaseClient to kotlin
* Convert the WikidataClient to kotlin
* Fixed arrow flickering issue on zoom
* Resolved issue point 1 and 3
* Resolved issue point 2
* Minor changes
* Update UploadActivity.java
---------
Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
* Converted CategoryInterface to kotlin
* Converted DepictsInterface to kotlin
* Convert the MediaDetailInterface to kotlin
* Convert MediaInterface to kotlin
* Convert ReviewInterface to kotlin
* Convert the UserInterface to kotlin
* Convert the WikiBaseInterface to kotlin
* Convert WikidataInterface to kotlin
* Convert WikidataMediaInterface to kotlin
* Convert UploadInterface to kotlin
* logErrorsInsteadOfCrashing only ever returned false, so remove it and simplify logger
* Removed unused getMediaWikiBaseUrl()
* Removed getDesiredLeadImageDp() from commons app adapter, since it's unused
* Inlined the isLoggedIn() method of the app adapter
* Inline the app adapter username/password
* Removed the unused getRestbaseUriFormat() from the commons app adapter
* Remove references to the data-client SharedPreferenceCookieManager
* Manage our own OkHttpClient and remove the AppAdapter implementation
So far we used both the urbanecmbot instances and also the commons-android-app
toolforge instance for the functioning of the app.
The reality is that the commons-android-app instance itself had the ability
to return all the data necessary for the app. Use the same to get all the
data necessary for the app.
Fixes#5462
