Commit graph

483 commits

Author SHA1 Message Date
Vanshika Arora
3295c6d972 resolved issue with german in no_notification (#2569) 2019-03-10 11:43:04 +05:30
Vanshika Arora
8733b7f315 fixed campaign layout for right to left languages (#2550)
* fixed campaign layout for right to left languages

* alignment
2019-03-09 10:43:24 +05:30
Silky Priya
b673527467 achievements in right-to-left layout (#2557) 2019-03-09 10:42:46 +05:30
Silky Priya
32752c2d1e Fab in landscape (#2559)
* fix fab in landscape orientation

* fixes fax in landscape orientation
2019-03-09 10:42:26 +05:30
srinivas1729
0c2ae1df18 Fix #2139: Now showing "Upload your media" text properly (#2539)
* "Upload your media..." text was being shown while contributions were
  still being loaded. Fixed things to show after load is finished and no
  contributions are present. Also updated text string since UI now uses
  FAB button for uploads (no camera/gallery) icons any more.
* Removed waitingMessage in ContributionsListFragment and from layout
  since its never VISIBLE, only GONE.
2019-03-06 00:36:08 +05:30
Madhur Gupta
ef6fd9f292 Fix Bug #2477 (#2488) 2019-02-27 01:58:15 +05:30
Vanshika Arora
105e5d7894 Made nearby notification also visible to right-to-left languages (#2365)
* Fixed Issue #2334

* resolved gradle changes

* changed gragle.wrapper
2019-02-27 01:55:27 +05:30
Ronak Lakhotia
01a7526477 Fix code quality issues (#2359)
* Minor changes

* Fix more errors

* Revert change

* Minor error fix

* Remove unused import

* Merge branch 'master' of github.com:commons-app/apps-android-commons into lint-errors

# Conflicts:
#	app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

* Minor changes

* Undo changes

* Undo performclick
2019-02-22 14:51:58 +05:30
Zhao Gang
9882d24651 Clean up placeholders in media detail fragment fields(Fixed #2471) (#2500)
Remove placeholders and let these descriptions only shown in Android
Studio layout preview. Use plain text in tools:text attributes so
relative string values can also be removed and ease the translation work.
2019-02-22 11:13:31 +05:30
Josephine Lim
b698d14172 Merge branch '2.10-release' 2019-02-18 19:13:24 +10:00
Vivek Maskara
083a7a80f0 Fix notification click (#2474) 2019-02-18 21:52:10 +13:00
Vivek Maskara
0ef60e050d
Revert "fixed. I have fixed the layout desingn of achivement activity (#2469)" (#2475)
This reverts commit c7e819d404.
2019-02-15 17:50:04 +05:30
Anike Nath
c7e819d404 fixed. I have fixed the layout desingn of achivement activity (#2469) 2019-02-15 17:39:31 +05:30
chris-fo
83770ea484 Changes achievement icon for: Images via "Nearby Places" (#2463) 2019-02-15 03:00:35 +00:00
Vivek Maskara
73bb0c52c9 Show wikidata edits done through the app (#2431)
* Show wikidata edits done through the app

* Minor changes based on code review
2019-02-13 05:58:22 +13:00
Shubham Pinjwani
a9629c6f99 Added option in the action bar menu to view archived notifications (#2422)
* changed layout and implemented archived notificaitons feature

* set different texts for toolbar,menu option and no notification text in archived

* modified the startup intent for NotificationsActivity

* disabled swipe on archived

* commit

* fixed navigation drawer on notification activity

* handled on back pressed

* updated strings.xml

* removed TODO

* some minor changes

* set progress bar visibility

* some code quality changes

* commit

* some code quality changes

* removing unused import statements
2019-02-10 16:10:08 +05:30
Vivek Maskara
f12837650a Use JSON SPARQL query for fetching nearby places (#2398)
* Use JSON response for nearby places

* Move okhttp calls to a different class

* wip

* Fetch picture of the day using JSON API

* Search images using JSON APIs

* tests

* Fix injection based on code review comments
2019-02-06 10:40:30 +05:30
Vanshika Arora
2cd375a11b Progressbar in category and media fragment now doesn't overlaps the views (#2382)
* graddle changes

* scrolling fixed for both media and category
2019-02-06 02:06:59 +05:30
Vivek Maskara
52ab39381e Add module for file picker for camera and gallery uploads (#2375)
* Use easy image for image picker

* Do not use harcoded mime type

* Use uploadable file for image uploads

* Add picker files in filepicker module

* Remove redundant checks for file

* Make usage of file extensions consistent

* Add javadocs

* Fix tests

* Enable image upload using bookmark activity

* Fix multiple uploads

* Fix external image uploads

* Fix chooser intents

* Fix image quality checks

* Segregate internal and external upload intents

* Invoke all error messages from one place

* Minor changes

* Fix tests

* Add image processing service tests
2019-02-03 22:40:31 +02:00
Vanshika Arora
1b62ac4d2d Code to retrive unknown notification and UI (#2340)
* request change, changed notification icon

* Completed task 1 of the work

* commit changes

* commit changes

* updated notification class

* before notification id

* gradle reverted

* Minor changes to mark notifications as read

* commit changes

* delete on swipe

* notification count

* sipe to delete

* changes

* worked on changes requested

* commit changes

* Fix notification count

* reviewed changes

* round icon, swipe with icon

* Fix pending NPE issues with notifications

* final commit

* graddle changes

* removed changes for testing
2019-02-02 19:21:58 +05:30
Vivek Maskara
16927057d0 Remove drawer layout from upload activity (#2380) 2019-02-01 23:31:28 +13:00
Vanshika Arora
f9adbbb48c Activity upload made full screen (#2370)
* graddle changes

* upload activity changes

* final commit
2019-01-31 15:41:11 +05:30
Vanshika Arora
f23cf3e7fa Caption can acquire the entire horizontal space (#2360)
* Fixed Issue #2357

* final commit

* final changes
2019-01-27 21:22:33 +05:30
Vanshika Arora
ada67e012c Fixed issue #1507 (#2348)
Fixed #1507: Add progress bar in Nearby list
2019-01-26 22:00:10 +05:30
Vanshika Arora
c04cb8cb9f Modified Image Layout (#2351)
* modified date format

* mediadetail fragment modified

* added the function in dateutils

* modified imports

* Fixed Issue #2350

* Undo other commit changes
2019-01-26 21:43:55 +05:30
Shubham Pinjwani
71920c8bbc made Version number selectable in About menu(#2342) (#2347) 2019-01-25 23:40:53 +05:30
Vanshika Arora
a12d62a095 fixed issue #2343 (#2344)
* fixed issue #2343

* build issues
2019-01-25 23:15:28 +05:30
ravi-kishan
fa406be9f0 Changed from harcoded text to string resource. Fix 2331 (#2338) 2019-01-25 21:52:48 +05:30
Shubham Pinjwani
e93564fb79 Improved Result of the quiz activity for smaller screens(#2010) (#2304)
* Improved Result of the quiz activity for smaller screens(#2010)

* added scroll view
2019-01-15 21:27:54 +05:30
vanshikaarora
1b7b909107 #2192 scroll issue resolved (#2290) 2019-01-13 16:00:33 +05:30
Supriya
2b45194379 Fix #2250: Make version number copyable in About screen (#2273)
* Make version number copyable

* Resolve Travis build fail

* Revert "Make version number copyable"

This reverts commit c3f435423a.

* Revert "Resolve Travis build fail"

This reverts commit 20e70b21fb.

* Add gen folder to gitignore
2019-01-06 01:28:45 +05:30
Vivek Maskara
be98a56ba0 Improve text for receiving shared images (#2266) 2019-01-04 00:05:00 +10:00
Adam Jones
5317063689 Fix night mode issues with search and categories (#2213) 2019-01-01 16:25:46 +05:30
Zhao Gang
af291a5fcc Fix #2163: Hide subtitle message when uploading a single image (#2169)
* Hide subtitle message when uploading a single image (#2163)

* updateSubtitleVisibility: Javadoc and replace if with ternary operator

* updateSubtitleVisibility: change findViewById to BindView

* Remove null checks for views

Null check is not required while binding views with butterknife.
2019-01-01 16:08:12 +05:30
Adam Jones
5c8a0cdd93 Add WhiteSearchBarTheme to styles.xml (#2211) 2019-01-01 15:55:34 +05:30
Adam Jones
96d540372a Improve search UI (#2189)
* Improve search UI

* Undo irrelevant parts of commit
2018-12-21 17:24:48 +02:00
Adam Jones
fb3136ab19 Spelling mistake fixes (#2151)
* Spelling mistake fixes

* Spelling mistake fix
2018-12-21 15:20:52 +02:00
Adam Jones
d31574f6cd Fix #2197: Links on about page in night mode are correct color (#2199) 2018-12-21 14:26:30 +02:00
Ojonathan
f521e8886d Fix night mode accent color (#2098) 2018-12-20 18:20:21 +00:00
Vivek Maskara
f3b450e020 Merge 2.9 release with master (#2174)
* Fix memory leak due to wikidata edit listener (#2048)

* Fix bookmark crash fix (#2047)

* Fix bookmark crash fix

* Fix check for bookmark creator

* Bug fix #2042 (#2056)

* Bug fix #2042
* Added a snack with retry when api in AA fails
* Increased connection timeouts in okhttpclient builder

* added missing string resource

* Bugfix/duplicate categories (#2080)

* Increased timeout to 60 seconds

* Bug fix #1550
* filter duplicate categories

* Fix crash because of inactive fragment UI (#2046)

* Fix crash because of inactive fragment UI

* Add java docs

* Add information icon action Fiixes #2055 2.9.0: the 'i' icon in nearby doesn't do anything (#2057)

* Localisation updates from https://translatewiki.net.

* Remove unused mediawiki api dependency (#1991)

* Categories with pipe suffix (#1873)

* Bug fix issue #1826
Changes made :
-Certain category names used to show suffixed with strings prefixed with pipe '|'. Removed everything after the pipe. As per the discussion on the thread, its safe to remove everything after the pipe, including the pipe

* review suggested changes
*Code formatting
*Extracted out the index of pipe in a variable
*Added issue link in comments

* Remove libraries section from README (#1988)

* Remove libraries section from README

* Add wiki link to "libraries used" to README

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Use alert dialog instead of popup window, for nearby information

* Revert irrelevant changes, sorry
2018-12-19 18:59:49 +02:00
Josephine Lim
21edcb7cbe
Retry failed uploads - #1556 Allow users to easily re-upload failed uploads... (#2112)
* Add cancel and retry buttons on layout contribution

* Make sure your retry logic works

* Add cancel method too

* Add javadocs and remove debug logs

* Remove two unused methods

* Remove old and unused retry buttons as we do for their functions

* Check internet connection before button function, since function requires internet connection

* Remove unused variable

* Display possible solution for badtoken error

* Fix string
2018-12-20 02:56:00 +10:00
Adam Jones
0f69deab84 Fix #2147: Remove strings from notification and place layouts (#2150) 2018-12-19 01:33:48 +05:30
Zhao Gang
db38174eb4 Fix #2156: Add plural support for share_license_summary string (#2161) 2018-12-18 17:29:11 +00:00
HectorRoblesWolf
790bb3c19e Issue #1981 fixed (#1998)
* notification: replaced ReadMoreTextView by TextView

* removed com.borjabravo:readmoretextview:2.1.0 package

* Update build.gradle

Re-add implementation 'com.borjabravo:readmoretextview:2.1.0' to prevent travis fail
2018-12-18 13:59:33 +02:00
Adam Jones
1213678040 Use fitCenter instead of centerCrop where sensible (#2149) 2018-12-17 15:53:47 +02:00
Divyanshu Shukla
83b52fc1b9 Fixed #1948 Search feature is light in dark theme (#1951)
* Fixed #1930 Achievements activity is crashing on Android 8.1

* Fixed #1930 Achievements activity is crashing on Android 8.1

* Delete gradle-wrapper.properties

* Update build.gradle

* Create gradle-wrapper.properties

* fixed #1948 Search feature is light in dark theme

* Update FileUtils.java

* Update FileUtils.java

* Update FileUtils.java

* Fixed #1948 Search feature is light in dark theme

* changed files for the build

* Made the changes asked for

* Made the changes asked for

* Update gradle.properties

* Update gradle.properties

* Made changes in RecentSearchFragment
2018-12-17 13:43:58 +02:00
Mojtaba Rahimy
f79456ec8e "Skip Tutorial" button moved to parent view so that it does not animate by swipes. (#1945)
* Update WelcomeActivity.java

Now it starts welcome screen after not finishing the pager. Moved "Skip Tutorial" button here so it does not animate by swipe.

* Update activity_welcome.xml

Putting  "Skip Tutorial" button here so that it does not animate by swipes.

* Update LoginActivity.java

Removing the set of "first run " flag from here. we set it after the buttons press or on WelcomeActivity's finish()

* Update welcome_do_upload.xml

removing "skip tut" button from here.

* Update welcome_dont_upload.xml

Removing  "Skip Tutorial" button from here so that it does not animate by swipes.

* Update welcome_image_details.xml

Removing  "Skip Tutorial" button from here so that it does not animate by swipes.

* Update welcome_wikipedia.xml

Removing  "Skip Tutorial" button from here so that it does not animate by swipes.

* Update WelcomePagerAdapter.java

the "welcomyesButton" is removed from the child views in pager, so it is optional now.

* Add JavaDoc to WelcomeActivity.onBackPressed()

* Fix #2103: Remove welcomeYesButton from landscape layout

* Refactor WelcomePagerAdapter
2018-12-17 13:20:13 +02:00
Ashish Kumar
1b01c6517f Show campaigns (#2113)
* Show campaigns
* Added a ui util class SwipableCardView which passes the onSwipe event to its children
* NearbyCardView & CampaignView extend SwipableCardView
* Fetch campaigns in ContributionsFragment
* Added an option to enable disable campaign in Settings/Preferences

* synced strings with master

* removed duplicate initialsation of CampaignPresenter
2018-12-15 02:55:53 +10:00
Shridhar Goel
2175ba2d89 Fix #2104 by removing delete recent searches button when list is empty (#2105)
* Fix #2104 by removing delete recent searches button when list is empty
* Changed text to 'No recent searches' when the list is empty
2018-12-13 13:04:29 +00:00
neslihanturan
c7f6849cef Add cancel and retry buttons on layout contribution 2018-12-12 17:15:15 +03:00