Commit graph

6157 commits

Author SHA1 Message Date
Adam Jones
1cbce77d5f
Migrate from Kotlin synthetics to Jetpack view binding (#5546) 2024-02-14 18:29:06 +09:00
Shashwat Kedia
b18117bc07
Resolved Problems in UploadMediaDetails flow and UX #5511 (#5527)
* Fixed arrow flickering issue on zoom

* Resolved issue point 1 and 3

* Resolved issue point 2

* Minor changes

* Update UploadActivity.java

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-02-14 18:07:51 +09:00
Shashank Kumar
a308a1c8b5
Fix Methods Usage Incompatible with Android API Level 21 (#5525) 2024-02-14 09:05:13 +00:00
Shashank Kumar
8df7f66992
Show Labels For FAB in Contribution Page (#5493) 2024-02-13 21:33:03 +00:00
translatewiki.net
d8b7e27b48 Localisation updates from https://translatewiki.net. 2024-02-12 13:02:39 +01:00
Shashank Kumar
1895bb3ec2
Fix - Unable to Access Privacy Policy (#5534)
* Fix - Unable to Access Privacy Policy

* cleanup
2024-02-11 21:11:20 +09:00
Paul Hawke
f9090b0c2c
Consistent api interfaces (#5530)
* Converted CategoryInterface to kotlin

* Converted DepictsInterface to kotlin

* Convert the MediaDetailInterface to kotlin

* Convert MediaInterface to kotlin

* Convert ReviewInterface to kotlin

* Convert the UserInterface to kotlin

* Convert the WikiBaseInterface to kotlin

* Convert WikidataInterface to kotlin

* Convert WikidataMediaInterface to kotlin

* Convert UploadInterface to kotlin
2024-02-09 13:43:01 +09:00
Paul Hawke
c6cb97e199
Add ability to suppress logging of known unsuccessful API calls (#5526) 2024-02-09 06:55:56 +09:00
translatewiki.net
ba11f0d06e Localisation updates from https://translatewiki.net. 2024-02-08 13:02:19 +01:00
translatewiki.net
a534c11bbb Localisation updates from https://translatewiki.net. 2024-02-05 13:03:06 +01:00
Paul Hawke
0c3085257d
Data client simplification / removal (#5507)
* Removed unused code from the data client module

* Move remaining code out of the data-client and remove it
2024-02-03 10:26:06 +09:00
Shashank Kumar
72a6fd2c90
Enhancement - Nearby banner shows Item without image (#5468)
* Enhancement Nearby banner shows Item without image

* spacing

* Enhancement Nearby banner shows Item without image

* spacing

* Fix Crash

* Reverted "Fix Crash"

This reverts commit a41c9362bb.

* Fixed

* Fix null location

* Fix Conflict

* Show Only Items that exists

---------

Co-authored-by: shashankkumar <shashankkumar45556@gmail.com>
Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-02-01 22:17:52 +09:00
translatewiki.net
60046f4881 Localisation updates from https://translatewiki.net. 2024-02-01 13:02:45 +01:00
Paul Hawke
8db0b54929
Remove the data-client app adapter implementation (#5499)
* logErrorsInsteadOfCrashing only ever returned false, so remove it and simplify logger

* Removed unused getMediaWikiBaseUrl()

* Removed getDesiredLeadImageDp() from commons app adapter, since it's unused

* Inlined the isLoggedIn() method of the app adapter

* Inline the app adapter username/password

* Removed the unused getRestbaseUriFormat() from the commons app adapter

* Remove references to the data-client SharedPreferenceCookieManager

* Manage our own OkHttpClient and remove the AppAdapter implementation
2024-01-31 10:21:43 +09:00
Paul Hawke
ab9e57f5be
Decouple from the data-client service factory, with some code cleanup in the process (#5496) 2024-01-30 07:46:01 +09:00
translatewiki.net
7ec2a22fce Localisation updates from https://translatewiki.net. 2024-01-29 13:03:35 +01:00
Shashank Kumar
8bafee3801
Enhancement-Show Icon Labels When Long Pressed (#5492)
* Enhancement-Show Icon Labels when Long Pressed

* Tests Added
2024-01-29 17:05:43 +09:00
Nicolas Raoul
a8545abff2 Merge remote-tracking branch 'origin/switch-to-commons-toolforge' 2024-01-29 15:35:33 +09:00
Rohit Verma
9f7e407181
DepictsFragment: add null check for media (#5488) 2024-01-29 15:33:36 +09:00
Paul Hawke
84ffffbbe7
Create CsrfTokenClient and LoginClient by injection, along with a little cleanup (#5491) 2024-01-29 12:36:57 +09:00
Shashwat Kedia
5661e8c332
Fixed flickering of nearby banner compass (#5486) 2024-01-29 09:02:30 +09:00
Kaartic Sivaraam
f1276e4697 Fix broken reference to a missing resource ID
Seems like a fallout of the change done in PR #5464

This hopefully should make the instrumentation tests resume.
2024-01-28 17:53:27 +05:30
Kaartic Sivaraam
805076ee6b Update test case for the toolforge URL change 2024-01-28 17:09:43 +05:30
Kaartic Sivaraam
611f40801e Switch to using the commons toolforge instance fully
So far we used both the urbanecmbot instances and also the commons-android-app
toolforge instance for the functioning of the app.

The reality is that the commons-android-app instance itself had the ability
to return all the data necessary for the app. Use the same to get all the
data necessary for the app.

Fixes #5462
2024-01-28 14:27:13 +05:30
Paul Hawke
9e970123fd
Removed references to the data-client Service interface (#5484) 2024-01-28 08:25:56 +09:00
Shashwat Kedia
8222c4a42c
Resolves Issue #5413 Crash when opening Nearby when location permission hasn't been granted yet (#5418)
* Resolves Issue #5413

* Added Javadoc and formatted code
2024-01-27 22:47:36 +09:00
Kanahia
71de19f27b
Fixed javadoc issue (#5481) 2024-01-27 22:40:18 +09:00
Kanahia
96b2608eb1
Replace Mapbox with OSMDroid (Explore Activity) (#5475)
* Fixed Grey empty screen at Upload wizard caption step after denying files permission

* Empty commit

* Fixed loop issue

* Created docs for earlier commits

* Fixed javadoc

* Fixed spaces

* Added added basic features to OSM Maps

* Added search location feature

* Added filter to Open Street Maps

* Fixed chipGroup in Open Street Maps

* Removed mapBox code

* Removed mapBox's code

* Reformat code

* Reformatted code

* Removed rotation feature to map

* Removed rotation files and Fixed Marker click problem

* Ignored failing tests

* Added voice input feature

* Fixed test cases

* Changed caption and description text

* Replaced mapbox to osmdroid in upload activity

* Fixed Unit Tests

* Made selected marker to be fixed on map

* Changed color of map marker

* Fixes #5439 by capitalizing first letter of voice input

* Made UI changes in UploadMediaDetailAdapter

* Added javadoc

* Replaced Mapbox with OSMDroid in explore activity

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-01-27 21:39:08 +09:00
Paul Hawke
02ce017c98
Convert the LoginClient to kotlin (#5479)
* Convert the result classes to kotlin

* Convert response and callback to kotlin

* Cleanup code-quality warnings before converting

* Converted the LoginClient to kotlin

* Updated the UserExtendedInfoClientTest to be kotlin, and live in the correct spot
2024-01-27 12:39:00 +09:00
Paul Hawke
0541aacdff
Move login client out of the data-client (#5476) 2024-01-26 23:11:44 +09:00
Shashank Kumar
8789879f10
Fix Multi-Upload Wizard only asks Metadata for one picture (#5478)
* Fix Multi-Upload Wizard only asks Metadata for one picture

* javadoc

* typo

---------

Co-authored-by: shashankkumar <shashankkumar45556@gmail.com>
Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-01-26 22:43:07 +09:00
translatewiki.net
5225f3e7f2 Localisation updates from https://translatewiki.net. 2024-01-25 13:03:23 +01:00
Paul Hawke
97a208dcfa
Refactor CSRF token API to move it into the main commons code base (#5472)
* Remove redundent constructor parameter

* Converted the CsrfTokenClient and test to kotlin

* Moved getCsrfTokenCall() out of the data client
2024-01-24 22:15:51 +09:00
Shashank Kumar
e8e87b1d1c
Fix crash upload wizard (#5466)
* Upload Wizard Crash Fix

* Upload Wizard Crash Fix 2

* Fixes

---------

Co-authored-by: shashankkumar <shashankkumar45556@gmail.com>
2024-01-24 18:30:49 +09:00
Paul Hawke
8b8eb84fae
Moved the CSRF token client over into main commons code (#5471) 2024-01-24 10:36:43 +09:00
Kanahia
3d0e65c92c
Fixes on Edit button, there is + sign overlayed over letter E #5388 (#5464)
* Fixed Grey empty screen at Upload wizard caption step after denying files permission

* Empty commit

* Fixed loop issue

* Created docs for earlier commits

* Fixed javadoc

* Fixed spaces

* Added added basic features to OSM Maps

* Added search location feature

* Added filter to Open Street Maps

* Fixed chipGroup in Open Street Maps

* Removed mapBox code

* Removed mapBox's code

* Reformat code

* Reformatted code

* Removed rotation feature to map

* Removed rotation files and Fixed Marker click problem

* Ignored failing tests

* Added voice input feature

* Fixed test cases

* Changed caption and description text

* Replaced mapbox to osmdroid in upload activity

* Fixed Unit Tests

* Made selected marker to be fixed on map

* Changed color of map marker

* Fixes #5439 by capitalizing first letter of voice input

* Made UI changes in UploadMediaDetailAdapter

* Added javadoc

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-01-23 23:03:38 +09:00
Rohit Verma
ab3540312a
Resolve displaced icons problem for small screens sizes (#5467)
* UploadMediaDetailInputFilter: added pattern to identify colon

Added hex code of colon for MediaDetailInputFilter and updated test for it.

* styles.xml: removed color styles for floatingActionButton
2024-01-23 22:59:57 +09:00
Srishti Rohatgi
495d001dc9
Send thanks button in more details fragment (#5424)
* Send thanks button in more details fragment

* failing test fix

* suggested fix
2024-01-23 22:55:16 +09:00
Paul Hawke
3c1cdf18a1
Move notification API into main commons codebase (#5465)
* Moved the notification API calls out of the data client

* Converted the NofificationClient to kotlin and improved its test
2024-01-23 22:43:37 +09:00
translatewiki.net
1948bab873 Localisation updates from https://translatewiki.net. 2024-01-22 13:02:37 +01:00
Paul Hawke
ef47b7025e
Move thanks API into main commons codebase (#5463)
* Move thanks API into main commons codebase

* KDoc

* KDoc

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-01-22 13:57:01 +09:00
Shashwat Kedia
2c086b3d79
Updating nearby banner on slight location change (#5459) 2024-01-21 18:01:16 +09:00
Shashwat Kedia
cbf022d2f2
Resolves #5445 highlighting nearest place on clicking home nearby banner (#5453)
* Highlighted nearest place when user clicks on home nearby banner

* Fixed incorrect behaviour of home nearby banner on being clicked

* Fixing failure of unit test cases

* spacing

* indentation

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-01-19 14:16:36 +09:00
Kanahia
b7323d0913
Fixes #5439 by capitalizing first letter of voice input (#5450) 2024-01-19 13:37:39 +09:00
Nicolas Raoul
1ebbe63fc7
Previous key Commons-GitHub2 key was abused on January 6 2024-01-19 13:10:02 +09:00
translatewiki.net
86608ede54 Localisation updates from https://translatewiki.net. 2024-01-18 13:02:47 +01:00
Kanahia
6319da5445
Replaced mapbox to osmdroid (Upload Activity) (#5443)
* Fixed Grey empty screen at Upload wizard caption step after denying files permission

* Empty commit

* Fixed loop issue

* Created docs for earlier commits

* Fixed javadoc

* Fixed spaces

* Added added basic features to OSM Maps

* Added search location feature

* Added filter to Open Street Maps

* Fixed chipGroup in Open Street Maps

* Removed mapBox code

* Removed mapBox's code

* Reformat code

* Reformatted code

* Removed rotation feature to map

* Removed rotation files and Fixed Marker click problem

* Ignored failing tests

* Added voice input feature

* Fixed test cases

* Changed caption and description text

* Replaced mapbox to osmdroid in upload activity

* Fixed Unit Tests

* Made selected marker to be fixed on map

* Changed color of map marker
2024-01-18 14:28:53 +09:00
Rohit Verma
11e7b1cde7
UploadMediaDetailInputFilter: added pattern to identify colon (#5451)
Added hex code of colon for MediaDetailInputFilter and updated test for it.
2024-01-18 09:23:50 +09:00
Shashwat Kedia
1aa07f9368
Resolves #2307 make achievements activity more visible (#5442)
* Resolves #2307 by adding user level in menu

* Formatted code as requested

* Start sentence with uppercase

* javadoc

* Fixed my typo

* javadoc

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
2024-01-17 15:49:14 +09:00
Paul Hawke
56e21ab7c8
Removed butterknife and cleaned up the test (#5446) 2024-01-17 15:35:14 +09:00