maskara
eb3e448452
Refactoring based on comments
2018-01-13 23:59:45 +05:30
maskara
e1afa6081e
Refactor usage of dagger application with fixed dagger application
2018-01-13 16:16:47 +05:30
Paul Hawke
874627e3f5
Injected the ModifierSequenceDao where needed.
2018-01-05 13:01:20 -06:00
Paul Hawke
9927879680
Injected the ContributionDao where needed.
2018-01-05 08:34:48 -06:00
Dmitry Brant
da82466a17
Take out legacy event logging from app.
...
These are especially old bits of code, where it seems like WMF folks had set up Eventlogging schemas for some rudimentary analytics of the Commons app. These schemas are no longer queried or monitored, and can be safely removed. When the Commons app has a stronger need for more meaningful analytics, we can revisit reintroducing new and better schemas.
2017-12-05 23:01:55 -05:00
Paul Hawke
02b5b9b680
Merge branch 'master' into dependency-injection
2017-11-24 22:30:08 -06:00
Ram Gudivada
3c9b325e58
Changed activity creation logic
...
- for home activity it will reuse existing activity from back stack and
also clears all current activities
- for nearby, about and settings, it will use the existing activity from
back stack
2017-11-20 21:37:10 -08:00
Paul Hawke
f134d23ecb
Merge branch 'master' into dependency-injection
2017-10-21 17:20:56 -05:00
Sergey Kozelko
43af519a16
Fix Codacy issues
2017-10-18 21:57:57 +03:00
Paul Hawke
accd7edb7d
Merge branch 'master' into login-screen-improvement
2017-10-10 22:13:25 -05:00
Paul Hawke
e416a0f48d
Simplified the style.xml to remove items that remain constant across day/night mode.
2017-10-09 18:47:44 -05:00
Paul Hawke
cc2bb36560
Code cleanup to make the class more readable, extracted string resource and dealt with warnings.
2017-10-07 16:42:06 -05:00
Paul Hawke
3d0d48745e
Better messaging for the user.
2017-10-07 11:10:43 -05:00
Paul Hawke
f55c27a625
Updated theming for the new login screen
2017-10-07 09:37:03 -05:00
poojithakr
fc9cd0a3b7
Fixing codacy issues. Reduced reported count from 550 to 518.
2017-10-04 00:28:11 -07:00
Paul Hawke
b305acd395
View injection with Butterknife
2017-09-27 21:53:00 -05:00
Paul Hawke
9aa021695b
@Injected shared preferences where needed
2017-09-27 21:30:41 -05:00
Paul Hawke
e33febf506
Merge branch 'master' into dependency-injection
2017-09-23 14:24:34 -05:00
Paul Hawke
c3d6d0eb44
Merge branch 'master' into lint-cleanup
2017-09-23 13:27:07 -05:00
Vishan Seru
3b5811921c
Moved sign up process redirection urls to build.gradle as buildConfig fields specific to beta and prod flavors and added necessary usages to SignupActivity
2017-09-16 20:12:57 +05:30
Paul Hawke
a208c9f273
Further reduced coupling between classes and the need to @Inject the account utils class, fixed imports.
2017-09-10 10:37:58 -05:00
Paul Hawke
9c0cbe7ad5
Further reduce code calling back to the CommonsApplication by pulling out a SessionManager to manage our current account.
2017-09-09 14:08:40 -05:00
Paul Hawke
15107e622b
Codacy suggestions for improvement.
2017-09-03 22:20:52 -05:00
Paul Hawke
13e84a82b8
Removed unused imports.
2017-09-03 17:05:37 -05:00
Paul Hawke
f74de55b60
Lint warning: Lambda can be replaced with method reference.
2017-09-03 16:52:52 -05:00
Paul Hawke
388f588301
Correctly configured injection for fragments and services.
2017-08-26 08:57:16 -05:00
Paul Hawke
647cc166ef
@Inject the MediaWikiApi where needed to reduce coupling between classes.
2017-08-26 08:56:15 -05:00
Paul Hawke
8fe2816ca9
First baby steps into the world of dependency injection using Dagger.
2017-08-26 08:56:14 -05:00
Mikel
5cb1f7281b
Fix wrong condition
2017-08-18 20:06:18 +01:00
Mikel
591b10f4c9
Add error message to exception
2017-08-18 20:04:59 +01:00
Mikel
f2e8891db9
Simplify AddAccount task
2017-08-18 17:35:24 +01:00
Mikel
6b80bec3c9
Simplify GetAuthCookie task
2017-08-18 17:34:55 +01:00
Josephine Lim
5796d14e9e
Merge pull request #839 from YDrall/backstack_issue
...
remove signup activity from activity's backstack.
2017-08-14 01:28:54 +10:00
ydrall
68462eac2b
make SignupActivity to terminate on task completion
2017-08-11 15:02:15 +05:30
neslihanturan
0005b82421
Revert "Adding username to Drawer"
2017-08-10 13:56:51 +03:00
Bruce Nishimura
06efa26f5e
Readding log that I accidently deleted
2017-08-02 00:44:27 -04:00
Bruce Nishimura
a014900e37
Removed username from preferences, now uses current account.
...
Improved text positioning/styling slightly.
2017-08-02 00:38:34 -04:00
Bruce Nishimura
2764bc4dd8
Using general preferences instead, splitting long lines.
2017-07-31 20:47:55 -04:00
Bruce Nishimura
d3ce751f59
Added username to picture of the day icon.
2017-07-31 17:08:47 -04:00
Paul Hawke
4796557fb7
Made a pass through the code to introduce lambdas / method references in the places the Android Studio suggested.
2017-07-22 18:04:40 -05:00
Yusuke Matsubara
3b728ca568
Coding style fixes
2017-07-16 15:13:40 +09:00
Josephine Lim
ee409a9e8f
Merge pull request #769 from tised/#748_issue
...
fix for #748
2017-07-16 02:32:26 +10:00
Paul Hawke
8e47f82de6
Merge remote-tracking branch 'upstream/master'
2017-07-15 06:16:31 -05:00
Yusuke Matsubara
d241d36d66
Add PageTitle class to canonicalize page names
2017-07-13 18:29:30 +09:00
Dmytro Vodnik
f3d7465fef
fix for #748
...
that fields doesnt popup because they was shown only after onAuthCookieAcquired fired
2017-07-12 12:28:53 +03:00
Paul Hawke
599e7bb453
Consolidated media wiki api calls in a single place
2017-07-04 14:24:08 -05:00
Paul Hawke
5396fc6ed0
Optimized imports before starting
2017-07-04 14:23:13 -05:00
maskara
bcca6b15e5
Ability to launch welcome activity again
2017-05-29 01:17:07 +05:30
Josephine Lim
c83a0e8e59
Merge pull request #682 from dbrant/textwatcher
...
Always remove TextWatchers when finished with them.
2017-05-28 22:12:02 +10:00
Dmitry Brant
dea43c04b9
Make sure to remove backstackChangeListener when finished.
2017-05-26 16:32:00 -04:00
