Description (required)
Fixes commons-app#4161
In the comments of the class PageEditClient.java "@param pagetitle" is written in three areas in this file. It should have been "@param pageTitle" with capital T as pageTitle is being passed as an argument rather than pagetitle.
What changes did you make and why?
Changes are made in the comments of fil where the parameters for Observable method are stated. pagetitle has been changed to pageTitle as the correct argument passed. This change would increase the code readability for fellow developers.
* fixed the contribution crash on scroll
* Investigation
Just to get the Log of the issue
* fixed null data causing scroll to top
* Removed unneeded log import.
* Fixes#3341, #4018
* Defined two feild author and user in Media and used them at the corresponding places
Minor bug fixes
-displaying userName in uploadedBy.
-modified HTML parsing in getArtist.
-Replaced creator with author.
* Fixes#3341, #4018
* Defined two feild author and user in Media and used them at the corresponding places
Minor bug fixes
-displaying userName in uploadedBy.
-modified HTML parsing in getArtist.
-Replaced creator with author.
* fixes#4001
* Overrides the onSaveInstanceState method and onRestoreInstanceState method in LoginActivity.java
* In onSaveInstanceState save ProgressDailog state or visiblity and text of TextView(errorMessage)
* In onRestoreInstanceState restore All saved Data
* Update the commit -1a92b17e37
* formatting the codechanges
* reformated the codechange
* Add additional classes from 2019 hackathon implementation
* Make first tab work
* Make explore tab work
* Handle back button for contrib and nearby
* Fix framelayout and nav bar allignment
* Fix nav bar tint
* Fix nearby card layout
* Make contributions number visible
* Change menu icon according to fragment
* Make notification icon work and remove drawer
* Make favourites accessible from nav bar
* Turn bookmark and explore activities into fragments
* Use bottom sheet instead of more fragment
* Add actions
* Remove unused classes
* Fix indentation
* remove more fragment title
* Fix explore fragment indentation
* Make toolbar settings as we wanted
* Set card view styles
* Make colors for explore actiivty
* Remove drawer from achievements activity
* Add back button to achievements activity
* remove drawer from review activity
* Remove drawer from settings activity
* Remove drawer from about activity
* Fix dagger injection of fragment
* Implement skip login version
* Add theme missing colors
* Add style to moresheet
* refactor name
* call login with button
* Remove all old bookmarks activity dependency
* Make explore tab items clickable
* Do nothing if same tab is selected
* Fix notification icon color for dark theme
* Fix wrong drawable colors
* Handle back button after media details is visible from contrib and explore fragments
* make favourites open media details
* Fix profile icon
* Make user name visible instead
* Move user back to contrib fragment
* Remove NavigationBaseAvticity
* Fix typo in bookmark fragment
* Fix menu button colors
* Remove explore activity
* remove drawer and dependencies
* Make bookmark media details visible
* Cleanup code
* Code cleanup
* Remove unused layout
* Make contriblist UI look like in mockups
* Change limited connecton toggle
* Move list menu item to nearby fragment
* Fix search button crash
* Make media detail appear
* Back button added
* Fix back button npe
* Change bookmark list view
* Fix always the firs item displayed issue
* Allign contrib list bottom line to simple drawee bottom
* fix fragment string
* Fix back button for mobile uploads
* Make lists appear
* Make fav item selected
* Make favourites clickable
* Add back button to media details
* Add toolbar of notification activity
* Change contributions icon
* Fix card UI
* Fix back button in explore
* Make card views look similar to mockups
* Solve campaign bug visible issue
* Make borders a little softer
* Refactored scrollToUserRank to account for users scrolling from below their rank
* Refactored my change to use a similar method
* Added comments to change
* Removed leftover cruft
* Reverted package updates
* Added tests for the LeaderBoard UI
* Fixes#3923
* Handled possible missing backpress cases in MainActivity-nearby
* Fixes#3923
* Handled possible missing backpress cases in MainActivity-nearby
* Fixes#3920
* Delete stale log files post the zip file's size reaches 1000kb
* Fixes#3920
* Delete stale log files (if the size reaches more than 1000kb) on App startup to make room for fresh logs
* #3624 DateTimeFormat wrong - match pattern returned from servers (#3625)
* Revert "Fixes: #3179 Make category search non case-sensitive (#3326)" (#3636)
Simply lower casing the name of the category sent to the server
doesn't result in the server doing a case insensitive category
search. In fact, it reduces the category search space as only
categories that has a lower case character is searched even
if the search text contains upper case characters.
The test case did not catch this issue as the first character
of the title is case insensitive[1].
So, revert the changes done in commit afdeaae075.
See further disucssion in the issue thread of #3179 starting
from [2].
[1]: https://www.mediawiki.org/wiki/Manual:Page_title
[2]: https://github.com/commons-app/apps-android-commons/issues/3179#issuecomment-605462140
* Bugfix/security exception (#3627)
* Fixes#3626
* Check is file is actually created before writing to file, file picker android
* Handle Security exception
* Fixes#3436 and #2881: Media Detail design Overhaul (#3505)
* ic_map_dark_24dp: map icon for white background
* ic_info_outline_dark_24dp: info icon for dark background
* MediaDetailFragment: update the spacer as per image aspect ratio
* fragment_media_detail: design overhaul
* fragment_media_detail: remove redundant background color statements
* make requested changes
* add dark mode support
* minor ui tweak
* white map icon in dark mode
* make rquested changes
* make requested changes to layout
* fix misalignment of category list
* subtle amendments
* convert comments to javadocs
* minor amendments
* minor changes
* add styles for media detail
* Media detail fragment refactored
* make suggested changes
* minor name fix
* fix the delete button border
* Fixes#3639 (Fix Save State implementation of CheckBoxTriState ) (#3686)
* Add #3723 and #3721 to 2.13 release, fix conflicts
Conflicts were caused by merging #3723 before #3721 , so I just rolled both into one commit.
* Fix NullPointer when clicking on image in MediaDetailFragment (#3730)… (#3739)
* Update changelog.md
* Versioning for v2.13
* Fixes#3705 (Crash when viewing pic I just uploaded) (#3782)
* Fixes#3705
* Let the MediaDetailPager fragment know when the contributions have been updated
* Handle NPE, null check on adapter in MediaDetailPagerFragment
* Fixed BookmarkLocationsDao DB migration (#3793)
* Fixes#3725 (#3795)
* Downgraded okhttp version to support Api 19 devices
* Handled null CompoundDrawable[2] in etTitle-> UploadMediaDetailsFragment (#3828)
* DownSample Upload image to be shown in UploadMediaDetailFragment to handle OOM, Bitmap Too large exception (#3830)
* Fixes#3829
* DownSample Upload image to be shown in UploadMediaDetailFragment to handle OOM, Bitmap Too large exception
* removed unused imports, handled possible exceptions
* Let Fresco handle the downsampling of image
* invalidate in onTransformEnd
* Expose an interface TransformationListener in ZoomableDraweeView to listen to transformation change end
* removed photoView dependency
* removed unused imports in ZoomableActivity
* Bugfix, expand/collapse
* changed functio name
* Bugfix/p18 uploads (#3869)
* updated gradle plugin version
* BugFix #3856
* Do not use preference for deciding acceptable lat long for nearby uploads, instead save the corresponding location in the Contribution via UploadItem
* Marshall contribution's hasInvalidLocation
* reset un-related changes
* Fixed test cases
* Minor code formatting and docs
* Fixes#3882 (#3883)
* Make hasInvalidLocation non-null integer with default value 0
Co-authored-by: Ashish Kumar <ashish@Ashishs-MacBook-Air.local>
* Fixes#3766, Added OPENSTREET attribution (#3889)
* Fixes#3766
* Added OPENSTREET attribution in nearby
* Added custom text attribution in Nearby
* Deleted unused class CustomBorderTextView
* review suggested changes
* modified telemetry summary string
* Versioning and changelog for v2.13.1 (#3908)
* Update changelog.md
* Versioning for v2.13.1
* Fixes#3914 (#3915)
* Verify user login before setting upload count
* fixed compile-time error
* fix erros
* delete emptied files
* remove empty file CategoriesModel.java
Co-authored-by: Seán Mac Gillicuddy <seantheappdev@gmail.com>
Co-authored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Co-authored-by: Kshitij Bhardwaj <44129798+kbhardwaj123@users.noreply.github.com>
Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com>
Co-authored-by: Josephine Lim <josephinelim86@gmail.com>
Co-authored-by: Ashish Kumar <ashish@Ashishs-MacBook-Air.local>
* Fixes#3734
* Donot ignore case while searching categories
* Fixed test-cases to ensure search terms are passed as it is to the CategoryClient
* Used a First_Char_Caps title list term just to ensure test case tests as intended
* Fixed searchAll with empty term test case
