Dmitry Brant
da82466a17
Take out legacy event logging from app.
...
These are especially old bits of code, where it seems like WMF folks had set up Eventlogging schemas for some rudimentary analytics of the Commons app. These schemas are no longer queried or monitored, and can be safely removed. When the Commons app has a stronger need for more meaningful analytics, we can revisit reintroducing new and better schemas.
2017-12-05 23:01:55 -05:00
maskara
db8cae95e4
Fix Fresco initialization
2017-12-04 02:33:36 +05:30
Paul Hawke
02b5b9b680
Merge branch 'master' into dependency-injection
2017-11-24 22:30:08 -06:00
misaochan
785bed90ba
Send log file to private Google group forum instead
2017-11-22 01:16:36 +10:00
maskara
6a6ba7d542
Fix Leak canary test
2017-11-13 23:16:27 +05:30
maskara
d4bafd94e0
Fixes leaks in contribution and nearby activity
2017-11-13 23:15:53 +05:30
maskara
6a7b7cbbe8
Introduce dagger
2017-11-12 01:04:10 +05:30
Yusuke Matsubara
e317c369c1
Disable LeakCanary for Robolectric tests
...
See 'For Robolectric users:' https://github.com/square/leakcanary
2017-11-03 11:30:10 +09:00
Paul Hawke
f134d23ecb
Merge branch 'master' into dependency-injection
2017-10-21 17:20:56 -05:00
Sergey Kozelko
43af519a16
Fix Codacy issues
2017-10-18 21:57:57 +03:00
poojithakr
fc9cd0a3b7
Fixing codacy issues. Reduced reported count from 550 to 518.
2017-10-04 00:28:11 -07:00
Paul Hawke
9aa021695b
@Injected shared preferences where needed
2017-09-27 21:30:41 -05:00
Paul Hawke
e33febf506
Merge branch 'master' into dependency-injection
2017-09-23 14:24:34 -05:00
Paul Hawke
2d91e81121
Merge branch 'master' into dependency-injection
2017-09-13 20:29:50 -05:00
Paul Hawke
d4fd6f8b77
Merge branch 'master' into lint-cleanup
2017-09-13 19:16:55 -05:00
neslihanturan
ffc7c80678
Merge pull request #857 from psh/beta-cluster
...
Product flavors for production and the beta-cluster Wikimedia servers
2017-09-13 10:57:31 +03:00
Paul Hawke
9c0cbe7ad5
Further reduce code calling back to the CommonsApplication by pulling out a SessionManager to manage our current account.
2017-09-09 14:08:40 -05:00
Paul Hawke
e7d0c647c2
Merge branch 'master' into dependency-injection
2017-09-09 12:39:41 -05:00
Paul Hawke
15107e622b
Codacy suggestions for improvement.
2017-09-03 22:20:52 -05:00
Paul Hawke
a615e0784e
Cleanup the logout positive button lambda.
2017-09-03 16:45:19 -05:00
Yusuke Matsubara
7c956e803c
Merge pull request #856 from Bluesir9/issue_848_logout_contributions_redirect_issue
...
Added callback when removing accounts on logout
2017-09-03 20:34:31 +09:00
Vishan Seru
35fdb4350a
Fixed small bug when incrementing counter in AccountManagerCallback
2017-08-28 12:44:19 +05:30
Vishan Seru
b094d502d6
Took care of some issues pointed out by codacy in relation to the coding guidelines followed specifically to the changes made in this branch
2017-08-28 12:27:03 +05:30
Paul Hawke
ca4b99a1cc
Product flavors to allow switching between the production and the beta-cluster Wikimedia servers.
2017-08-26 15:42:44 -05:00
Paul Hawke
d0a85dbd82
Moved single-use code out of Utils over to where it's actually used.
2017-08-26 08:57:16 -05:00
Paul Hawke
cfe17cafa6
Moved other singletons over to being managed by Dagger
2017-08-26 08:57:15 -05:00
Paul Hawke
647cc166ef
@Inject the MediaWikiApi where needed to reduce coupling between classes.
2017-08-26 08:56:15 -05:00
Paul Hawke
ed1ae98d8e
Finished removing coupling between classes around the getInstance() method.
2017-08-26 08:56:15 -05:00
Paul Hawke
8fe2816ca9
First baby steps into the world of dependency injection using Dagger.
2017-08-26 08:56:14 -05:00
Vishan Seru
16487556dc
Added callback when removing accounts on logout to ensure that post logout screen transition happens only after complete logout procedure is complete.
2017-08-25 11:42:17 +05:30
Paul Hawke
97bbd51e13
Removed the popup and nav-drawer item relating to developer plans.
2017-08-24 22:19:43 -05:00
neslihanturan
401de30630
Merge pull request #834 from akaita/667_fix_categories
...
667 fix categories
2017-08-09 11:31:23 +03:00
Mikel
22cd1ac72a
Fix import
2017-08-06 20:09:45 +01:00
Jorge Casariego
b76fb516b6
Enable Stetho just on debug mode #813
2017-08-01 15:02:51 -04:00
Josephine Lim
a5a624f939
Merge pull request #808 from neslihanturan/oneTimePopUp
...
One time pop up
2017-07-27 16:49:22 +10:00
Neslihan
452dcaec72
Display pop up once, on 4th app start
2017-07-26 14:06:49 +03:00
Neslihan
19784f0e82
Add shared preferences
2017-07-23 18:10:42 +03:00
Paul Hawke
4796557fb7
Made a pass through the code to introduce lambdas / method references in the places the Android Studio suggested.
2017-07-22 18:04:40 -05:00
Paul Hawke
599e7bb453
Consolidated media wiki api calls in a single place
2017-07-04 14:24:08 -05:00
Deskana
767878f194
Remove unused imports
...
This patch removes imports across the codebase that are unused to improve
code maintainability and cleanliness.
2017-05-26 11:02:56 +01:00
Dmitry Brant
38e7cad345
Final touch-ups to improved image loading.
2017-05-19 17:19:10 +02:00
Dmitry Brant
7a4062a377
Merge remote-tracking branch 'upstream/master'
2017-05-19 16:27:08 +02:00
Dmitry Brant
9469bf29e4
Remove dependency on old image-loading library, and remote a lot of code.
2017-05-19 16:24:04 +02:00
Dmitry Brant
85b15cd1c1
Further improve image loading, and remove unused code.
2017-05-19 15:57:25 +02:00
Josephine Lim
6232e35816
Merge pull request #627 from dbrant/master
...
Clean up image loading code, and switch to using Fresco.
2017-05-19 15:20:33 +02:00
Dmitry Brant
a3f3ee7fdb
Merge remote-tracking branch 'upstream/master'
2017-05-19 15:14:29 +02:00
Dmitry Brant
bb49fb9801
Clean up image loading code, and switch to using Fresco.
2017-05-19 15:08:29 +02:00
Dinu Kumarasiri
7d6c836e31
Leak Canary Integration
2017-05-19 15:06:15 +02:00
addshore
4bda30116a
Update logic from PR 611 that was just merged
2017-05-16 15:20:53 +02:00
addshore
1785e9b179
Fix some codacy issues
2017-05-16 15:19:43 +02:00
