Commit graph

86 commits

Author SHA1 Message Date
knightshade
d7e0c81969 Add multidex library and extend CommonsApplication from MultiDexApplication.
Fixes #1225
2018-03-02 10:28:28 +05:30
Shradheya Thakre
9dd01b9170 Improve code quality 2018-02-14 14:16:41 +08:00
maskara
e1afa6081e Refactor usage of dagger application with fixed dagger application 2018-01-13 16:16:47 +05:30
Paul Hawke
f2ed57a127 Moved Category and CategoryDao to the 'category' package 2018-01-05 08:34:48 -06:00
Paul Hawke
08673c91c6 Extracted and tested the database interactions from ModifierSequence 2018-01-04 13:27:55 -06:00
Paul Hawke
1ba8e93346 Extracted and tested the database interactions from Category 2018-01-04 08:33:40 -06:00
neslihanturan
d6d38e0564
Merge pull request #1026 from psh/extract-and-test-contribution-db
Extracted and tested the database interactions from Contribution.
2018-01-02 13:58:10 +03:00
Paul Hawke
7c80991049 Extracted and tested the database interactions from Contribution. 2017-12-21 13:56:36 -06:00
Prajeen Govardhanam
1d94b8a87c
Update CommonsApplication.java 2017-12-21 20:54:37 +05:30
Prajeen Govardhanam
8f32fc1c01
Update CommonsApplication.java 2017-12-21 20:47:17 +05:30
prajgov
3d6c6e0301 added JavaDoc comments 2017-12-19 19:11:39 +05:30
neslihanturan
32bca87305
Merge pull request #1000 from misaochan/fix-send-logs-again
Send logs only to private Google group forum (round 2)
2017-12-15 14:39:41 +03:00
Dmitry Brant
da82466a17 Take out legacy event logging from app.
These are especially old bits of code, where it seems like WMF folks had set up Eventlogging schemas for some rudimentary analytics of the Commons app. These schemas are no longer queried or monitored, and can be safely removed. When the Commons app has a stronger need for more meaningful analytics, we can revisit reintroducing new and better schemas.
2017-12-05 23:01:55 -05:00
misaochan
824569a031 Modify group that logs get sent to 2017-12-06 01:20:24 +10:00
maskara
db8cae95e4 Fix Fresco initialization 2017-12-04 02:33:36 +05:30
Paul Hawke
02b5b9b680 Merge branch 'master' into dependency-injection 2017-11-24 22:30:08 -06:00
misaochan
785bed90ba Send log file to private Google group forum instead 2017-11-22 01:16:36 +10:00
maskara
6a6ba7d542 Fix Leak canary test 2017-11-13 23:16:27 +05:30
maskara
d4bafd94e0 Fixes leaks in contribution and nearby activity 2017-11-13 23:15:53 +05:30
maskara
6a7b7cbbe8 Introduce dagger 2017-11-12 01:04:10 +05:30
Yusuke Matsubara
e317c369c1 Disable LeakCanary for Robolectric tests
See 'For Robolectric users:' https://github.com/square/leakcanary
2017-11-03 11:30:10 +09:00
Paul Hawke
f134d23ecb Merge branch 'master' into dependency-injection 2017-10-21 17:20:56 -05:00
Sergey Kozelko
43af519a16 Fix Codacy issues 2017-10-18 21:57:57 +03:00
poojithakr
fc9cd0a3b7 Fixing codacy issues. Reduced reported count from 550 to 518. 2017-10-04 00:28:11 -07:00
Paul Hawke
9aa021695b @Injected shared preferences where needed 2017-09-27 21:30:41 -05:00
Paul Hawke
e33febf506 Merge branch 'master' into dependency-injection 2017-09-23 14:24:34 -05:00
Paul Hawke
2d91e81121 Merge branch 'master' into dependency-injection 2017-09-13 20:29:50 -05:00
Paul Hawke
d4fd6f8b77 Merge branch 'master' into lint-cleanup 2017-09-13 19:16:55 -05:00
neslihanturan
ffc7c80678 Merge pull request #857 from psh/beta-cluster
Product flavors for production and the beta-cluster Wikimedia servers
2017-09-13 10:57:31 +03:00
Paul Hawke
9c0cbe7ad5 Further reduce code calling back to the CommonsApplication by pulling out a SessionManager to manage our current account. 2017-09-09 14:08:40 -05:00
Paul Hawke
e7d0c647c2 Merge branch 'master' into dependency-injection 2017-09-09 12:39:41 -05:00
Paul Hawke
15107e622b Codacy suggestions for improvement. 2017-09-03 22:20:52 -05:00
Paul Hawke
a615e0784e Cleanup the logout positive button lambda. 2017-09-03 16:45:19 -05:00
Yusuke Matsubara
7c956e803c Merge pull request #856 from Bluesir9/issue_848_logout_contributions_redirect_issue
Added callback when removing accounts on logout
2017-09-03 20:34:31 +09:00
Vishan Seru
35fdb4350a Fixed small bug when incrementing counter in AccountManagerCallback 2017-08-28 12:44:19 +05:30
Vishan Seru
b094d502d6 Took care of some issues pointed out by codacy in relation to the coding guidelines followed specifically to the changes made in this branch 2017-08-28 12:27:03 +05:30
Paul Hawke
ca4b99a1cc Product flavors to allow switching between the production and the beta-cluster Wikimedia servers. 2017-08-26 15:42:44 -05:00
Paul Hawke
d0a85dbd82 Moved single-use code out of Utils over to where it's actually used. 2017-08-26 08:57:16 -05:00
Paul Hawke
cfe17cafa6 Moved other singletons over to being managed by Dagger 2017-08-26 08:57:15 -05:00
Paul Hawke
647cc166ef @Inject the MediaWikiApi where needed to reduce coupling between classes. 2017-08-26 08:56:15 -05:00
Paul Hawke
ed1ae98d8e Finished removing coupling between classes around the getInstance() method. 2017-08-26 08:56:15 -05:00
Paul Hawke
8fe2816ca9 First baby steps into the world of dependency injection using Dagger. 2017-08-26 08:56:14 -05:00
Vishan Seru
16487556dc Added callback when removing accounts on logout to ensure that post logout screen transition happens only after complete logout procedure is complete. 2017-08-25 11:42:17 +05:30
Paul Hawke
97bbd51e13 Removed the popup and nav-drawer item relating to developer plans. 2017-08-24 22:19:43 -05:00
neslihanturan
401de30630 Merge pull request #834 from akaita/667_fix_categories
667 fix categories
2017-08-09 11:31:23 +03:00
Mikel
22cd1ac72a Fix import 2017-08-06 20:09:45 +01:00
Jorge Casariego
b76fb516b6 Enable Stetho just on debug mode #813 2017-08-01 15:02:51 -04:00
Josephine Lim
a5a624f939 Merge pull request #808 from neslihanturan/oneTimePopUp
One time pop up
2017-07-27 16:49:22 +10:00
Neslihan
452dcaec72 Display pop up once, on 4th app start 2017-07-26 14:06:49 +03:00
Neslihan
19784f0e82 Add shared preferences 2017-07-23 18:10:42 +03:00