Commit graph

44 commits

Author SHA1 Message Date
Kshitij Bhardwaj
d7c2480174 Fixes #3436 and #2881: Media Detail design Overhaul (#3505)
* ic_map_dark_24dp: map icon for white background

* ic_info_outline_dark_24dp: info icon for dark background

* MediaDetailFragment: update the spacer as per image aspect ratio

* fragment_media_detail: design overhaul

* fragment_media_detail: remove redundant background color statements

* make requested changes

* add dark mode support

* minor ui tweak

* white map icon in dark mode

* make rquested changes

* make requested changes to layout

* fix misalignment of category list

* subtle amendments

* convert comments to javadocs

* minor amendments

* minor changes

* add styles for media detail

* Media detail fragment refactored

* make suggested changes

* minor name fix

* fix the delete button border
2020-04-22 01:23:14 +10:00
Kshitij Bhardwaj
642ed51c8c
Fixes #3414: For v2.13, Handle zoom in media details view (#3422)
* MediaDetailFragment: add zoom feature

* fragment_media_detail: add SimpleDrawee for Scroll picture

* ZoomableActivity: activity which facilitates zoom in

* activity_zoomable: xml for zoom activity

* zoomControllers: controllers for handling gesture and zooming

* MediaDetailFragment: fixing name of image variable

* MediaDetailFragment: display as per the aspect ratio of image

* add zoom activity to AndroidManifest

* fix travis ci faliure

* fix resizing of image
2020-03-09 21:07:48 +03:00
Ashish Kumar
c8a58bfc2e
Revert "Fixes #2337 - Show captions of image in media details (conflicts fixed) (#2933)" (#2934)
This reverts commit 3c9b7ba7a8.
2019-05-01 16:10:43 +05:30
neslihanturan
3c9b7ba7a8 Fixes #2337 - Show captions of image in media details (conflicts fixed) (#2933)
* Api call

* added captions

* final commit

* some minor changes

* sigular

* test for captions

* mock fetchCaptionbyFileName

* corrected method name

* * used ? instead of !! (unsafe call on nullable)
* updated unit test for fetchCaptionByFilename()
2019-05-01 15:08:38 +05:30
Vivek Maskara
5419733299 Center crop images (#2924) 2019-04-24 22:12:20 +03:00
Vivek Maskara
37e9eae314 Fetch and use thumbnail across the app (#2906) 2019-04-24 03:03:09 +10:00
Vivek Maskara
0bf63f50b3 Replace remaining AsyncTask with RxAndroid (#2681) 2019-03-28 21:10:47 +00:00
Adam Jones
4071d66d45 Remove duplicate information icon resources (#2734) 2019-03-28 13:28:17 +05:30
Shubham Pinjwani
31c688860d Fix #1850: Show media talk page in media details (#2560) 2019-03-17 17:11:34 +00:00
Zhao Gang
9882d24651 Clean up placeholders in media detail fragment fields(Fixed #2471) (#2500)
Remove placeholders and let these descriptions only shown in Android
Studio layout preview. Use plain text in tools:text attributes so
relative string values can also be removed and ease the translation work.
2019-02-22 11:13:31 +05:30
Mansi Agarwal
430bf90310 Added CDATA tag (#1836)
* Fix issue#1772

Add the CDATA tag to welcome_help_button_text string. Set the text of the corresponding textview using Html.fromHtml() function.

* Fix issue#1772

Add the CDATA tag to nominated_see_more string. Set the text of the corresponding textview using Html.fromHtml() function.
2018-08-31 11:44:36 +03:00
albendz
a059a3c2ef Add button on image details to copy wikicode to clipboard (#1849)
* Add button on image details to copy wikicode to clipboard

* Make copy wikicode button width the same as the nominate deletion button width by filling in background
2018-08-27 19:13:50 +10:00
Vivek Maskara
b108dff460
Merge branch 'master' into featuredImages 2018-04-19 23:44:33 +05:30
Vivek Maskara
463673f942
Merge branch 'master' into featuredImages 2018-03-24 12:46:38 +05:30
Suchit Kar
a449870d8b Change disabled appearance of Nominate for Deletion button 2018-03-20 19:46:24 +05:30
Suchit Kar
a39d398edd Make deletion-related views on MediaDetailFragment neater 2018-03-20 15:32:50 +05:30
Suchit Kar
e42c6feba4 Check status before nominating for deletion 2018-03-19 23:20:46 +05:30
Suchit Kar
369570537e Add delete task 2018-03-13 02:02:39 +05:30
Suchit Kar
6c38b58a29 Add deletion button 2018-03-01 20:13:57 +05:30
Shradheya Thakre
e71fc0492b Add space between Licence and Coordinates 2018-02-27 14:28:34 +08:00
neslihanturan
745a32107a Add author field to Media Detail Fragment layout 2018-01-22 13:44:33 +03:00
Paul Hawke
d9d174398d Initial pass to use standard margins/padding (in dimens.xml) 2017-12-22 15:24:30 -06:00
Mikel
7754c7c7c4 Fix vectors for drawableStart in API 17 2017-08-07 20:44:35 +01:00
Mikel
d314964018 Merge from master and add icons to clickable fields 2017-08-02 21:57:13 +01:00
Mikel
a025cc97d5 Merge branch 'master' into media_detail_enhance 2017-08-02 21:24:47 +01:00
Mikel
ff1cb190d9 Add ripple effect to Coordinates 2017-07-18 20:29:40 +01:00
Mikel
2ce7a464ca Remove Clickable behaviour of License and Coordinates 2017-07-18 20:20:44 +01:00
Mikel
0a6e8b0cc8 Improve RTL support in MediaDetail 2017-07-15 09:21:01 +02:00
Mikel
0b901deb01 Extract hardcoded strings to make them localizable 2017-07-15 09:20:36 +02:00
Dmitry Brant
5ab060567a Fix vector placeholder images in API <21. 2017-05-26 17:37:18 -04:00
Dinu Kumarasiri
8f5be5a434 [Lint] Add content description to image views 2017-05-20 11:51:22 +02:00
Dmitry Brant
38e7cad345 Final touch-ups to improved image loading. 2017-05-19 17:19:10 +02:00
Dinu Kumarasiri
83727e43e6 Add upload date to the image description 2017-05-15 11:27:21 +02:00
Tobias Schönberg
c6a2f2c7ea Get coordinate template when parsing image page
Currently the image detail view does not display the
coordinates.
This commit adds the coordinate template to the
parser and displays the results rounded to 4 digits.
2017-05-13 16:09:01 +02:00
Neslihan
86c24817b1 Use ?attr/mainBackground instead 2017-03-18 12:28:55 +03:00
Neslihan
85d0ce2c30 Fix details backgorund for both of themes 2017-03-18 11:50:53 +03:00
Neslihan
f2c22b9018 Add white background to fragment media detail 2017-03-18 02:16:13 +03:00
Neslihan
23aa691275 Prepare xml files 2017-03-15 18:58:57 +03:00
Josephine Lim
3a813dd302 Merge pull request #421 from maskaravivek/fixLintIssues
Fix lint issues
2017-03-12 20:44:55 +10:00
Neslihan
87e1ffd234 Fix Lint errors/warnings - HardcodedText: Hardcoded text 2017-03-11 12:13:52 +03:00
maskara
6df9ee272f Fix lint issue: ScrollView size validation 2017-03-10 23:28:00 +05:30
veyndan
62b434af35 Replace fill_parent with match_parent 2017-02-25 22:34:05 +00:00
Anirudh S
12aac68bcb Cleanup layout xml code so that it follows one consistent format 2016-10-31 12:25:21 +05:30
Yusuke Matsubara
b4231bbfdc Merge "commons" into the project root directory 2016-07-02 16:48:57 +09:00
Renamed from commons/app/src/main/res/layout/fragment_media_detail.xml (Browse further)